From patchwork Thu Feb 22 06:13:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 204569 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:aa16:b0:108:e6aa:91d0 with SMTP id by22csp61249dyb; Wed, 21 Feb 2024 22:13:49 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW2TeS+se/F5NY+1HwcdJ57iWaCu5uSZsqLvmse7bB2QHrVbuEWvegml6D0iqHJHHNVJ4YzRPGOGwrQqN1EkBiKBN3oBQ== X-Google-Smtp-Source: AGHT+IGpAIGtawJZAgRC90HemeXeoxSh/VKju60AYKDAdx6EIfzJ+y5vPXL1X4buXbOkgDHjN1J7 X-Received: by 2002:ac8:5bca:0:b0:42e:3233:d1c with SMTP id b10-20020ac85bca000000b0042e32330d1cmr2772006qtb.2.1708582429511; Wed, 21 Feb 2024 22:13:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708582429; cv=pass; d=google.com; s=arc-20160816; b=rKr10yQ7E57pN05/B3gBIEHS/v5e+Udox9mq1IIE95eSuCMGbr0EOauvIBm5fQZJty D5WWuRR3xqij1xMJ1JQ4kIts1K6AWeXvcEUiyfkpN4AYNJzDtPF+cUImRXk4nVKVJXUX X4WXbDcPJuyJHfcGoO0SvUyhtxySf5jX2GTPcsWB+4gVHNWACnlY2IvYV59k/p8pCobk vaPIyx/UqQ6mUC91+RLz3ViQJq8v7LT7UAN74lmuYqKwgODIxAljIfWyjrUSKovdsyH8 7XNf8+6w49F1R4nCMUhcvSkvZM2DQU76SuM2KmzaZj7ASQia3NwIoYhtVTYysxqLgLnI PzBg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:subject:cc:to:from:date :dkim-signature; bh=/yg7tRxzbV+EmatCrfewdaj9UpcnaRdPJGRrG9tMkoc=; fh=e3EgnfFznOfvO4x6nTnEfbygx+nLtsWK+K1IbsxVOds=; b=zeyuLNgpg7ylH1CW+CWH8Tp8B7wk1wEosrr+zmKlJqEya32UAA8GmGxlhJa4CQhwp8 lTaNvKm3sFrBQ/8xvbtjDKHwhBEh0ckZ7iK4EXTKsXU5d8YLtAJhh5qteL7TYPV00oVF 3fRd11GiQZjhd5QnzTmIuqzUb10qy457t6Rf2qYI3tOC9ZkUfd/l+r6tVAyZ64d+KOqL vvgt3TqFAm8M+LBhLMEH39KBocvl5rM6YYc08ZGQmll/41JjKAnBuUStCcHPU4VFdb5V t4EKYVf8dSQke3pJy+ye7GiU5u/brG9EVFdzB2ZPt5IKkfwUaixvQt2nDebclKr5hNSB uK3w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mYkaeP4m; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-75970-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75970-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id u18-20020ac87512000000b0042c66f982dasi12115197qtq.358.2024.02.21.22.13.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 22:13:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75970-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mYkaeP4m; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-75970-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75970-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 412021C21861 for ; Thu, 22 Feb 2024 06:13:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 82A0317BAC; Thu, 22 Feb 2024 06:13:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mYkaeP4m" Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E3F1179AC for ; Thu, 22 Feb 2024 06:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708582408; cv=none; b=FPW3BhlOqEHciaTiXxzrqIkjD5KK8B9KGylWFxLLDJ0mnort2rCWn7TU5ohgvTikMkCWOfvEZ4E3jSxJqL0oRdY9lQ1UW/3Jn4rd0nl3ushw/rqddyYAgbmWG3xEXXKlA0bVp6fQpOpXX795pF8TDVwCQvD5nvf9a5KB+jEcZSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708582408; c=relaxed/simple; bh=UXEAEw7UmL2MRU38lPF6CscWJjihKIKdWohwWysbVHM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=MhmPKo2nuL0gT+fLjOGOy3N0HgOdjXaZ40nIWsF2EKyhliisDDyWZHQV+SrZSEQw/GGcY8ldvtvSqpApL7ehgZjkMMfQj5DqNVMdxUUS/7eZrWhH3IXNvwF5SHmTLjQrRhflc+wwDrfYXHRAEFQRX8dRXJ5AIxzntAkuAjrkptY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mYkaeP4m; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4125e435b38so40881475e9.0 for ; Wed, 21 Feb 2024 22:13:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708582405; x=1709187205; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=/yg7tRxzbV+EmatCrfewdaj9UpcnaRdPJGRrG9tMkoc=; b=mYkaeP4m9bJyAN/MEpgtby9DCAeXot4g9eSiY7HdZJhW0J0UB+dP11Y1YV57kA2eNE 2KIlcnHZjcPYpcMVxnYnlvpRaD7feqNjo19XZ8x3vd9SA8D12kyi+5oOS7KO5OKkS0ys HI8B713RR8bSXXbwUP8DMbplqaeePNQ+Ru09lK2sBt/AW/25yg8ejA4/v7CkLWYgXU4e 5JPc62lE7P0hldOarTvaQY4zix7GjhQnQxHy42qzNpLTb25Is3+SL7DUprdJJdsPI9Tz gqgfEkSlghv3KIVHCvbrKN1qi2uk54olrCC3hyREHwZj8UzDekSuUbaJwlY3GennRAFt KcYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708582405; x=1709187205; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/yg7tRxzbV+EmatCrfewdaj9UpcnaRdPJGRrG9tMkoc=; b=AAo4TaC9Gw8OYqetBGHRyC6PIgKOiI13/KwmICeFxqQKvtm/KKX3CMxV+p/wMu2FUX tuIWZs4BtJMvyap3i+J0kSTwx3zNQWHloiFsodFdM6RMn3/Q3WdiVtC0CpyxUy4tVSlI V0qGP+3kOmH9ST4Ft3rVfR3yOjnFVwiB/H2dbble79W/XS5h5DQu+MR2AvDNDoIEhr2k fddHmTTBp8vU028I64HNysw8xDQGrLcdNFMtuq3ovEA5vnezB7ooa3UIOuzSGbhBL9ah Y3Fj9WHgT9Fx9QHsiWC1PAjVSSxiaEntHb2XHVL58k/uc3oufRgIuypWeqw+eTb+VvE+ MXiA== X-Forwarded-Encrypted: i=1; AJvYcCWyRfo0ONS0olsHswJcyrYsiY8OTYW2RyIJp9E8f2URHgVCva/+b2Vz1f/YnB2zSzXDyl5ka46xfzyKIEd6iCy3j5iaeKq4Kj2S3hdS X-Gm-Message-State: AOJu0YyivekIiGUmzKn5ds2SlW2QMAvErFWW0eiNAfbjNTe/ZUS3yhgX FkxlR7QYE2acDVIns/gQPGu9+88Ic7Fvl8G+t28rcSb4IODYQy2LA82O2XgpWKE= X-Received: by 2002:a05:600c:4f04:b0:412:8850:9c6f with SMTP id l4-20020a05600c4f0400b0041288509c6fmr258709wmq.31.1708582405588; Wed, 21 Feb 2024 22:13:25 -0800 (PST) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id x14-20020a05600c21ce00b00412704a0e4asm4841890wmj.2.2024.02.21.22.13.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 22:13:25 -0800 (PST) Date: Thu, 22 Feb 2024 09:13:21 +0300 From: Dan Carpenter To: Thomas Zimmermann Cc: Javier Martinez Canillas , Helge Deller , Huacai Chen , Ard Biesheuvel , Hans de Goede , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] firmware/sysfb: fix an error code in sysfb_init() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791578529627733931 X-GMAIL-MSGID: 1791578529627733931 This error path accidentally returns success when it should preserve the error code from sysfb_parent_dev(). Fixes: 4e754597d603 ("firmware/sysfb: Create firmware device only for enabled PCI devices") Signed-off-by: Dan Carpenter Reviewed-by: Thomas Zimmermann --- drivers/firmware/sysfb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/sysfb.c b/drivers/firmware/sysfb.c index a6b48703dc9e..880ffcb50088 100644 --- a/drivers/firmware/sysfb.c +++ b/drivers/firmware/sysfb.c @@ -127,8 +127,10 @@ static __init int sysfb_init(void) sysfb_apply_efi_quirks(); parent = sysfb_parent_dev(si); - if (IS_ERR(parent)) + if (IS_ERR(parent)) { + ret = PTR_ERR(parent); goto unlock_mutex; + } /* try to create a simple-framebuffer device */ compatible = sysfb_parse_mode(si, &mode);