Message ID | a989b3b798ecaf3b45f35160e30e605636d66a77.1669044086.git.geert+renesas@glider.be |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1654153wrr; Mon, 21 Nov 2022 07:24:44 -0800 (PST) X-Google-Smtp-Source: AA0mqf7HQV+mdakE401IUTKBBBhoMFvumIWVM9g1Yq617M/mBe/u4AV8ZPFA+fK/YC4KBPyIF/cR X-Received: by 2002:a17:906:a291:b0:782:9b27:94aa with SMTP id i17-20020a170906a29100b007829b2794aamr15227528ejz.542.1669044283823; Mon, 21 Nov 2022 07:24:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669044283; cv=none; d=google.com; s=arc-20160816; b=WFMtW3AwIIj6UISFoBefEzxRXMWfiSfOBeVhxKy7LtIucraukGMtC2VlEMZLkl78YA VAejm8x24ayELLyvlrSNfenHhd7u8Jk4GnTqGO0CSVRoFZMpkgsPmuXIXhN5drgJh2tU bSZZLzwjzkh878QgokzR6+L8Vq58j7+NKT6BzkNkl299+ih3vFdm7ywXRqGuFc7kbX+d FK9YdTtBwm0Z64Q0eKlYp0ptD4NpiGz5NPhmsBNA04V5NTppbsaR67IxtNHiG+1SHzPZ Fzy+uu2C0owGqGIoPM4Rs1WEgpWjxXu31iDz41yh2um738brFTk5cge+C5GosRWSP186 /pSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=GuCiDQaKNuxkYP5SIMCJ55CJ6HfQ7OPr6HRDVBQmy0A=; b=bDsRe0IXPcabk5qsNRAun4bsrOglW7UBWVhwKm/71AphNqw9+3b9X/rodtAZEapwoQ l0wPk7mgFXP1UhqkOrHac2+M5KHy7S+f5UkEFTH9cw85QCRbSOW9sGVK1buOiNkjJk5+ 1TJJzmlb+OinP6XLJVpNTCyHgEvFgUnnLpeLJ9RMRpPiCwYtWMeLUV8UaAd/ua3NIiYA xMiTtuNDZSHCOZZyatddrzqyWSHE/fgD2lJoJcTv5+1jYIz0OPyABFHsabI9L5XLBfku 5Mn013Qt/l++UrjV0fEMtnV3yKX+eiju/mQA7lKjLPPU/9OAofoeb/bBHGfSzVnm32j0 Sf+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wd3-20020a170907d60300b007ae72eabbcbsi3306884ejc.824.2022.11.21.07.24.17; Mon, 21 Nov 2022 07:24:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232107AbiKUPXQ (ORCPT <rfc822;cjcooper78@gmail.com> + 99 others); Mon, 21 Nov 2022 10:23:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbiKUPWu (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 21 Nov 2022 10:22:50 -0500 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB693D87 for <linux-kernel@vger.kernel.org>; Mon, 21 Nov 2022 07:22:26 -0800 (PST) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed10:4821:1ba5:2638:5c3a]) by baptiste.telenet-ops.be with bizsmtp id n3NP2800R5WXlCv013NP3Q; Mon, 21 Nov 2022 16:22:24 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from <geert@linux-m68k.org>) id 1ox8cp-0019CK-PT; Mon, 21 Nov 2022 16:22:23 +0100 Received: from geert by rox.of.borg with local (Exim 4.93) (envelope-from <geert@linux-m68k.org>) id 1ox8co-00BPxI-VQ; Mon, 21 Nov 2022 16:22:22 +0100 From: Geert Uytterhoeven <geert+renesas@glider.be> To: Linus Walleij <linus.walleij@linaro.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be> Subject: [PATCH] usb: USB_FOTG210 should depend on ARCH_GEMINI Date: Mon, 21 Nov 2022 16:22:19 +0100 Message-Id: <a989b3b798ecaf3b45f35160e30e605636d66a77.1669044086.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750119778568081476?= X-GMAIL-MSGID: =?utf-8?q?1750119778568081476?= |
Series |
usb: USB_FOTG210 should depend on ARCH_GEMINI
|
|
Commit Message
Geert Uytterhoeven
Nov. 21, 2022, 3:22 p.m. UTC
The Faraday Technology FOTG210 USB2 Dual Role Controller is only present
on Cortina Systems Gemini SoCs. Hence add a dependency on ARCH_GEMINI,
to prevent asking the user about its drivers when configuring a kernel
without Cortina Systems Gemini SoC support.
Fixes: 1dd33a9f1b95ab59 ("usb: fotg210: Collect pieces of dual mode controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/usb/fotg210/Kconfig | 1 +
1 file changed, 1 insertion(+)
Comments
On Mon, Nov 21, 2022 at 4:22 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > The Faraday Technology FOTG210 USB2 Dual Role Controller is only present > on Cortina Systems Gemini SoCs. Hence add a dependency on ARCH_GEMINI, > to prevent asking the user about its drivers when configuring a kernel > without Cortina Systems Gemini SoC support. > > Fixes: 1dd33a9f1b95ab59 ("usb: fotg210: Collect pieces of dual mode controller") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Ok that's fair. When Faraday merged these drivers they probably had some other system(s) in mind, but they don't talk much recently so: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Mon, Nov 21, 2022 at 4:22 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > The Faraday Technology FOTG210 USB2 Dual Role Controller is only present > on Cortina Systems Gemini SoCs. As it turns out, this is not true. The TI nSpire uses this too, I should have noted since the nSpire maintainer was patching the driver... https://lore.kernel.org/linux-usb/20210324141115.9384-1-fabian@ritter-vogt.de/ Shall we revert it or just add another clause for the nSpire? Yours, Linus Walleij
Hi Linus, On Mon, Dec 5, 2022 at 11:24 PM Linus Walleij <linus.walleij@linaro.org> wrote: > On Mon, Nov 21, 2022 at 4:22 PM Geert Uytterhoeven > <geert+renesas@glider.be> wrote: > > The Faraday Technology FOTG210 USB2 Dual Role Controller is only present > > on Cortina Systems Gemini SoCs. > > As it turns out, this is not true. The TI nSpire uses this too, I should have > noted since the nSpire maintainer was patching the driver... > https://lore.kernel.org/linux-usb/20210324141115.9384-1-fabian@ritter-vogt.de/ > > Shall we revert it or just add another clause for the nSpire? Oh, but the integration is not (yet) upstream, as I didn't find any "faraday,fotg210" outside gemini.dtsi. I guess another clause would be the most-userfriendly solution. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Tue, Dec 6, 2022 at 9:01 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Mon, Dec 5, 2022 at 11:24 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Mon, Nov 21, 2022 at 4:22 PM Geert Uytterhoeven > > <geert+renesas@glider.be> wrote: > > > The Faraday Technology FOTG210 USB2 Dual Role Controller is only present > > > on Cortina Systems Gemini SoCs. > > > > As it turns out, this is not true. The TI nSpire uses this too, I should have > > noted since the nSpire maintainer was patching the driver... > > https://lore.kernel.org/linux-usb/20210324141115.9384-1-fabian@ritter-vogt.de/ > > > > Shall we revert it or just add another clause for the nSpire? > > Oh, but the integration is not (yet) upstream, as I didn't find any > "faraday,fotg210" outside gemini.dtsi. Ah it is still brewing, sorry. > I guess another clause would be the most-userfriendly solution. Yeah we can just add it when adding nSpire II. Yours, Linus Walleij
diff --git a/drivers/usb/fotg210/Kconfig b/drivers/usb/fotg210/Kconfig index 534206ee0d1db74f..dad1b088aba59217 100644 --- a/drivers/usb/fotg210/Kconfig +++ b/drivers/usb/fotg210/Kconfig @@ -4,6 +4,7 @@ config USB_FOTG210 tristate "Faraday FOTG210 USB2 Dual Role controller" depends on USB || USB_GADGET depends on HAS_DMA && HAS_IOMEM + depends on ARCH_GEMINI || COMPILE_TEST default ARCH_GEMINI select MFD_SYSCON help