From patchwork Fri Feb 3 22:05:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Poimboeuf X-Patchwork-Id: 52678 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1080240wrn; Fri, 3 Feb 2023 14:08:05 -0800 (PST) X-Google-Smtp-Source: AK7set+TirLyW5Lrf6wTs6upM6YBQWttYURDoEKuNUqDlY5kHoBub9O38zbVR/0W2FTmidn0CfoD X-Received: by 2002:a05:6a20:3d90:b0:bc:fe09:950b with SMTP id s16-20020a056a203d9000b000bcfe09950bmr15065693pzi.10.1675462085194; Fri, 03 Feb 2023 14:08:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675462085; cv=none; d=google.com; s=arc-20160816; b=K3Wi6fDuQYJgfWj3WqUpXOAwxR+wij9DX5mc1FIlKhg6LhJWmDMcuAqs2ygwhhdepH Ew8dYO5cS4/vlvZiyEhx4cSdTnA+X0h2czmlda9caVGFmLKfWBf2NqkMmpI6me79UqIZ jkM1Fse6oFJJRazRjaYFLSmyuAE6cRP7y00lMhui6uEDPQpjVGvXRBxcKxxbNj3H4b1N DEbF+JBtCD2JtmJ/PRxb5cULHOGAeYNnEn6lhD956xE69xhaQUvjcidC+4qsIhJaSiG7 NHtuKVUm95AFhEVRfHrnoZxTnclLoravoB1GOCRiOWCVBx9hEzZgxUryX22xo18WkwRf CQSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kcgOHM3rJbN88C4wuReQwX+tQJ0s9P4oqdWShATmfvE=; b=XGygekIsX4xrn/r0RCbsAK2mF9D7GaCv4a8t05wKdM2ZVrg2WG/+A7jW/yco3Bz3u+ EKH7LOZUrn3y9OSVNER6kxvjKVKx5tD9g376LQcSGgYM6ChRnX6ShePvKK6H7YOAlosD Jv19nfzmC3XDNdOllFOGlCAgSvMSEyJCiVJqTUEzX29QDj+XJ0hJrXlvlvoV6dFRJkEH y24zRAZAiAGnXDxEQKM4Bhwa590Uxe2s7AjN/E0Eak5eqog5L3mWqIuMiJ9s8fLhZjgG Zmdzyn4CN+gxnWrNg9v2V9HcAE9QQ+l61wVuwt8/LBr5wbaKWi0lpLTjJSAdr8IUDgBU nteQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DhDkIMUj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g12-20020a63374c000000b004f29d323701si4073075pgn.619.2023.02.03.14.07.52; Fri, 03 Feb 2023 14:08:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DhDkIMUj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234045AbjBCWHo (ORCPT + 99 others); Fri, 3 Feb 2023 17:07:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233929AbjBCWHD (ORCPT ); Fri, 3 Feb 2023 17:07:03 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1A8FAF6BD; Fri, 3 Feb 2023 14:06:08 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E77EDB82C2C; Fri, 3 Feb 2023 22:06:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E08DFC433EF; Fri, 3 Feb 2023 22:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675461965; bh=X1eIlBV7mYZUrbC//4ufL+T75dx0a2gkyRGVpnoY/QM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DhDkIMUjEJOyX2EMlHrPxdUnBWRX3se0vLGO731POCqHk9/VQrMV/gXm8Vb9/Z2m3 UvzerGv0nP8kmAJhO23jS42gvkc6o8sJJTyUd/dleHrvmoqm98KN02bKtkQZO7MfFL WiEZU6kpXcLgGxhn/vJpxLEiRCyGWZl3pjakg3znFOX8OkwD/QWUnY0u+Z51AYGuT1 3ZX1IoRQ7B7uGKZ1bvIOTbD3JdF+6rUUJYCcYypC+Tlbn/Ml8u53/6kdTb+Sog6/sv AsLRZWp+uNctE1zUajMgDNYRMYvTo3DPuPNnHQwSTW0D6vHT8JOdvEDURTxD2SUNqz O5cRPvgdcbiQQ== From: Josh Poimboeuf To: linux-kernel@vger.kernel.org Cc: jgross@suse.com, richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, linux-alpha@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, jiaxun.yang@flygoat.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, linuxppc-dev@lists.ozlabs.org, ysato@users.sourceforge.jp, dalias@libc.org, linux-sh@vger.kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com, linux-xtensa@linux-xtensa.org, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, paulmck@kernel.org Subject: [PATCH 13/22] sh/cpu: Make sure play_dead() doesn't return Date: Fri, 3 Feb 2023 14:05:22 -0800 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756849331527144884?= X-GMAIL-MSGID: =?utf-8?q?1756849331527144884?= play_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Signed-off-by: Josh Poimboeuf --- arch/sh/include/asm/smp-ops.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sh/include/asm/smp-ops.h b/arch/sh/include/asm/smp-ops.h index e27702130eb6..63866b1595a0 100644 --- a/arch/sh/include/asm/smp-ops.h +++ b/arch/sh/include/asm/smp-ops.h @@ -27,6 +27,7 @@ static inline void plat_smp_setup(void) static inline void play_dead(void) { mp_ops->play_dead(); + BUG(); } extern void register_smp_ops(struct plat_smp_ops *ops);