From patchwork Sat Jun 3 08:14:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhangjin Wu X-Patchwork-Id: 102799 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1546921vqr; Sat, 3 Jun 2023 02:06:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6dO4FdJtHlf16DB8XnupKmTt85lJEx0BwmixJKhM2ca0zcUlnnTyLYwo01JRKqzDqQZXe8 X-Received: by 2002:a17:90a:578a:b0:247:26da:5de2 with SMTP id g10-20020a17090a578a00b0024726da5de2mr2081042pji.20.1685783197728; Sat, 03 Jun 2023 02:06:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685783197; cv=none; d=google.com; s=arc-20160816; b=mq3FgBn95CXJVQqABRD5/GTeG/pFice6Kl3MqER97DyghMHlGHNI6nNYLDEdO1agGc yE8pPXlcrInn9dHkNYWz/VttPWrV29GzQBr0HCQlYflIe/+nf4XGuetQMiy7FGifUftN rObyK07OpbzS2SDgE+X/sJS9hmCk+O2VMrwRFjoFwHPrhdXXBcRayaKz5NMyXtM9rL38 2MWywsdU+gQVfwseoYDC3dxXSpoSoFM6dq7mz3l/tL2aqAxWuLpaO0P2/gZm6mTYBVpr vAPYtF9c9CElM2dfXppygSCz475PfDHoVhHi2aUs5Zt2i+tkJKg/97gq33H4nexBsP8m R2KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=lzSS5uON/wixu87OLX2VDBmg+fpAh1JlbkRI+4G2+dM=; b=wPr5yX5LlSJ3KRBOivbdBvf0IKnuaKAaNnlTn3+VWbFGC9EsnswJ1TdXSZELSXU9+J HVmnfA7Ia1qBHoVkzWhAII+ZI4V2kZQjP/4R27gaz0+VS0Cn47ezvVaYc6QTY0B568zA uvkV/+ODqjSYvElnwq8penxuUEc052vVQiUVzSqr9E5j4s4i5N9153v8vo5RFoYNvjhz uG9C5UXAVI/cQVqY2mNRZiDeuD2hfQ9bAQvFKPRaVqEGDXP289RCih63Dy6sOhBOhet/ wmubzsfvttCgQFulRUAx824LW8c+dM3TT9xEpg3erWiIp2AdBOZ58ebsgScuerhk/XcJ T3pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i6-20020a17090acf8600b0024e37ccb3fesi2391427pju.68.2023.06.03.02.06.26; Sat, 03 Jun 2023 02:06:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234411AbjFCIPM (ORCPT + 99 others); Sat, 3 Jun 2023 04:15:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbjFCIPK (ORCPT ); Sat, 3 Jun 2023 04:15:10 -0400 Received: from bg4.exmail.qq.com (bg4.exmail.qq.com [43.155.65.254]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12AB71B3; Sat, 3 Jun 2023 01:15:08 -0700 (PDT) X-QQ-mid: bizesmtp86t1685780099tqgbsuv9 Received: from linux-lab-host.localdomain ( [119.123.130.226]) by bizesmtp.qq.com (ESMTP) with id ; Sat, 03 Jun 2023 16:14:58 +0800 (CST) X-QQ-SSF: 01200000000000D0V000000A0000000 X-QQ-FEAT: r/cTxDoDoiFSJcynUBZ645fSSLznEC5jgi3uRP7p6xwjwJ8yn76kBQYvv1+GG iSipIpMWgeICdSXmOhHNqLO/hOb9a5g5856OSS72uk43s6aREo8TPK0o30mBeug9pyUBLrA ZiLJ8k7sA6+0MXELj+RZn+XGSSA3Q/ntnx/vUhzeGoY2kBexAX2DklILwcrBfrSx9afdubX 497b/Fry/Cf0DfK9l+fgBCU+RlJuaZonwfKrkQFZ1LqdSm2vkoorwENzGUUoJWn62agPV3l x6N4lgt6iYLXz2z/uvnNqE1SuEJs29gQz+108F2wiJv9flrYxecsaTZHFgzU5qNIgNKyV55 67KtRV6ZoEdOMjWid/N6HLbKZ6RVvaA0n+W19QwOz6ykH3goDRIarP5h2O/snuiSaYfMmm+ X-QQ-GoodBg: 0 X-BIZMAIL-ID: 8443338395293632196 From: Zhangjin Wu To: w@1wt.eu Cc: falcon@tinylab.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, thomas@t-8ch.de Subject: [PATCH v3 10/12] selftests/nolibc: remove gettimeofday_bad1/2 completely Date: Sat, 3 Jun 2023 16:14:55 +0800 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:tinylab.org:qybglogicsvrsz:qybglogicsvrsz3a-3 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767671802366268653?= X-GMAIL-MSGID: =?utf-8?q?1767671802366268653?= In the clock_gettime / clock_gettime64 syscalls based gettimeofday(), there is no way to let kernel space 'fixup' the invalid data pointer of 'struct timeval' and 'struct timezone' for us for we need to read timespec from kernel space and then convert to timeval in user-space ourselves and also we need to simply ignore and reset timezone in user-space. Without this removal, the invalid (void *)1 address will trigger a sigsegv (signum = 11) signal and stop the whole test. Suggested-by: Willy Tarreau Link: https://lore.kernel.org/linux-riscv/20230528113325.GJ1956@1wt.eu/ Signed-off-by: Zhangjin Wu --- tools/testing/selftests/nolibc/nolibc-test.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c index a1c402ce32f4..bf63fc66e486 100644 --- a/tools/testing/selftests/nolibc/nolibc-test.c +++ b/tools/testing/selftests/nolibc/nolibc-test.c @@ -588,10 +588,6 @@ int run_syscall(int min, int max) CASE_TEST(getdents64_root); EXPECT_SYSNE(1, test_getdents64("/"), -1); break; CASE_TEST(getdents64_null); EXPECT_SYSER(1, test_getdents64("/dev/null"), -1, ENOTDIR); break; CASE_TEST(gettimeofday_null); EXPECT_SYSZR(1, gettimeofday(NULL, NULL)); break; -#ifdef NOLIBC - CASE_TEST(gettimeofday_bad1); EXPECT_SYSER(1, gettimeofday((void *)1, NULL), -1, EFAULT); break; - CASE_TEST(gettimeofday_bad2); EXPECT_SYSER(1, gettimeofday(NULL, (void *)1), -1, EFAULT); break; -#endif CASE_TEST(getpagesize); EXPECT_SYSZR(1, test_getpagesize()); break; CASE_TEST(ioctl_tiocinq); EXPECT_SYSZR(1, ioctl(0, TIOCINQ, &tmp)); break; CASE_TEST(ioctl_tiocinq); EXPECT_SYSZR(1, ioctl(0, TIOCINQ, &tmp)); break;