From patchwork Wed Jan 24 05:17:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Golle X-Patchwork-Id: 191367 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2553:b0:103:945f:af90 with SMTP id p19csp786263dyi; Tue, 23 Jan 2024 21:18:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IGO5Vi4n0zMtC6vy7GVl1x6WxM8vo+70azGKzP9pDplNIVizFES0zfU0Up72P5XMM/KN7rP X-Received: by 2002:a05:6214:20a6:b0:683:815f:61f9 with SMTP id 6-20020a05621420a600b00683815f61f9mr2480411qvd.73.1706073503715; Tue, 23 Jan 2024 21:18:23 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706073503; cv=pass; d=google.com; s=arc-20160816; b=QeDGBtCpoOgPtzf/SUy+8yq53GXGSzbsJjJcn+QNwa9/fZW6Sy9c1BHIlFeszuesfz 53NcqkOdDIxZTXe67bJQ95nefyxSOAKozhGCBBe2yIO9zZK4TQl0Nr2zktRwHh9nFoUW WzqEs4amk7XA8BFjz0FisH9MVdrucbdWpnKAC55JW0y4hVJBmJ87IiA83nR7x1KhEckf WSwTPAabhttMPEqpbrf1HYHWnujV89RSZNNPqkShylSA30LwjqTbkQdL85PQILNMmSBn e6m2tjsuKEKdF9JZaNtTrVLQk+yIrYEEHeE6FzWr3Fn+qxHdAewktGykuBvRJOuMnGIJ 37Cg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:subject:cc:to:from:date; bh=XNiwvYR0sbKZZynRPIUFLzn9Wcb2cw2TWYiLCwpV8zQ=; fh=hKBU0hrtOSdLQMPa/Vr+1MsshUq0adi5jIXr2TUszko=; b=Ct3wL3PF3UW5FJRoVzGDndjYXlI/a6rZzSV3jIMtxIcDehkG6yIHuKLy7+GCXQcsSl 9m6fqX9nozLPaxeD3JgYiywaTTh0BsJzWtBXL7LSq1OJ3jtZubcv1AK5hvkRXCCjp3F3 ZJH1FQK+UibNJS5EjM0uXlBbmrrGWnTRYpMtxoCnsPJ65cJHD5rd3evXIN6M4XZega/E qSk4xP9AMqrRrnkVIgZwJTQitncRUd5IP1Nwuv/fF735nB6ZW5XKro9ifYWfOGad+9uA 1ImHQjK2WF+VntsTdQ1OQveBDX+TuvLqW9086cAM170nfqRtDt4ql/yUCjzdRWYz7922 pIYw== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=makrotopia.org); spf=pass (google.com: domain of linux-kernel+bounces-36465-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36465-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id o4-20020a05620a22c400b00781d55a24a1si9337977qki.221.2024.01.23.21.18.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 21:18:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-36465-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=makrotopia.org); spf=pass (google.com: domain of linux-kernel+bounces-36465-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36465-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 80FF31C23687 for ; Wed, 24 Jan 2024 05:18:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2C13EF9FF; Wed, 24 Jan 2024 05:17:58 +0000 (UTC) Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5B55DDD0; Wed, 24 Jan 2024 05:17:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706073476; cv=none; b=Fha3yk8saVAEAAQvyK3MgjROC7S7cLB+0wbZyr8QfDGvGwPQr9I9G9hPAUiv4sGkSFCZpg/G+Awz1bCBQAAv3DU5/Ir9mjBTQ6rC6lBGVBb041chy81GNtn8P/JH2gJ2WVHXtavkvR+2jC+mN9bIJ/jwu/aMDYmtCqeChS7Rdy4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706073476; c=relaxed/simple; bh=D4U+G3+No+qUuQObL6c1NR2hyUkPlZqGZyAIN1w4kis=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=QkasSzyHwDHe5FeRJ6BerUnFDB5cB2qhYzYlsWBOpQ0N20ISLjat0QcwSDD4eTtkXW1tm1fIBn/NmTW2b8nIynH8oP756gpWjeHo8lcmoOV038XPGW9xa2iz175aFcqBktcEGr3FvUBQRL+C1ukyp4Wf2gB7NCGRWvxKEni4dzU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rSVdj-00010p-1D; Wed, 24 Jan 2024 05:17:32 +0000 Date: Wed, 24 Jan 2024 05:17:25 +0000 From: Daniel Golle To: =?utf-8?b?QXLEsW7DpyDDnE5BTA==?= , Daniel Golle , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: John Crispin Subject: [PATCH net] net: dsa: mt7530: fix 10M/100M speed on MT7988 switch Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788947730243000649 X-GMAIL-MSGID: 1788947730243000649 Setup PMCR port register for actual speed and duplex on internally connected PHYs of the MT7988 built-in switch. This fixes links with speeds other than 1000M. Fixes: ("110c18bfed414 net: dsa: mt7530: introduce driver for MT7988 built-in switch") Signed-off-by: Daniel Golle Reviewed-by: Vladimir Oltean Acked-by: Arınç ÜNAL --- drivers/net/dsa/mt7530.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index f8ecc354630b0..fbd52ff7cbd6e 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2843,8 +2843,7 @@ static void mt753x_phylink_mac_link_up(struct dsa_switch *ds, int port, /* MT753x MAC works in 1G full duplex mode for all up-clocked * variants. */ - if (interface == PHY_INTERFACE_MODE_INTERNAL || - interface == PHY_INTERFACE_MODE_TRGMII || + if (interface == PHY_INTERFACE_MODE_TRGMII || (phy_interface_mode_is_8023z(interface))) { speed = SPEED_1000; duplex = DUPLEX_FULL;