diff mbox series

[1/1] perf python: Fix binding linkage due to rename and move of evsel__increase_rlimit()

Message ID ZTu8Kgb2KqifMBZ3@kernel.org
State New
Headers
Series [1/1] perf python: Fix binding linkage due to rename and move of evsel__increase_rlimit() |

Commit Message

Arnaldo Carvalho de Melo Oct. 27, 2023, 1:33 p.m. UTC 
  The changes in ("perf evsel: Rename evsel__increase_rlimit to
rlimit__increase_nofile") ended up breaking the python binding that now
references the rlimit__increase_nofile function, add the util/rlimit.o
to the tools/perf/util/python-ext-sources to cure that.

This was detected by the 'perf test python' regression test:

  $ perf test python
   14: 'import perf' in python        : FAILED!

  $ perf test -v python
  Couldn't bump rlimit(MEMLOCK), failures may take place when creating BPF maps, etc
   14: 'import perf' in python                                         :
  --- start ---
  test child forked, pid 2912462
  python usage test: "echo "import sys ; sys.path.insert(0, '/tmp/build/perf-tools-next/python'); import perf" | '/usr/bin/python3' "
  Traceback (most recent call last):
    File "<stdin>", line 1, in <module>
  ImportError: /tmp/build/perf-tools-next/python/perf.cpython-311-x86_64-linux-gnu.so: undefined symbol: rlimit__increase_nofile
  test child finished with -1
  ---- end ----
  'import perf' in python: FAILED!
  $

Fixes: e093a222d7cba1eb ("perf evsel: Rename evsel__increase_rlimit to rlimit__increase_nofile")
Acked-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Yang Jihong <yangjihong1@huawei.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: https://lore.kernel.org/lkml/ZTrCS5Z3PZAmfPdV@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/python-ext-sources | 1 +
 1 file changed, 1 insertion(+)

Comments

Namhyung Kim Oct. 30, 2023, 6:59 p.m. UTC | #1 
On Fri, 27 Oct 2023 10:33:30 -0300, Arnaldo Carvalho de Melo wrote:
> The changes in ("perf evsel: Rename evsel__increase_rlimit to
> rlimit__increase_nofile") ended up breaking the python binding that now
> references the rlimit__increase_nofile function, add the util/rlimit.o
> to the tools/perf/util/python-ext-sources to cure that.
> 
> This was detected by the 'perf test python' regression test:
> 
> [...]

Applied to perf-tools-next, thanks!
diff mbox series

Patch

diff --git a/tools/perf/util/python-ext-sources b/tools/perf/util/python-ext-sources
index 26e1c8d973ea0b95..593b660ec75e24e1 100644
--- a/tools/perf/util/python-ext-sources
+++ b/tools/perf/util/python-ext-sources
@@ -40,6 +40,7 @@  util/rwsem.c
 util/hashmap.c
 util/perf_regs.c
 util/fncache.c
+util/rlimit.c
 util/perf-regs-arch/perf_regs_aarch64.c
 util/perf-regs-arch/perf_regs_arm.c
 util/perf-regs-arch/perf_regs_csky.c