gfs2: No need to be "extern" at the time of definition

Message ID ZRZdKAmDjrpCQLwE@runicha.com
State New
Headers
Series gfs2: No need to be "extern" at the time of definition |

Commit Message

Deepak R Varma Sept. 29, 2023, 5:14 a.m. UTC
  No need to for the extern keyword at the time of function definition.
Remove it to silence the following Smatch warnings:
fs/gfs2/super.c:1579:13: warning: function 'free_local_statfs_inodes' with external linkage has definition
fs/gfs2/super.c:1594:21: warning: function 'find_local_statfs_inode' with external linkage has definition

Signed-off-by: Deepak R Varma <drv@mailo.com>
---
 fs/gfs2/super.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

--
2.39.2
  

Patch

diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
index 02d93da21b2b..fad36ed89853 100644
--- a/fs/gfs2/super.c
+++ b/fs/gfs2/super.c
@@ -1576,7 +1576,7 @@  static void gfs2_free_inode(struct inode *inode)
 	kmem_cache_free(gfs2_inode_cachep, GFS2_I(inode));
 }

-extern void free_local_statfs_inodes(struct gfs2_sbd *sdp)
+void free_local_statfs_inodes(struct gfs2_sbd *sdp)
 {
 	struct local_statfs_inode *lsi, *safe;

@@ -1591,8 +1591,7 @@  extern void free_local_statfs_inodes(struct gfs2_sbd *sdp)
 	}
 }

-extern struct inode *find_local_statfs_inode(struct gfs2_sbd *sdp,
-					     unsigned int index)
+struct inode *find_local_statfs_inode(struct gfs2_sbd *sdp, unsigned int index)
 {
 	struct local_statfs_inode *lsi;