diff mbox series

[1/1] perf build: Add missing comment about NO_LIBTRACEEVENT=1

Message ID ZR6+MhXtLnv6ow6E@kernel.org
State New
Headers
Series [1/1] perf build: Add missing comment about NO_LIBTRACEEVENT=1 |

Commit Message

Arnaldo Carvalho de Melo Oct. 5, 2023, 1:46 p.m. UTC 
  From: Arnaldo Carvalho de Melo <acme@redhat.com>

By default perf will fail the build if the development files for
libtraceevent are not available.

To build perf without libtraceevent support, disabling several features
such as 'perf trace', one needs to add NO_LIBTRACEVENT=1 to the make
command line.

Add the missing comments about that to the tools/perf/Makefile.perf
file, just like all the other such command line toggles.

Fixes: 378ef0f5d9d7f465 ("perf build: Use libtraceevent from the system")
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Makefile.perf | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Ian Rogers Oct. 5, 2023, 3:45 p.m. UTC | #1 
On Thu, Oct 5, 2023 at 6:46 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> By default perf will fail the build if the development files for
> libtraceevent are not available.
>
> To build perf without libtraceevent support, disabling several features
> such as 'perf trace', one needs to add NO_LIBTRACEVENT=1 to the make
> command line.
>
> Add the missing comments about that to the tools/perf/Makefile.perf
> file, just like all the other such command line toggles.
>
> Fixes: 378ef0f5d9d7f465 ("perf build: Use libtraceevent from the system")
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Ian Rogers <irogers@google.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/Makefile.perf | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 98604e396ac33643..456872ac410df4c0 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -69,6 +69,10 @@ include ../scripts/utilities.mak
>  # Define NO_LIBDW_DWARF_UNWIND if you do not want libdw support
>  # for dwarf backtrace post unwind.
>  #
> +# Define NO_LIBTRACEEVENT=1 if you don't want libtraceevent to be linked,
> +# this will remove multiple features and tools, such as 'perf trace',
> +# that need it to read tracefs event format files, etc.
> +#
>  # Define NO_PERF_READ_VDSO32 if you do not want to build perf-read-vdso32
>  # for reading the 32-bit compatibility VDSO in 64-bit mode
>  #
> --
> 2.41.0
>
> --
Namhyung Kim Oct. 12, 2023, 5:21 p.m. UTC | #2 
On Thu, Oct 5, 2023 at 8:45 AM Ian Rogers <irogers@google.com> wrote:
>
> On Thu, Oct 5, 2023 at 6:46 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >
> > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > By default perf will fail the build if the development files for
> > libtraceevent are not available.
> >
> > To build perf without libtraceevent support, disabling several features
> > such as 'perf trace', one needs to add NO_LIBTRACEVENT=1 to the make
> > command line.
> >
> > Add the missing comments about that to the tools/perf/Makefile.perf
> > file, just like all the other such command line toggles.
> >
> > Fixes: 378ef0f5d9d7f465 ("perf build: Use libtraceevent from the system")
> > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > Cc: Ian Rogers <irogers@google.com>
> > Cc: Jiri Olsa <jolsa@kernel.org>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Reviewed-by: Ian Rogers <irogers@google.com>

Applied to perf-tools-next, thanks!
diff mbox series

Patch

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 98604e396ac33643..456872ac410df4c0 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -69,6 +69,10 @@  include ../scripts/utilities.mak
 # Define NO_LIBDW_DWARF_UNWIND if you do not want libdw support
 # for dwarf backtrace post unwind.
 #
+# Define NO_LIBTRACEEVENT=1 if you don't want libtraceevent to be linked,
+# this will remove multiple features and tools, such as 'perf trace',
+# that need it to read tracefs event format files, etc.
+#
 # Define NO_PERF_READ_VDSO32 if you do not want to build perf-read-vdso32
 # for reading the 32-bit compatibility VDSO in 64-bit mode
 #