From patchwork Fri Oct 6 07:45:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Golle X-Patchwork-Id: 149146 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp152155vqo; Fri, 6 Oct 2023 00:48:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHkQe90f+yDAE3TsBSVROD+zZ8+VxlYceGsw9TtAHMKbITtXC1WDeF3cRPPgl4SwVQQ69iu X-Received: by 2002:a05:6a20:4418:b0:14d:16c:2d20 with SMTP id ce24-20020a056a20441800b0014d016c2d20mr9491952pzb.44.1696578518420; Fri, 06 Oct 2023 00:48:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696578518; cv=none; d=google.com; s=arc-20160816; b=k1Tb8A1q8dFHLu64PJP5c15R3keJ2wq9AttM2XCDpLUDoTDwuJMgs4JyWcvZ6yup1e kQjflqTvK7KAIVH6yx2C/HyvHQMtqIiXJfIGRu+/kn+dMSXLYwxwzb8oOzIfRipDIdRl fqGWGYvlaaqxfpQGRtmy1EixRXf1OHKU0kSyG05i3D6fwbr2cmOUrZI5rRMiJkqS8u5g BnHNDr2XfIaexxeRLmODrGdKHeeS8M7OG3I9nNCD6ympY6XsFPDpx7p7OsmeAFjp2YfK snXSQ6NVuopUM4s5iN5aaMlltyZYQ4oBUUuk+AsMFlSaLPH5sWohIUlQKPzcQnNdQ0H9 yxaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date; bh=JfeQthEyRcO4HnjndpPZvj7t1sp9LUoj0/kmQtjW57Y=; fh=aPk37Nk8CNOmq5kqM2ebP7OTHA6W/Z2fH5L8vlDPn7s=; b=XmY+htLQTUNwIF+fSG5mi1KpgEpf2C8MXy4m57rhwBcV5ye2kWfgci294kicamET3e RUwkbE50+KJQTCul/e09yIqPJErd70CoZhP8bCQ1MzNPKf8/ajGonSZGFVpxqLIICbeY e/oP7WPQuMgmiy1WjXYjybErr6veQyk9trFpEITm7NA1VfXnTR4D2Rs92asX6pcifKo/ A4mch5/q77oYiLy2FK3SL1tBig1e/oYD6jlvX4ORWAmE6M9ZYz6JbYMDZ/2JQWgpGqQw mGRIyxnG4Cb9/KpaRXIc/pCNle4sFJVdn+pG/aPVxNvn/W5tpBPt+bcBHrFoJWH7c5v6 IcSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id eg7-20020a056a00800700b0068e41f07f33si996491pfb.94.2023.10.06.00.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 00:48:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id D56C3804747D; Fri, 6 Oct 2023 00:48:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230355AbjJFHse (ORCPT + 18 others); Fri, 6 Oct 2023 03:48:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230300AbjJFHsc (ORCPT ); Fri, 6 Oct 2023 03:48:32 -0400 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2998CE4; Fri, 6 Oct 2023 00:48:30 -0700 (PDT) Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1qofZT-0004lD-0L; Fri, 06 Oct 2023 07:48:27 +0000 Date: Fri, 6 Oct 2023 09:45:58 +0200 From: Daniel Golle To: linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , Matthias Brugger , Bjorn Helgaas , Rob Herring , Krzysztof =?utf-8?q?Wilczy=C5=84ski?= , Lorenzo Pieralisi , Jianjun Wang , Ryder Lee Cc: Christian Marangi , Frank Wunderlich , John Crispin Subject: [PATCH] PCI: mediatek-gen3: fix PCIe #PERST being de-asserted too early Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 06 Oct 2023 00:48:37 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778991516118566623 X-GMAIL-MSGID: 1778991516118566623 The driver for MediaTek gen3 PCIe hosts de-asserts all reset signals at the same time using a single register write operation. Delay the de-assertion of the #PERST signal by 100ms as required by PCIe CEM clause 2.2, some PCIe devices fail to come up otherwise. Signed-off-by: Daniel Golle --- drivers/pci/controller/pcie-mediatek-gen3.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c index e0e27645fdf4..ba8cfce03aad 100644 --- a/drivers/pci/controller/pcie-mediatek-gen3.c +++ b/drivers/pci/controller/pcie-mediatek-gen3.c @@ -350,7 +350,13 @@ static int mtk_pcie_startup_port(struct mtk_gen3_pcie *pcie) msleep(100); /* De-assert reset signals */ - val &= ~(PCIE_MAC_RSTB | PCIE_PHY_RSTB | PCIE_BRG_RSTB | PCIE_PE_RSTB); + val &= ~(PCIE_MAC_RSTB | PCIE_PHY_RSTB | PCIE_BRG_RSTB); + writel_relaxed(val, pcie->base + PCIE_RST_CTRL_REG); + + msleep(100); + + /* De-assert PERST# signals */ + val &= ~(PCIE_PE_RSTB); writel_relaxed(val, pcie->base + PCIE_RST_CTRL_REG); /* Check if the link is up or not */