From patchwork Wed Sep 13 11:48:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaldo Carvalho de Melo X-Patchwork-Id: 139153 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:a8d:b0:3f2:4152:657d with SMTP id gr13csp145609vqb; Wed, 13 Sep 2023 16:17:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IElFzZ4teyz2zQZfuDPGtavYq2EMjlkbRulxzyDFOqGcLxJt0YVmibw4hYbBR7b0LYXcs1d X-Received: by 2002:a05:6a00:4a08:b0:690:28d0:b7cf with SMTP id do8-20020a056a004a0800b0069028d0b7cfmr544260pfb.16.1694647039057; Wed, 13 Sep 2023 16:17:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694647039; cv=none; d=google.com; s=arc-20160816; b=Z0Z13VZ8I7qUmEaIHeDBvXJ8En6J0xg+Jpxk8Iz5s+a+Hlh5AjpRHw+2yFKrbYfYg/ g56kAojVNc/RjvpKRNjUdth8dgkM/K8Lnkyx3jzSBJNEU/cl+ghEBQe8Q76nzOrmwX6E DeXEkOwACP5twTBXghk3xqHQ4fDfS7439APYDaOBR8J0E352yDQGpeQHuV5jc8TZ8yp7 WEDIg1b3EigDltY2Z/le3+ks1YBjiq1XKiQ7ch+IU96B+cmXSZ0Rg6N8/rgN1T9mnfq7 TnYA/Oymrl1LKko60BX82IaYJn0gHVbYZhVQPpRHDVsxihpevdho73tSJ9te2awBH5pK I7kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=9gt/M5ILEEedSiFQkrvvkY5+FnBn6vXs3VIBo1vnRu8=; fh=jVX7/wfDkOuLW+d7FYvcL2GgpBLqu7BmPopQTtD+Byc=; b=sSDdJfUQplkXY3Fqqk9tXr3Tiymi+BfolIl4oBms2yBFga8eiLBQ6FVvxNgTLn8CKg DxihNpiq8kX4sSC03DZHUlCsIK8o+ckFpRsx5A8Pon4XD2styd5UJ/lXY8Dmfjay5DoL RbdyCaxEPYk1ehuOLhpLXyLjBdb0wQffcI51iN4SzfCm78XRuwWNB6fNB7VDG8aDR2CP /2TUsDxS1hsh0w886brjXUdQwCFdDec71Lze2HAjnhR3S7nYGFuFGTY7b/I/CkioaW3F KuwBQ3/eDlIJvtexkaV9QEStMKKba3BY5/PVSBxJ2u/xSiqKywRzuKub6VHGM0O+nbu0 Aw4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hHdnDVQt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id fp7-20020a056a00608700b0069023e4bcb4si255558pfb.114.2023.09.13.16.17.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 16:17:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hHdnDVQt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7F03382159FE; Wed, 13 Sep 2023 04:48:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240398AbjIMLsi (ORCPT + 36 others); Wed, 13 Sep 2023 07:48:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235715AbjIMLsg (ORCPT ); Wed, 13 Sep 2023 07:48:36 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E833110E6 for ; Wed, 13 Sep 2023 04:48:32 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 620DEC433C8; Wed, 13 Sep 2023 11:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694605712; bh=Vb33qlf0ZwjYVrEHkwd4Hitu/bcjtnaGY47clFBlEh0=; h=Date:From:To:Cc:Subject:From; b=hHdnDVQtMAz1N4rWXipk/2tlW2VtQpoQblEp6kRsV9+ywz5deHrMFobG3aqYukla3 JM2tZqplzO2v4M7GhqN80/ODQoGcr0VyLE3poPmhWNMRnyO2i0Ew6toEbDL1VBKGpr NS1362FjxluAZBP/IKNCv6aInuLMFE6VIZ7JuBIgjTwIQxxjy6rqSnftY7s5muwNfG JN/juiZwVmz8b1bPsyBFylk3tpZL6c4VUeq4NxnsAD8uLj64FrJKLAyhyJtRDJthHT WI2/QWqgnaDDfPk3+806p7L5jWC+Ntz9vQTOsrl1RkNsBiNfxVFVeQmOrA2dCP88Mw rJVABKRyBH+AA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 95B5A403F4; Wed, 13 Sep 2023 08:48:29 -0300 (-03) Date: Wed, 13 Sep 2023 08:48:29 -0300 From: Arnaldo Carvalho de Melo To: Andrei Vagin , linux-kernel@vger.kernel.org Cc: Kees Kook , Adrian Hunter , Ian Rogers , Jiri Olsa , Namhyung Kim , Peter Zijlstra Subject: [PATCH 2/2 fyi] perf bench sched-seccomp-notify: Use the tools copy of seccomp.h UAPI Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Sep 2023 04:48:38 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776966213812809506 X-GMAIL-MSGID: 1776966213812809506 To keep perf building in systems where types and defines used in this new benchmark are not available, such as: 12 13.46 centos:stream : FAIL gcc version 8.5.0 20210514 (Red Hat 8.5.0-20) (GCC) bench/sched-seccomp-notify.c: In function 'user_notif_syscall': bench/sched-seccomp-notify.c:55:27: error: 'SECCOMP_RET_USER_NOTIF' undeclared (first use in this function); did you mean 'SECCOMP_RET_ERRNO'? BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_USER_NOTIF), ^~~~~~~~~~~~~~~~~~~~~~ /git/perf-6.6.0-rc1/tools/include/uapi/linux/filter.h:49:59: note: in definition of macro 'BPF_STMT' #define BPF_STMT(code, k) { (unsigned short)(code), 0, 0, k } ^ bench/sched-seccomp-notify.c:55:27: note: each undeclared identifier is reported only once for each function it appears in BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_USER_NOTIF), ^~~~~~~~~~~~~~~~~~~~~~ /git/perf-6.6.0-rc1/tools/include/uapi/linux/filter.h:49:59: note: in definition of macro 'BPF_STMT' #define BPF_STMT(code, k) { (unsigned short)(code), 0, 0, k } ^ bench/sched-seccomp-notify.c:55:3: error: missing initializer for field 'k' of 'struct sock_filter' [-Werror=missing-field-initializers] BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_USER_NOTIF), ^~~~~~~~ In file included from bench/sched-seccomp-notify.c:5: /git/perf-6.6.0-rc1/tools/include/uapi/linux/filter.h:28:8: note: 'k' declared here __u32 k; /* Generic multiuse field */ ^ bench/sched-seccomp-notify.c: In function 'user_notification_sync_loop': bench/sched-seccomp-notify.c:70:28: error: storage size of 'resp' isn't known struct seccomp_notif_resp resp; ^~~~ bench/sched-seccomp-notify.c:71:23: error: storage size of 'req' isn't known struct seccomp_notif req; ^~~ bench/sched-seccomp-notify.c:76:23: error: 'SECCOMP_IOCTL_NOTIF_RECV' undeclared (first use in this function); did you mean 'SECCOMP_MODE_STRICT'? if (ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req)) ^~~~~~~~~~~~~~~~~~~~~~~~ SECCOMP_MODE_STRICT bench/sched-seccomp-notify.c:86:23: error: 'SECCOMP_IOCTL_NOTIF_SEND' undeclared (first use in this function); did you mean 'SECCOMP_RET_ACTION'? if (ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp)) ^~~~~~~~~~~~~~~~~~~~~~~~ SECCOMP_RET_ACTION bench/sched-seccomp-notify.c:71:23: error: unused variable 'req' [-Werror=unused-variable] struct seccomp_notif req; ^~~ bench/sched-seccomp-notify.c:70:28: error: unused variable 'resp' [-Werror=unused-variable] struct seccomp_notif_resp resp; ^~~~ 14 11.31 debian:10 : FAIL gcc version 8.3.0 (Debian 8.3.0-6) Cc: Adrian Hunter Cc: Andrei Vagin Cc: Ian Rogers Cc: Jiri Olsa Cc: Kees Kook Cc: Namhyung Kim Cc: Peter Zijlstra Link: https://lore.kernel.org/lkml/ Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/bench/sched-seccomp-notify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/bench/sched-seccomp-notify.c b/tools/perf/bench/sched-seccomp-notify.c index b04ebcde40361636..a01c40131493b76d 100644 --- a/tools/perf/bench/sched-seccomp-notify.c +++ b/tools/perf/bench/sched-seccomp-notify.c @@ -9,7 +9,7 @@ #include #include #include -#include +#include #include #include