From patchwork Sat Jul 29 05:02:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paulo Miguel Almeida X-Patchwork-Id: 128025 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp897107vqg; Sat, 29 Jul 2023 00:30:37 -0700 (PDT) X-Google-Smtp-Source: APBJJlE6q/sBoSla/P8P59pOyuhnDpT35t5mQkCJo7mrDeBsy/BqcHzuD5X8BMPQ3o4J8Yf6wqFG X-Received: by 2002:a17:90b:4f47:b0:267:85ae:2367 with SMTP id pj7-20020a17090b4f4700b0026785ae2367mr4107580pjb.12.1690615836785; Sat, 29 Jul 2023 00:30:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690615836; cv=none; d=google.com; s=arc-20160816; b=XBTlnVki63hpHrVUH2KS/ZycQJHAb8HP9b5530PYrLz/VVGIeFvNGaK0pNf6jEeNDA vDaMr0CQGAWu2sd4LlHg8LPkFylqG/3l+hRD11CpHbqLqUYTZQeJ1K6lIpB2ufn3RsGL 2O5tPdkszZoPB4+U8lF4CwZEktziCJcIK+j1GQE777DNinmkQJsuImSZxF6XgZKR+ZlF jHqdg/RCc0RgD4dPFm706d+XJRWxqbJhWuhq/MBpH418TqWFDBtObFa3MCnYLhWEo7T4 BcfVGV1z/PEqzZ/m6pQCqQSc0ASkdh7YnHdZgkHeev5PzoMJs6Jbz6MHvjKKCJwrd7An KM4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=cjkBbkh/GjL93eEJmsCFWZWoMeD8zNhgHOIAKw8BpdA=; fh=lLki9R2ahJJWctPgwYWkZ3nw8M9aAJNlBfL4co6eFDo=; b=li6L5qz0n4bkvHAYX8BoyF8fXK1rENvD75ro5zk1TxiZm+eXqA+eYo5JLdbluKVtD0 Q7u70f1VK8dNe21ss6IdZTx7yWSp/EqLnKg/7WLWIzMTTUqapOF06ryiUxt1YcDlmdDS 65vPismtxEt+pwJGIh29UGDSqIXsjofvnH0NP6d9cJyT4EcsDLDYp8m3V0UR1Fqn78ch gjeOunAhs1qWeOAnm8vcJAXq6kNQOmTfdQS5soNg7U4KDxbyfSQ2aX6mKJtTKPA/cXip /gdjfhhepsLkg8y8uyaM8Uq19e3lU+W25o0jErLlzBiz3be5+U5oj+/s+MDR8zXjAIBo YMYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=hFsfK1DY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g8-20020a17090a640800b0025e81e3e0c1si3384785pjj.187.2023.07.29.00.30.11; Sat, 29 Jul 2023 00:30:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=hFsfK1DY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235008AbjG2FCU (ORCPT + 99 others); Sat, 29 Jul 2023 01:02:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229617AbjG2FCS (ORCPT ); Sat, 29 Jul 2023 01:02:18 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 259E0198A for ; Fri, 28 Jul 2023 22:02:17 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-55b5a37acb6so378656a12.0 for ; Fri, 28 Jul 2023 22:02:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690606936; x=1691211736; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=cjkBbkh/GjL93eEJmsCFWZWoMeD8zNhgHOIAKw8BpdA=; b=hFsfK1DYrPbFnSChjGA2BapKXb32Ttb0Iw+FGCAFOWSfC9uZbQ26QKqOVZsuJJdOJU YEEQ0Dy5J9V+OLGSGSPiLko6jaT1Yw44OPpwL/U6/Njagvev61rOvweUUo6qcNmqkbGm st8iWGANRMFtap+wcJNaW/SaC85aQuIBBSYwztZAq/qs5H1Nl45mwfP6rdhABmshjNrv yp1qyZI3dvclyWqV5P9gZ+W7qN/z8f+c76k2fo4y1HM+aEuEksRXDplblC+9vXOo2fnH cw96anaHwc5AEWmit4Kia8V68Ip7hERK2o9zRt6Q076IF+5PxjvItL4Ch69pnbMod8jo 7PqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690606936; x=1691211736; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cjkBbkh/GjL93eEJmsCFWZWoMeD8zNhgHOIAKw8BpdA=; b=InApsfXx3TEHdivV+Kd+SupvEG8jW4qNfty8Y4DPJqIPXjOqtWqRZxaI1qM74COhE4 aZlY+cp3FjwhFKUatzvAUX7qJtTknBfRXb1HXMQ55BfjlCuGNqPHypNcGEq6jb0qtb4S 4GBIBAcB11gqGJNo0xUGWGh9yL/ssdEJUWAID8/MoN8yq1YPyJOzgPiz/qfb3umH+m/X YoXTG65s44FauQvYd4/OH/FTOIcTlmhHHvqjma4A+tQV55Izqm7QzqB6fJUtM8t1NtVj Tq3GIdUyW3Tjx8TMDLG4dCewVBJwC2WqI29j7eOYdLJ9U1ReqCdyrYPKaGt3E5wfzLci lWlQ== X-Gm-Message-State: ABy/qLYXYI9drFqCv/dFrw4SEfMQEzkEbbExPaVHjmHEwYFuqkuwnE6z OabpiVCTXmF68Rh2MpUYbNI= X-Received: by 2002:a17:902:da84:b0:1bb:ac37:384b with SMTP id j4-20020a170902da8400b001bbac37384bmr1627144plx.6.1690606936434; Fri, 28 Jul 2023 22:02:16 -0700 (PDT) Received: from mail.google.com (203-109-233-218.dsl.dyn.ihug.co.nz. [203.109.233.218]) by smtp.gmail.com with ESMTPSA id t16-20020a17090aba9000b0026307fa0442sm4819654pjr.49.2023.07.28.22.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 22:02:15 -0700 (PDT) Date: Sat, 29 Jul 2023 17:02:09 +1200 From: Paulo Miguel Almeida To: masahiroy@kernel.org, bgray@linux.ibm.com, ajd@linux.ibm.com, n.schier@avm.de Cc: paulo.miguel.almeida.rodenas@gmail.com, linux-kernel@vger.kernel.org, keescook@chromium.org Subject: [PATCH] [next] initramfs: Parse KBUILD_BUILD_TIMESTAMP as UTC date Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772739191609984773 X-GMAIL-MSGID: 1772739191609984773 When KBUILD_BUILD_TIMESTAMP is specified, the date command will parse it to Unix Epoch time in UTC. However, the date command is timezone-aware so it will convert from the local timezone to UTC first which hits some of the sanity checks added on commit 5efb685bb3af1 ("initramfs: Check negative timestamp to prevent broken cpio archive") This creates an edge case for the UTC+ part of the world. For instance - In New Zealand (UTC+12:00): $ date -d"1970-01-01" +%s -43200 $ make KBUILD_BUILD_TIMESTAMP=1970-01-01 make[1]: Entering directory '/linux/' GEN Makefile DESCEND objtool INSTALL libsubcmd_headers CALL ../scripts/checksyscalls.sh GEN usr/initramfs_data.cpio ERROR: Timestamp out of range for cpio format make[4]: *** [../usr/Makefile:76: usr/initramfs_data.cpio] Error 1 - In Seattle, WA (UTC-07:00): $ date -d"1970-01-01" +%s 32400 $ make KBUILD_BUILD_TIMESTAMP=1970-01-01 Parse KBUILD_BUILD_TIMESTAMP date string as UTC so no localtime conversion is done which fixes the edge case aforementioned. Signed-off-by: Paulo Miguel Almeida --- usr/gen_initramfs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr/gen_initramfs.sh b/usr/gen_initramfs.sh index 14b5782f961a..a90316d9a080 100755 --- a/usr/gen_initramfs.sh +++ b/usr/gen_initramfs.sh @@ -221,7 +221,7 @@ while [ $# -gt 0 ]; do shift ;; "-d") # date for file mtimes - timestamp="$(date -d"$1" +%s || :)" + timestamp="$(date -d"$1" -u +%s || :)" if test -n "$timestamp"; then timestamp="-t $timestamp" fi