diff mbox series

arm64: dts: rockchip: Fix Wifi/Bluetooth on ROCK Pi 4 boards

Message ID ZLO450xOIQ29VoBT@zephyrusG14
State New
Headers
Series arm64: dts: rockchip: Fix Wifi/Bluetooth on ROCK Pi 4 boards |

Commit Message

Yogesh Hegde July 16, 2023, 9:31 a.m. UTC 
  This patch fixes an issue affecting the Wifi/Bluetooth connectivity on
ROCK Pi 4 boards. Commit f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth
on ROCK Pi 4 boards") introduced a problem with the clock configuration.
Specifically, the clock-names property of the sdio-pwrseq node was not
updated to 'lpo', causing the driver to wait indefinitely for the wrong clock
signal 'ext_clock' instead of the expected one 'lpo'. This prevented the proper
initialization of Wifi/Bluetooth chip on ROCK Pi 4 boards.

To address this, this patch updates the clock-names property of the
sdio-pwrseq node to "lpo" to align with the changes made to the bluetooth node.

This patch has been tested on ROCK Pi 4B.

Signed-off-by: Yogesh Hegde <yogi.kernel@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vincent Legoll July 16, 2023, 3:53 p.m. UTC | #1 
Hello,

On Sun, Jul 16, 2023 at 9:32 AM Yogesh Hegde <yogi.kernel@gmail.com> wrote:
> Commit f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth
> on ROCK Pi 4 boards") introduced a problem with the clock configuration.

Maybe you should add a "Fixes:" tag.
Look at:
Documentation/process/submitting-patches.rst
for details.

Cheers
Yogesh Hegde July 17, 2023, 12:13 p.m. UTC | #2 
Hi Vincent,
On Sun, Jul 16, 2023 at 03:53:22PM +0000, Vincent Legoll wrote:
> Hello,
> 
> On Sun, Jul 16, 2023 at 9:32 AM Yogesh Hegde <yogi.kernel@gmail.com> wrote:
> > Commit f471b1b2db08 ("arm64: dts: rockchip: Fix Bluetooth
> > on ROCK Pi 4 boards") introduced a problem with the clock configuration.
> 
> Maybe you should add a "Fixes:" tag.
> Look at:
> Documentation/process/submitting-patches.rst
> for details.
Thanks for taking the time to review and provide feedback on the patch. 
I will send a v2 with the "Fixes:" tag. 

Thanks & Regards 
-- Yogesh
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
index 907071d4fe80..795a70948d9a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
@@ -45,7 +45,7 @@  led-0 {
 	sdio_pwrseq: sdio-pwrseq {
 		compatible = "mmc-pwrseq-simple";
 		clocks = <&rk808 1>;
-		clock-names = "ext_clock";
+		clock-names = "lpo";
 		pinctrl-names = "default";
 		pinctrl-0 = <&wifi_enable_h>;
 		reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;