From patchwork Tue Jul 25 06:37:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tree Davies X-Patchwork-Id: 125368 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2296261vqg; Tue, 25 Jul 2023 00:29:38 -0700 (PDT) X-Google-Smtp-Source: APBJJlFfPcDF3nZ3qzC/0NXFifZBEEx1bpbreKOcW5ipqlCEV7HIfz2u991EaQCPN6SbDq9C7+10 X-Received: by 2002:a17:907:318c:b0:997:b8dc:30a2 with SMTP id xe12-20020a170907318c00b00997b8dc30a2mr1523371ejb.33.1690270178561; Tue, 25 Jul 2023 00:29:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690270178; cv=none; d=google.com; s=arc-20160816; b=KwHWrb8OqpsfI1tjTLPoN47RoEzRFrFZnFE6DkDjT2nzzFi/0FvREomb4Kcjc9gCQ+ bevcm/noec/Yfhn2JzGp3It1BI71+7FSfD4Lv4/G35x73e/APZD2mSMkc317T6KHPZ4b KviGImyed5RUHA311b7H8WXO8zAfAYx/NaueE7JfQIYwDnybsOE0NgSWSmVc/jVqn34S xR9Vv3s8xA9XNJZb5LyxPvIYoJol2NHcvsVsq4gSZVukj7pcOAwMh/Rg5u3PsIc5OmSH pFLVzCZPiLAwXDXfqTb/4nHGgpZHK1QVfVjwNE8qC/CkpYviDMigCegBNVrKG0u6Kg3E Ph9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature:dkim-signature; bh=DeFVTScMVF95035bO5xSxX4ol6GsJS3Hr4wsAz4vO2s=; fh=3jvUQscqe8rwMJMYm8BR5N83dgzqgjDCTpIcxqpBKxM=; b=fx4/Hx5EtanQ/TYI4JX8njsHDDj0Qn+QnAtRvhEJZGY9EUKXZg/vDCZKj5PYKY6Uzi Avhbjc6P+DyMeB0WFEN26zwtqc6gZWGsOsCzBqdQwgIOmR6tEz+EcLRrcKJ5L9XWJG8Z m4a9RK9/TTHrKRTIqr2GCn4PdZp7c+k9cl0lTcztok98mEjv5uyEJFnOTkNl4AR5mP+U vrNmXXAJoyzSyf2CRf5aPw/Ov7AN6bounlha7+fBi3laMSiar9dzGfLK563LqJDUEDT/ ELSPfq3raJ/Q3czWfvcm6KjbltTXERN3uLA+Vattboh61VQZqWqdFz2d7EW9U31KxKNn KNUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b=jPUn4uL4; dkim=temperror (no key for signature) header.i=@darkphysics.net header.s=2019-09.pbsmtp header.b=Lgot7Fmg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pk11-20020a170906d7ab00b00992b9bf21casi7114995ejb.445.2023.07.25.00.29.13; Tue, 25 Jul 2023 00:29:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b=jPUn4uL4; dkim=temperror (no key for signature) header.i=@darkphysics.net header.s=2019-09.pbsmtp header.b=Lgot7Fmg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232199AbjGYGg1 (ORCPT + 99 others); Tue, 25 Jul 2023 02:36:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231754AbjGYGgZ (ORCPT ); Tue, 25 Jul 2023 02:36:25 -0400 Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4551E42 for ; Mon, 24 Jul 2023 23:36:21 -0700 (PDT) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 4BBBD194B7; Tue, 25 Jul 2023 02:36:21 -0400 (EDT) (envelope-from tdavies@darkphysics.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=date:from :to:cc:subject:message-id:mime-version:content-type; s=sasl; bh= D2uTiRvsYq9z5a7T8+noJIXCfFk6b6rip0io+qs3BW8=; b=jPUn4uL4ytRB4SEC QBssYo8EgHgcVWpQNuH2LeOAV8T1xk3KF7koXZJhzqYkEv7+O4TrA1kS4pJ+q46Z a5X+Ayzr12hl6YPs1dXGrmNcHVZo6s42AJBQMaqHyDrL6UpRo1MkHufHbrJ2uzC2 whxXFtWnGkzG/LJvXIBON+NFSkI= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 34A69194B6; Tue, 25 Jul 2023 02:36:21 -0400 (EDT) (envelope-from tdavies@darkphysics.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=darkphysics.net; h=date:from:to:cc:subject:message-id:mime-version:content-type; s=2019-09.pbsmtp; bh=D2uTiRvsYq9z5a7T8+noJIXCfFk6b6rip0io+qs3BW8=; b=Lgot7Fmg2iGEWoOBrFLwDDQY+cjNcWZTCbigk76quhP9lqjF0u5MHRAWoutxksIEwzmIrML+GqAU+9TfBW1eU1xIuJ2fDh21Km+kjdWTnNWirbqqhfVRJymGhh5JVY5sj+J4blHbWSb+vWdBAnnQDZ8gPg2GOYONGXrAUNpD5KA= Received: from basil (unknown [76.146.178.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 132DA194B5; Tue, 25 Jul 2023 02:36:16 -0400 (EDT) (envelope-from tdavies@darkphysics.net) Date: Mon, 24 Jul 2023 23:37:39 -0700 From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca, error27@gmail.com Cc: tdavies@darkphysics.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] Staging: rtl8192e: Rename function DeActivateBAEntry Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Pobox-Relay-ID: 8E6BF63A-2AB5-11EE-9B43-B31D44D1D7AA-45285927!pb-smtp21.pobox.com X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NO_DNS_FOR_FROM,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772376742995098279 X-GMAIL-MSGID: 1772376742995098279 Rename function DeActivateBAEntry to deactivate_ba_entry in order to Fix checkpatch warning: Avoid CamelCase Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c index 965ffa8b78c2..50362bbbc8dd 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -17,7 +17,7 @@ static void activate_ba_entry(struct ba_record *pBA, u16 Time) mod_timer(&pBA->timer, jiffies + msecs_to_jiffies(Time)); } -static void DeActivateBAEntry(struct rtllib_device *ieee, struct ba_record *pBA) +static void deactivate_ba_entry(struct rtllib_device *ieee, struct ba_record *pBA) { pBA->b_valid = false; del_timer_sync(&pBA->timer); @@ -30,12 +30,12 @@ static u8 TxTsDeleteBA(struct rtllib_device *ieee, struct tx_ts_record *pTxTs) u8 bSendDELBA = false; if (pPendingBa->b_valid) { - DeActivateBAEntry(ieee, pPendingBa); + deactivate_ba_entry(ieee, pPendingBa); bSendDELBA = true; } if (pAdmittedBa->b_valid) { - DeActivateBAEntry(ieee, pAdmittedBa); + deactivate_ba_entry(ieee, pAdmittedBa); bSendDELBA = true; } return bSendDELBA; @@ -47,7 +47,7 @@ static u8 RxTsDeleteBA(struct rtllib_device *ieee, struct rx_ts_record *pRxTs) u8 bSendDELBA = false; if (pBa->b_valid) { - DeActivateBAEntry(ieee, pBa); + deactivate_ba_entry(ieee, pBa); bSendDELBA = true; } @@ -270,7 +270,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb) rtllib_FlushRxTsPendingPkts(ieee, pTS); - DeActivateBAEntry(ieee, pBA); + deactivate_ba_entry(ieee, pBA); pBA->dialog_token = *pDialogToken; pBA->ba_param_set = *pBaParamSet; pBA->ba_timeout_value = *pBaTimeoutVal; @@ -363,13 +363,13 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb) netdev_dbg(ieee->dev, "%s(): Recv ADDBA Rsp. BA is admitted! Status code:%X\n", __func__, *pStatusCode); - DeActivateBAEntry(ieee, pPendingBA); + deactivate_ba_entry(ieee, pPendingBA); } if (*pStatusCode == ADDBA_STATUS_SUCCESS) { if (pBaParamSet->field.ba_policy == BA_POLICY_DELAYED) { pTS->bAddBaReqDelayed = true; - DeActivateBAEntry(ieee, pAdmittedBA); + deactivate_ba_entry(ieee, pAdmittedBA); ReasonCode = DELBA_REASON_END_BA; goto OnADDBARsp_Reject; } @@ -378,7 +378,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb) pAdmittedBA->ba_timeout_value = *pBaTimeoutVal; pAdmittedBA->ba_start_seq_ctrl = pPendingBA->ba_start_seq_ctrl; pAdmittedBA->ba_param_set = *pBaParamSet; - DeActivateBAEntry(ieee, pAdmittedBA); + deactivate_ba_entry(ieee, pAdmittedBA); activate_ba_entry(pAdmittedBA, *pBaTimeoutVal); } else { pTS->bAddBaReqDelayed = true; @@ -469,7 +469,7 @@ void TsInitAddBA(struct rtllib_device *ieee, struct tx_ts_record *pTS, if (pBA->b_valid && !bOverwritePending) return; - DeActivateBAEntry(ieee, pBA); + deactivate_ba_entry(ieee, pBA); pBA->dialog_token++; pBA->ba_param_set.field.amsdu_support = 0;