diff mbox series

staging: rtl8192e: Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_a_ps

Message ID ZJdz9oWjPuE3xZ8Y@tacos.darkphysics
State New
Headers
Series staging: rtl8192e: Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_a_ps |

Commit Message

Tree Davies June 24, 2023, 10:53 p.m. UTC 
  Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_a_ps in order to
fix checkpatch warning: Avoid CamelCase

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
 drivers/staging/rtl8192e/rtllib.h         | 2 +-
 drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Philipp Hortmann June 25, 2023, 2:28 p.m. UTC | #1 
On 6/25/23 00:53, Tree Davies wrote:
> Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_a_ps in order to
> fix checkpatch warning: Avoid CamelCase
> 

Hi Tree

If you look where the function is used you will see that it is used in 
rtllib_rx_auth_resp which is used in:
rtllib_rx_auth which is used in:
rtllib_rx_frame_softmac which is used in:
rtllib_rx_frame_mgmt which is used in:
rtllib_rx_InfraAdhoc


This has for me to do with access points so please do not cut the ap apart.

Thanks

Bye Philipp
Tree Davies June 27, 2023, 3:27 a.m. UTC | #2 
On 6/25/23 07:28, Philipp Hortmann wrote:
> On 6/25/23 00:53, Tree Davies wrote:
>> Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_a_ps in order to
>> fix checkpatch warning: Avoid CamelCase
>>
>
> Hi Tree
>
> If you look where the function is used you will see that it is used in 
> rtllib_rx_auth_resp which is used in:
> rtllib_rx_auth which is used in:
> rtllib_rx_frame_softmac which is used in:
> rtllib_rx_frame_mgmt which is used in:
> rtllib_rx_InfraAdhoc
>
>
> This has for me to do with access points so please do not cut the ap 
> apart.
>
> Thanks
>
> Bye Philipp
>
>
>
Thanks Philip,
I will send a v2
Cheers!
Tree
diff mbox series

Patch

diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index f9fa3f2bb728..6f9d79582519 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -139,7 +139,7 @@  u16  TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate)
 	return MCS_DATA_RATE[is40MHz][isShortGI][nDataRate & 0xf];
 }
 
-bool IsHTHalfNmodeAPs(struct rtllib_device *ieee)
+bool is_ht_half_nmode_a_ps(struct rtllib_device *ieee)
 {
 	bool			retValue = false;
 	struct rtllib_network *net = &ieee->current_network;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index e3ce4431d460..0b33f993077d 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -2003,7 +2003,7 @@  extern u8 MCS_FILTER_ALL[];
 extern u16 MCS_DATA_RATE[2][2][77];
 u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame);
 void HTResetIOTSetting(struct rt_hi_throughput *ht_info);
-bool IsHTHalfNmodeAPs(struct rtllib_device *ieee);
+bool is_ht_half_nmode_a_ps(struct rtllib_device *ieee);
 u16  TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate);
 int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb);
 int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb);
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 425d4acbcdf0..589015caa7b0 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -2224,7 +2224,7 @@  static void rtllib_rx_auth_resp(struct rtllib_device *ieee, struct sk_buff *skb)
 		ieee->softmac_stats.rx_auth_rs_ok++;
 		if (!(ieee->ht_info->iot_action & HT_IOT_ACT_PURE_N_MODE)) {
 			if (!ieee->GetNmodeSupportBySecCfg(ieee->dev)) {
-				if (IsHTHalfNmodeAPs(ieee)) {
+				if (is_ht_half_nmode_a_ps(ieee)) {
 					bSupportNmode = true;
 					bHalfSupportNmode = true;
 				} else {