From patchwork Sun Jun 4 02:46:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tree Davies X-Patchwork-Id: 102928 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1944056vqr; Sat, 3 Jun 2023 19:57:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4afPVBT/Zer4hmQGPjs7zCSJYBEiY9fQaJNWh/jo2tNLzRDc2XV0kkjbzEJt4dc8Ej3GGe X-Received: by 2002:a05:6a00:2450:b0:63f:2f00:c6d with SMTP id d16-20020a056a00245000b0063f2f000c6dmr18203657pfj.2.1685847456627; Sat, 03 Jun 2023 19:57:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685847456; cv=none; d=google.com; s=arc-20160816; b=aipQOfHsNQqsfgnRhc3IfW/38ohtACTClYvTmwkALhm0KhmlZ64/kR9LjeSuCxuYff DLcOVfrhTfXjFwoSil/k3MHbVhC/udvG6fqtpCKdHuUNme4veGIAhyMsxLLAcAjXhTBt R8JjW5bQp9wkBmqH4zlJ4Co4Fdy/oNo5y+BKRoyGPUryi8UpaKGGBFheb25/ee0GyVpL 1CQ6pqxzbRFWX7jaSdtNTuI9YvO2ztoPaHNUQGbaRtWU8djlH7Qf/1ldICxE12SZNFSS gs1nsaR2qJVzEs+eGKgNA8KBiWuAg/kF3HoMbffG2B/ITD0Avj51dz6po1Xn2WYCgDX1 R74g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature:dkim-signature; bh=nukZLmSctqG8aZUNypiBy+rLD26uW4WmoEZXgg0tWUw=; b=BD32te+VfqRdEtO0k4AWIyj8JxmFfPnohJ72KKSiL/G3i/OTYH3Zgb/fNmV5IuSeBs EMW/FEUBYiHDEZzEQErccPgl4USFx4+A8WlFISjfGJoPTX4XRcaxYWLqVCrabMnO8dEc Jrnl7nrwZay+6v0aPERF36TSgk0vHICKziI2MOqwTWADGV/p8ix+UxyQs1YXySz7/Dfh YXhZEzKYQdqUuiIl6AEa0AEWDt2pYHe+58RO9wZMJ3R0/lU6z9IApud4sSpvN/RSN+a5 rJ6nWbljvwzW9k/Sm/AcBMPi7+GSEQ0HTnU37OZbS0oZ3yOXvpdY4QKC15i7gULh3nYi BOWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b="yhGJ8/xE"; dkim=temperror (no key for signature) header.i=@darkphysics.net header.s=2019-09.pbsmtp header.b="ZZypp/IS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bs5-20020a632805000000b0053eee173733si3531373pgb.227.2023.06.03.19.57.23; Sat, 03 Jun 2023 19:57:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b="yhGJ8/xE"; dkim=temperror (no key for signature) header.i=@darkphysics.net header.s=2019-09.pbsmtp header.b="ZZypp/IS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229911AbjFDCtX (ORCPT + 99 others); Sat, 3 Jun 2023 22:49:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229571AbjFDCtW (ORCPT ); Sat, 3 Jun 2023 22:49:22 -0400 X-Greylist: delayed 147 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sat, 03 Jun 2023 19:49:17 PDT Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7EF3F2; Sat, 3 Jun 2023 19:49:17 -0700 (PDT) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 56FF718FCCE; Sat, 3 Jun 2023 22:46:48 -0400 (EDT) (envelope-from tdavies@darkphysics.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=date:from :to:cc:subject:message-id:mime-version:content-type; s=sasl; bh= dqDBRzC7tcn7+DMkBVjjohLM8iy8N4hgg2tVjJuNb/4=; b=yhGJ8/xEZG7kopHr kdZBOQwNVvbFb4XSF9hvBLKevM/nZFg0X4K6TNE9d5DBQSlhqMOs049rhjr3TuoJ VRGFfzgNAh9wbckxGccfzEMV+MbJGQjIot+Hl9utM/SIkmtI+ftQwwl8qEDyseOG wq+yCSbZhCs6X4X4G8XFV/3ji8M= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 4D04D18FCCD; Sat, 3 Jun 2023 22:46:48 -0400 (EDT) (envelope-from tdavies@darkphysics.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=darkphysics.net; h=date:from:to:cc:subject:message-id:mime-version:content-type; s=2019-09.pbsmtp; bh=dqDBRzC7tcn7+DMkBVjjohLM8iy8N4hgg2tVjJuNb/4=; b=ZZypp/ISH1Lee9Io0GliZs/9oNn9OO4oO1KaewKaKbWb1t5snNrbEc0neN/Z3xCYsFFCXefpYcG7X+qkNyYhyZxPbAKdz9IYuIKcQhg+EtuCBalXExvj38XOJTyeH8NcT3FvcLT+t63wnUbPm0zIc2Atjya9YxEc5/Z92FnBZY8= Received: from oatmeal.darkphysics (unknown [76.146.178.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 020BD18FCCC; Sat, 3 Jun 2023 22:46:46 -0400 (EDT) (envelope-from tdavies@darkphysics.net) Date: Sat, 3 Jun 2023 19:46:40 -0700 From: Tree Davies To: anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: tdavies@darkphysics.net, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [Patch] net/e1000: Fix extern warnings Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Pobox-Relay-ID: 0CB3580A-0282-11EE-BF0C-307A8E0A682E-45285927!pb-smtp2.pobox.com X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NO_DNS_FOR_FROM,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767739182471181168?= X-GMAIL-MSGID: =?utf-8?q?1767739182471181168?= Reviewed-by: Przemek Kitszel From 407d0e4641d67118c954d36cc829c35300669fc8 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sat, 3 Jun 2023 19:02:06 -0700 Subject: [PATCH] net/e1000: Fix extern warnings This patch fixes 11 checkpatch.pl warnings of type: WARNING: externs should be avoided in .c files Signed-off-by: Tree Davies --- drivers/net/ethernet/intel/e1000/e1000_main.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c index da6e303ad99b..44f1bfba8a1a 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_main.c +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c @@ -63,14 +63,6 @@ static const struct pci_device_id e1000_pci_tbl[] = { MODULE_DEVICE_TABLE(pci, e1000_pci_tbl); -int e1000_up(struct e1000_adapter *adapter); -void e1000_down(struct e1000_adapter *adapter); -void e1000_reinit_locked(struct e1000_adapter *adapter); -void e1000_reset(struct e1000_adapter *adapter); -int e1000_setup_all_tx_resources(struct e1000_adapter *adapter); -int e1000_setup_all_rx_resources(struct e1000_adapter *adapter); -void e1000_free_all_tx_resources(struct e1000_adapter *adapter); -void e1000_free_all_rx_resources(struct e1000_adapter *adapter); static int e1000_setup_tx_resources(struct e1000_adapter *adapter, struct e1000_tx_ring *txdr); static int e1000_setup_rx_resources(struct e1000_adapter *adapter, @@ -79,7 +71,6 @@ static void e1000_free_tx_resources(struct e1000_adapter *adapter, struct e1000_tx_ring *tx_ring); static void e1000_free_rx_resources(struct e1000_adapter *adapter, struct e1000_rx_ring *rx_ring); -void e1000_update_stats(struct e1000_adapter *adapter); static int e1000_init_module(void); static void e1000_exit_module(void); @@ -87,8 +78,6 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent); static void e1000_remove(struct pci_dev *pdev); static int e1000_alloc_queues(struct e1000_adapter *adapter); static int e1000_sw_init(struct e1000_adapter *adapter); -int e1000_open(struct net_device *netdev); -int e1000_close(struct net_device *netdev); static void e1000_configure_tx(struct e1000_adapter *adapter); static void e1000_configure_rx(struct e1000_adapter *adapter); static void e1000_setup_rctl(struct e1000_adapter *adapter); -- 2.30.2