From patchwork Tue May 30 21:30:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 101124 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2474607vqr; Tue, 30 May 2023 14:35:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4jsvDn2g8f5umraQ/cD7G2L2hHRmQT1O5taCzXGan9W+dh1gtsY43rraMPL/y16wtwD9Zw X-Received: by 2002:a05:6a00:1491:b0:62a:4503:53ba with SMTP id v17-20020a056a00149100b0062a450353bamr4416429pfu.26.1685482507851; Tue, 30 May 2023 14:35:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685482507; cv=none; d=google.com; s=arc-20160816; b=jJJXvRe2Tj0lNN0D0/rUeAJ4XaTj/SPN3mVI1v8cLKaT8M+6yKqbJ4qGNR4elWon7B t8GlE7eCUK5Xq9nkCO0by5NbWBMZ/HLUkt1Jk3Vk0YKcDolGtHcDTMYTAnmNY0i5VKgA sULxkTMnDZKhN5XUzAU7xS4edTG1vbzqcc8teBKP6x6/87X0VUQqJ4UxyXeW1Ug2MA16 YIj23JtKPmIzKPhsXi5MU43g7I+WcJgpi+VxD2yGpJwA3rigWK/ip3BlR6Ew/sYaED6b FQik/xG/XFC+IKdGsrAqv9cJr3O9L4CP/LMkurqE/CN5/bVSr5wnUzKGQyCUj6NlR9na wGZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=V3cPMM2R8xF/p75CTOC2Gsl9j4dNyZgFElxG7Z4Um3o=; b=xL6OBunKCgt1RSb1+vUnzibrMLxao7LFm//+N75Ok+ACPHjf5EUix5MpCtNvwDpivB 8USM/jPlIj0dR2JFyUJtYlQtPMqFJ/I9IcGo7l9ZaSSRHihBhPLcfLsVxCTI6pUe2p+Y P13PVl27Pl355S7ivQD+InEALlKb8t84YwWK2U5vCGG21oDoq81yXnJNSXx0ZtDKLzjN V4LJo6X01R4qx257PD5Te7Tt4D/7K/DKJzAOrxnK0BQsKVlz6WTY58Rmz2+caPYxgczo suVpcBM3fH6F7tSlBNhfWTCIDPCL7Bqf3zLWy5EKSwPAOXS/4lK9wDLBzhXKwx8klVEI LPWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZNQPtKFd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f190-20020a6251c7000000b0064553929dbdsi117479pfb.394.2023.05.30.14.34.55; Tue, 30 May 2023 14:35:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZNQPtKFd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233471AbjE3V3c (ORCPT + 99 others); Tue, 30 May 2023 17:29:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbjE3V3b (ORCPT ); Tue, 30 May 2023 17:29:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E968C7; Tue, 30 May 2023 14:29:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CFCB662F3A; Tue, 30 May 2023 21:29:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58FF0C433EF; Tue, 30 May 2023 21:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685482169; bh=GLu5O3LRK+uO/mUwyhrjlKostu2tteVX5Bk4Ufg7ekc=; h=Date:From:To:Cc:Subject:From; b=ZNQPtKFdt5D+x3VhvyKmUos4cGo3u6phr45fOBLBoMRuPKE7fdH8G8pMi346ZzBBY mhK8Dz5AzQ4T0CJ36AlrlvO1syDAE8qb2tZ/gou9OJeW5yru/5SI0KLTHGjYKPwn42 XtxYYduapa1Z8trkQLBBuE5HC/+kxbdm9twKTe0/iX+JdFpo4fEioJmTtNpszyvoTd fTMn8yT3wl/G26qYclsyYVotsP6DeAR4tgW5kChJEPEeco45QA33ZzcIEPTQTLD5dq osA99hB+fW5P+RWmtgA+rdLREk5oxm8PQ/Cyssv9eJMYH/NXdXxjtSrpKwRdGwRYbb lYCvJBoSDjzFQ== Date: Tue, 30 May 2023 15:30:20 -0600 From: "Gustavo A. R. Silva" To: James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH][next] scsi: lpfc: Avoid -Wstringop-overflow warning Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767356506113554637?= X-GMAIL-MSGID: =?utf-8?q?1767356506113554637?= Avoid confusing the compiler about possible negative sizes. Use size_t instead of int for variables size and copied. Address the following warning found with GCC-13: In function ‘lpfc_debugfs_ras_log_data’, inlined from ‘lpfc_debugfs_ras_log_open’ at drivers/scsi/lpfc/lpfc_debugfs.c:2271:15: drivers/scsi/lpfc/lpfc_debugfs.c:2210:25: warning: ‘memcpy’ specified bound between 18446744071562067968 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=] 2210 | memcpy(buffer + copied, dmabuf->virt, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2211 | size - copied - 1); | ~~~~~~~~~~~~~~~~~~ Link: https://github.com/KSPP/linux/issues/305 Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/lpfc/lpfc_debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c index bdf34af4ef36..493729e74abe 100644 --- a/drivers/scsi/lpfc/lpfc_debugfs.c +++ b/drivers/scsi/lpfc/lpfc_debugfs.c @@ -2189,9 +2189,9 @@ lpfc_debugfs_lockstat_write(struct file *file, const char __user *buf, #endif static int lpfc_debugfs_ras_log_data(struct lpfc_hba *phba, - char *buffer, int size) + char *buffer, size_t size) { - int copied = 0; + size_t copied = 0; struct lpfc_dmabuf *dmabuf, *next; memset(buffer, 0, size); @@ -2249,7 +2249,7 @@ lpfc_debugfs_ras_log_open(struct inode *inode, struct file *file) { struct lpfc_hba *phba = inode->i_private; struct lpfc_debug *debug; - int size; + size_t size; int rc = -ENOMEM; spin_lock_irq(&phba->hbalock);