| Message ID | ZAu6qDsNPmk82UjV@minwoo-desktop |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp24461wrd;
Fri, 10 Mar 2023 15:32:26 -0800 (PST)
X-Google-Smtp-Source:
AK7set8M0+Hz4Lrn4HvXQM8AwI8m+33z8PnLZKpkTQg6IGJm6sz/zvcLS4s0LPQWESg7ALVBAYHg
X-Received: by 2002:a17:902:d4ce:b0:19a:9864:2887 with SMTP id
o14-20020a170902d4ce00b0019a98642887mr4108303plg.7.1678491146246;
Fri, 10 Mar 2023 15:32:26 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1678491146; cv=none;
d=google.com; s=arc-20160816;
b=zn7jlIESfQZuanPDCA45SbmdUFj9Jj2mhxTcjwWTf8lkXatj/Xye+M/K8zoL/w8LAa
ZlG6l0CVlh0hMgXU1U5RD5rF8TThxRvgT/YewP+9pBMu0x2sy6EztR25Dij6W4g4ga2S
4zq0wAAleea6gtB3FRB5uR6YVHBlVsCEB424/YDfXZFzHzuUbYkKBZnKNajZmJBHMfyx
uQL7wjpWGJFsCUvqC8nlZp8GeEE3gLsqMRn9vEI18Pnj1ABzbCbGUP0MNedyTSfBbwlS
U0MFLyypijmuBCPWyNV+iCNoNNz+/AnvxnmkbsTlfCaFHeUrgYT8xpfgxL1bEE46kHYE
WPow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-disposition:mime-version:message-id
:subject:cc:to:from:date:dkim-signature;
bh=Xz51x4A7Eu2J8EAn+UJRgtV0WTJYDaCqLo8gQb4mjo8=;
b=If5XWep1XmNH7CdFufDG624/niA47MSPN5X92SW56BKBmnMRUYH6i80zqqELdT8g3l
053OAVfH0ftdAndYpueLB7FuBaN4ez7xCu2wiGTCEoTkotjBbbD87cQAeEwbi5sY7aPB
e/jncfaVg+JUXC+lypvmAktBvHGzRpx5J+iH/5nXFwOJ+ZeHFJXueivB2BALoRdUFQE/
jRJFYgnDaorq/WmJT+0YFJTfReYWPXQec7+h8fU2oaHTEGS4jafJ4GvzEPM5yhTcmH1M
EiVsArmCbL3HIThtKOqeHdHQm0qhc/ZSoupOaff4i06fn7ZNFznWZPie1OOmrGt3WJZr
fUDw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@gmail.com header.s=20210112 header.b=IkTv3XFE;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
b9-20020a170902bd4900b001930212bebfsi965020plx.530.2023.03.10.15.32.11;
Fri, 10 Mar 2023 15:32:26 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@gmail.com header.s=20210112 header.b=IkTv3XFE;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231626AbjCJXSj (ORCPT <rfc822;carlos.wei.hk@gmail.com>
+ 99 others); Fri, 10 Mar 2023 18:18:39 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43196 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231584AbjCJXSK (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 10 Mar 2023 18:18:10 -0500
Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com
[IPv6:2607:f8b0:4864:20::630])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B6C815C93;
Fri, 10 Mar 2023 15:18:07 -0800 (PST)
Received: by mail-pl1-x630.google.com with SMTP id p20so7206954plw.13;
Fri, 10 Mar 2023 15:18:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20210112; t=1678490286;
h=content-disposition:mime-version:message-id:subject:cc:to:from:date
:from:to:cc:subject:date:message-id:reply-to;
bh=Xz51x4A7Eu2J8EAn+UJRgtV0WTJYDaCqLo8gQb4mjo8=;
b=IkTv3XFEIPNwy4r9MsPML+H2ITnf/hCMh/ExSQ5fRUWO2YF0FXQbGYUBvPFIsaAp/V
ExZwHOD9QBnhtikHQFevhWxsi2uzrNwqaec2d2sIU3WW07Wr3buOynStkbZ1yrMaO7C9
XdW5YJT6L/BJM0LwxaLn7iQt16DGI/8UxcchwXSAtqUZkgU6CkBLIQzS6DLTfJBElshv
zVSG1L3VeBMEZe/o3MtLXJX0W+kxJf6N5GkUAWNtyrN/gxdK6X280V66GzTi0j0V/fzk
8t3kHXQ4eU7zlU/aIB7MnkkJlalPRBy8aTFY2kKQGoOyDfJTkkqwy9w2AT12aH26ZJee
b9mw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112; t=1678490286;
h=content-disposition:mime-version:message-id:subject:cc:to:from:date
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=Xz51x4A7Eu2J8EAn+UJRgtV0WTJYDaCqLo8gQb4mjo8=;
b=AWxVblmUlmuLb7NNFE6yMd4onF9ZtgS2rCMdg1bqVPZDUmLiBGJZVQuRNRTXP5FNT9
8NOqhg5u5ow73l6oPsRpnk0rQYB8uTZ6wgpzNdPErbQC4HGjwKrkqdXvupU/TLisOqjz
mm4sMVTXGJkGv8GC/+3Jgm8SIOHdOXUhf+Yi+qrzuwtffYCHP0rK5adYk3XF3ICqd6gG
rej7p5MOzik0AfbZ4W+srNjFacsQ/Ige5CA09bZYtLg2myDa2ahlyYfVxWfMAHJ6ZSbz
lWKeD7ilvCVnTI3aQQa62q+VLwvaMtXJyKOu8apDp+GrxOUEwFnQXjkCPQfD+rc3WYEB
knGg==
X-Gm-Message-State: AO0yUKWbvW/SsJ7IjJr3WdK1WB83ya1amw8GQY4YudEIsJS9wB0fzE/H
PjwHsQMWGRL4bRmh+C8Yr8wWoJSZDYc=
X-Received: by 2002:a05:6a20:3ca5:b0:cc:50de:a2be with SMTP id
b37-20020a056a203ca500b000cc50dea2bemr4018231pzj.14.1678490286291;
Fri, 10 Mar 2023 15:18:06 -0800 (PST)
Received: from minwoo-desktop ([1.237.94.73])
by smtp.gmail.com with ESMTPSA id
g19-20020a62e313000000b005813f365afcsm291741pfh.189.2023.03.10.15.18.03
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 10 Mar 2023 15:18:05 -0800 (PST)
Date: Sat, 11 Mar 2023 08:18:00 +0900
From: Minwoo Im <minwoo.im.dev@gmail.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>
Subject: [PATCH] mm: mmap: remove newline at the end of the trace
Message-ID: <ZAu6qDsNPmk82UjV@minwoo-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,
RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1760025381681781232?=
X-GMAIL-MSGID: =?utf-8?q?1760025531788184042?=
|
| Series |
mm: mmap: remove newline at the end of the trace
|
|
Commit Message
Minwoo Im
March 10, 2023, 11:18 p.m. UTC
We already have newline in TP_printk so remove the redundant newline
character at the end of the mmap trace.
<...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ...
<...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=...
<...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=...
<...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=...
to
<...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ...
<...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=...
<...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=...
<...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=...
Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
---
include/trace/events/mmap.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 3/11/2023 4:48 AM, Minwoo Im wrote: > We already have newline in TP_printk so remove the redundant newline > character at the end of the mmap trace. > > <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ... > > <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=... > > <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=... > > <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=... > > to > > <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ... > <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=... > <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=... > <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=... > > Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com> Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com> -Mukesh > --- > include/trace/events/mmap.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h > index 216de5f03621..f8d61485de16 100644 > --- a/include/trace/events/mmap.h > +++ b/include/trace/events/mmap.h > @@ -35,7 +35,7 @@ TRACE_EVENT(vm_unmapped_area, > __entry->align_offset = info->align_offset; > ), > > - TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n", > + TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx", > IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr, > IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0, > __entry->total_vm, __entry->flags, __entry->length, > @@ -110,7 +110,7 @@ TRACE_EVENT(exit_mmap, > __entry->mt = &mm->mm_mt; > ), > > - TP_printk("mt_mod %p, DESTROY\n", > + TP_printk("mt_mod %p, DESTROY", > __entry->mt > ) > );
Ping :) On 23-03-11 08:18:00, Minwoo Im wrote: > We already have newline in TP_printk so remove the redundant newline > character at the end of the mmap trace. > > <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ... > > <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=... > > <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=... > > <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=... > > to > > <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ... > <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=... > <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=... > <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=... > > Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com> > --- > include/trace/events/mmap.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h > index 216de5f03621..f8d61485de16 100644 > --- a/include/trace/events/mmap.h > +++ b/include/trace/events/mmap.h > @@ -35,7 +35,7 @@ TRACE_EVENT(vm_unmapped_area, > __entry->align_offset = info->align_offset; > ), > > - TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n", > + TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx", > IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr, > IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0, > __entry->total_vm, __entry->flags, __entry->length, > @@ -110,7 +110,7 @@ TRACE_EVENT(exit_mmap, > __entry->mt = &mm->mm_mt; > ), > > - TP_printk("mt_mod %p, DESTROY\n", > + TP_printk("mt_mod %p, DESTROY", > __entry->mt > ) > ); > -- > 2.34.1 >
On 11.03.23 00:18, Minwoo Im wrote: > We already have newline in TP_printk so remove the redundant newline > character at the end of the mmap trace. > > <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ... > > <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=... > > <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=... > > <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=... > > to > > <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ... > <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=... > <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=... > <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=... > > Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com> > --- > include/trace/events/mmap.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: David Hildenbrand <david@redhat.com>
diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h index 216de5f03621..f8d61485de16 100644 --- a/include/trace/events/mmap.h +++ b/include/trace/events/mmap.h @@ -35,7 +35,7 @@ TRACE_EVENT(vm_unmapped_area, __entry->align_offset = info->align_offset; ), - TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n", + TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx", IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr, IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0, __entry->total_vm, __entry->flags, __entry->length, @@ -110,7 +110,7 @@ TRACE_EVENT(exit_mmap, __entry->mt = &mm->mm_mt; ), - TP_printk("mt_mod %p, DESTROY\n", + TP_printk("mt_mod %p, DESTROY", __entry->mt ) );