Message ID | Y95rqrQOVMRfxnn9@ubun2204.myguest.virtualbox.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1377408wrn; Sat, 4 Feb 2023 06:39:47 -0800 (PST) X-Google-Smtp-Source: AK7set+wwSjtwvn9EpIYNz1uXv35N6wCToLMfap6ueXjGRb2d5o/TzBJdi9XmUQPPj0jEE/tRzZy X-Received: by 2002:a17:902:e14d:b0:196:6741:7c8f with SMTP id d13-20020a170902e14d00b0019667417c8fmr10461596pla.48.1675521586836; Sat, 04 Feb 2023 06:39:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675521586; cv=none; d=google.com; s=arc-20160816; b=FNynQ8aHUrGRUuDz37qnnXzKqtI98zlUYNHrezVdHBWxd9GpSUepQAtP9W9Q2Izk83 nQy24+fcuLuE+ub1CSoA7HQbsUpCilFZMpPEPc03Hetq61lY0vZVRKqO0HlwMSusejTY jJVYseoF3cYvCp2SGImx8QFyWpTeLf9ndKA+j/XCccJfFFyAOg42a8ZhXs5GU6u+7sfn sV2mpho857+Nuadt1d6E159zaOhx4wYFoEdzII4LFyrMPJB2X8fK253Q+mc3KjZGOQJr gAigHRT3e+q9T3w4d7x4rs8AGT+rMgb42bYAhJTU3gmn7f40g5STOYOCpyKHl9ue3xh/ 0Y5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=gfBNA6W7eQQ94kUxEsZuzVPR/dzowhLxIeZ0wC7N/GI=; b=DoAyJLqw56RqGbBy/54isd9iM2XgTiure1nu4bdXzN3teW++nsygQHa2UYBSQHxKtt QfzlNuuGvY+YS0IuAZgR3H1jYlrsyneG9PS727tEbGtW5xaond6yCJoXKPn7jYmD85YN DgEAw338NjD9HTEuryusaTM+C0ItOb75Y1xwCnjuTiVrCs3xIaKR/Tz3tMUv4/+Huqne AU9Xe84geNOaTarFlhsSjS0SSo81b7ZXagzLY8eVD5OjLYWpjyD2grpSzwR5+C3YMofk aoZeLnSrB4zH6JmDgwSDWhV0QLbrx8VCNWXb2HJE81rBNCNSLwRsAH5s7DQvXHPJUfWP 5IRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=CmtlZ9fp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y21-20020a170902e19500b00194c45049d3si5012978pla.538.2023.02.04.06.39.34; Sat, 04 Feb 2023 06:39:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=CmtlZ9fp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233919AbjBDO3c (ORCPT <rfc822;il.mystafa@gmail.com> + 99 others); Sat, 4 Feb 2023 09:29:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231176AbjBDO33 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 4 Feb 2023 09:29:29 -0500 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 452132D171 for <linux-kernel@vger.kernel.org>; Sat, 4 Feb 2023 06:29:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1675520946; bh=2Lsoj+6QlKMk1UqjeFpw397b0NezTsdFl+fpyrVASvQ=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type; b=CmtlZ9fpuxsmM+ZuEofgcLNbPLjDd1ylDRuzLGDJKRD3pZvaZlORGkoGuMrHl8ume 5UhQByxJ0tpBgGdy6/bdnVS+N3qcK8VrNCgMXnukRD2iTpwBdaQ19abMuovnKD16Nb qOtKjxLuOK4SY42pZiMwNu4rQ6ZfZl/5sdobT/Hg= Received: by b-4.in.mailobj.net [192.168.90.14] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sat, 4 Feb 2023 15:29:06 +0100 (CET) X-EA-Auth: 6zhE2JyG1Uhz/yqA+AfRH14Bhmf+2kraZbSVASgvbX02iDQZRarIPoLaD6oEenVtiW2GS2/e3qgB21QfyqL/YTLfzrptcOs1 Date: Sat, 4 Feb 2023 19:58:58 +0530 From: Deepak R Varma <drv@mailo.com> To: Florian Fainelli <f.fainelli@gmail.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Saurabh Singh Sengar <ssengar@microsoft.com>, Praveen Kumar <kumarpraveen@linux.microsoft.com>, Deepak R Varma <drv@mailo.com> Subject: [PATCH] irqchip/irq-bcm7038-l1: Remove unreachable code Message-ID: <Y95rqrQOVMRfxnn9@ubun2204.myguest.virtualbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756911723461460840?= X-GMAIL-MSGID: =?utf-8?q?1756911723461460840?= |
Series |
irqchip/irq-bcm7038-l1: Remove unreachable code
|
|
Commit Message
Deepak R Varma
Feb. 4, 2023, 2:28 p.m. UTC
The macro for_each_possible_cpu() is designed to execute only once,
when the index is zero. Hence the test condition for index value
other than zero will never be reached. Remove this unreachable code.
Issue identified using itnull.cocci semantic patch script.
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
drivers/irqchip/irq-bcm7038-l1.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c index a62b96237b82..1b3ec4001356 100644 --- a/drivers/irqchip/irq-bcm7038-l1.c +++ b/drivers/irqchip/irq-bcm7038-l1.c @@ -410,8 +410,6 @@ static int __init bcm7038_l1_of_init(struct device_node *dn, for_each_possible_cpu(idx) { ret = bcm7038_l1_init_one(dn, idx, intc); if (ret < 0) { - if (idx) - break; pr_err("failed to remap intc L1 registers\n"); goto out_free; }