From patchwork Sun Jan 15 09:32:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 43817 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp661241wrn; Sun, 15 Jan 2023 01:35:44 -0800 (PST) X-Google-Smtp-Source: AMrXdXvGDff2ZUJMAtkoAqUJ7UN6sfSCbjZ/lpyP7rUktxdwdy5sULmZX+pTAwZyL6v27eW9Aryy X-Received: by 2002:a17:903:2596:b0:194:7a99:d5cc with SMTP id jb22-20020a170903259600b001947a99d5ccmr5942953plb.12.1673775344585; Sun, 15 Jan 2023 01:35:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673775344; cv=none; d=google.com; s=arc-20160816; b=ouAqdPXurps3TGRoinYhNPovPzV0yzYPtb56KTgsTAHGWp8ySkt65Jf9jzIq0ba6IO ArLtMcNGYhZEWTO0o6iops7chL4NIUfYIX+Vo/PC55NjDE4WVogEKMkRyIwOQbByMtz/ Yo/bSf4q0/QOJ0kBRb5fklolz6xrQwJFAozco1XQYwEQVyWbWqH5bZCmxLdNqeYXbnI8 QgmozzEcqAWzkB6c6Cn+/K9AlEE6QKXAYfI1+1j/rjU4x68Y0lEhbGX9pc4lWKQVlfRo z3RtqNfvnZC2l6AqOauDQvMUMg4K9jaUA/Or/NmDZeB5pqPcOVRbFCLb6CmV877sw8cE JMCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=/fR/EDgs5QerW9DDTFd+U/+Ocmm/Je63W6qVVGcuBkU=; b=p44Bw4Akk3MagMmMpHxz+Js3dUvBVK67jM7EHC39F7aXwZV5PDanxkYk3xUanqnVHI 8SWK+QxWCh93x9/kK9MB6tnpg/lXro6wP4s1js14umBe6fRQZ/MKHDcUvsboqfGJKxW+ 8aIFHZlTETXeS3U9yqSWVp8UCFR4cOp3mSeceS74DqyQGEYOWXD6Cd96dfhc0iW2GA+l mk8Y8lV98vZAb4ajgX5Qb93g5GPwB3dR7/7nHOa7KzH+yGed3lIfVdlwCeN8ZeJUjlOr SulkSWJKSvGyQd+gxrfpor7GDZI5GML8Lvkn4RUqfZdj2sbdk2tieDrCcsEeuyveWWHk R5XQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=XRtOftUN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s12-20020a17090302cc00b0018965944b98si26687716plk.24.2023.01.15.01.35.32; Sun, 15 Jan 2023 01:35:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=XRtOftUN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbjAOJcf (ORCPT + 99 others); Sun, 15 Jan 2023 04:32:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229715AbjAOJcc (ORCPT ); Sun, 15 Jan 2023 04:32:32 -0500 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 122959017 for ; Sun, 15 Jan 2023 01:32:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1673775142; bh=h3BV35ExW4Qp8mSJAt5y1TYkCZQhRUQwk+nplpac6xs=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type; b=XRtOftUNorQbmCMcA54sJ3NrwQZVSNveuKgJbOSftQ3YhAniPLLuZd6n26IXyzBvP IdBHzt9gQ8rZfCuwx8McAyz0q2H+nOcVA26wP9Ap4z+eD/nstnLbVAdBeEhuEjwYMk Yn3IEohbNoTvKG/x3Sfn3FqUK71GNlLbyu9dxWok= Received: by b-3.in.mailobj.net [192.168.90.13] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sun, 15 Jan 2023 10:32:22 +0100 (CET) X-EA-Auth: DwObgLNILM2GtGPAI+00q8N5h+32tnvd/PwBaxq/eKJBAyAYbimivsEbXvC9hVqYG8F0mkVbytx8mh28znre75c7q2Kq5iw9 Date: Sun, 15 Jan 2023 15:02:17 +0530 From: Deepak R Varma To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?iso-8859-1?q?K=F6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar Subject: [PATCH] drm/amd/display: avoid variable reinitialization Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755080655690364533?= X-GMAIL-MSGID: =?utf-8?q?1755080655690364533?= The member variable set_odm_combine is already initialized and hence the reinitialization instruction can be removed. Issue identified using the dubleinit.cocci Coccinelle semantic patch script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c index 41edbd64ea21..777d8efee977 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c @@ -254,7 +254,6 @@ static struct timing_generator_funcs dcn314_tg_funcs = { .get_hw_timing = optc1_get_hw_timing, .init_odm = optc3_init_odm, .set_odm_bypass = optc314_set_odm_bypass, - .set_odm_combine = optc314_set_odm_combine, .set_h_timing_div_manual_mode = optc314_set_h_timing_div_manual_mode, };