From patchwork Mon Jan 23 15:07:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 47176 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1659354wrn; Mon, 23 Jan 2023 07:11:45 -0800 (PST) X-Google-Smtp-Source: AMrXdXuSLINnTNsoWI3D6+s1+7WWdFzOOheBuQgGuxl4wg/E3QLRa2M+MASAk1Kne51alB8fMY7X X-Received: by 2002:a17:907:7e9c:b0:86e:2c11:9bca with SMTP id qb28-20020a1709077e9c00b0086e2c119bcamr35068225ejc.30.1674486705008; Mon, 23 Jan 2023 07:11:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674486704; cv=none; d=google.com; s=arc-20160816; b=ruQKk/FKwvtRjalsBh3izOWT58Qu49hlweM6bFlew7xt5JbqvtUW5UnySlE7aPZt0b mW0y+X+csItdhaxnTQpxky1Vl30qsAGKszHT36wC88LI5AiV+9FwgQyFpHrHPASDvybD lBfD5C3jCvuATZjx15RAbpZhPPVD9cCjyrkipLmCXFcLBm1SdsnGin9OYaA2rpx/4rMX wxvF7/W5PgL8EM8TyZJrGtMs9nRYUJZtAr5ztUZDBDD3mNH3rCYLbfnV0dHp3fH9WDSa VNfuy3Btu7RakWIjnoGMd9jFSgug0VAZRlSf7ctYhr3x8YtPYs2L0tkFOaQPRqF1XqPl rzXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=2r/jQsT2oEtOaIcS9vBErqTIfKM514JHFTcSRlzNiJk=; b=YFwetDyoiyW3x6KRLask8cMex67ZU5Dgi0lWvaNcKVzqFy8kzXSBsidNQX+vr8oCgG dN2eDpHO9jdVqIyYmzYJ7+fZqC6aWkNG1KKKl9HYJxpwoyvgJ0RyHdvfuSD0YxwsPM/d 7QW57E+QhUMYcycpMj/w2a1uIJCksSIJTew0emgYOOQsRRKWJ9jfnWOeCO51vHLqPHPP 0fwbhfpcW1zKQi9ZioRhEe06EsjSJnao9+vJg7lMCY5/utOlyFVUTwtMVMZfyiLwWJBe PO+ghuFlYF2HmQAFilpKvvDPXq4eHtrWHYlcit0rUHqZs2Tro3ya/o/Z9sQlPJ+yt6gb hS3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=NI9VeMmK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l6-20020a170906794600b007c0a4c149bfsi24969912ejo.403.2023.01.23.07.11.19; Mon, 23 Jan 2023 07:11:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=NI9VeMmK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231804AbjAWPHQ (ORCPT + 99 others); Mon, 23 Jan 2023 10:07:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbjAWPHO (ORCPT ); Mon, 23 Jan 2023 10:07:14 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A5E83ABA; Mon, 23 Jan 2023 07:07:13 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id n7so11103607wrx.5; Mon, 23 Jan 2023 07:07:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=2r/jQsT2oEtOaIcS9vBErqTIfKM514JHFTcSRlzNiJk=; b=NI9VeMmKPpbbz0TCCZFqlACCyCjRtIQH1LXay4iHb5L7cwXC9C05rVzDy8t4boOARD ITqqWkdZFg7s2dhkfzDTO0PYouCczNUgmF+g0YNlPypmfQSuxkf3gwgc0duluEn5zYRe BGj9luGazljmvjSSK2kIM6dkPKipT0gSqF/d9p5/6Koa6Wid4/sy5ZPSc0XvxveIANNL OLmoxPLeorbSCHvaRFPquDrzvdacAeSEWCXY42GIyODGEhGAAU5kpNZnK9BZLN4alsXe 6CCqQjhq0hAxdpyuOyKTM/TAiyOYtOiMc3Px61GIiQ0oL4dOz6mvsI/ahi9gmNe0cVeT buSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2r/jQsT2oEtOaIcS9vBErqTIfKM514JHFTcSRlzNiJk=; b=OV4h8bfhGhX8RuaTzKJ1IX8pUzKOZHZ/8mms97gCr9KVc2VljVoYxabJrVf5HFpe/c PGPNR53TRzl0W8cgJPyfj+bVuXVzCyQ+2U6WxsMLEu3Jn0YoQK7Rszm7TUnuZ+vrMEwy gxJf+/h9ElxWIufu2evQe3RvfsXFeUTfcl/GpTelpKdNYbyO007K7b6YtUfiCmL4+5+j 3jS8RgErbd7PqsVqVide8VrAeFqwsew5JlBVKnvu+LtMLu11goJHxx573vrqSaDSkmol veHsadqP4PXQhSsVKcd4dpZPlIMrG3UnwXgmv39wCsaH+7rFncE4QO0X5TCV7J1XTLYg wA4A== X-Gm-Message-State: AFqh2kqtegPVtG3d/g63bRLz0EWuWBLl28o7vjPUHWBGfuDPbxLCcqxw x6t0xANYWA/iQe7Rf33Z+p1Dhn74R3ElPA== X-Received: by 2002:a05:6000:98d:b0:2bb:6d44:5d1 with SMTP id by13-20020a056000098d00b002bb6d4405d1mr24853979wrb.28.1674486431669; Mon, 23 Jan 2023 07:07:11 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id bu3-20020a056000078300b002be505ab59asm8888399wrb.97.2023.01.23.07.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 07:07:11 -0800 (PST) Date: Mon, 23 Jan 2023 18:07:07 +0300 From: Dan Carpenter To: Sudeep Holla , Cristian Marussi Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] firmware: arm_scmi: Clean up a return statement Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755826571156242981?= X-GMAIL-MSGID: =?utf-8?q?1755826571156242981?= The comments say "enabled" where "disabled" is intended. Also it's cleaner to return zero explicitly instead of ret. Signed-off-by: Dan Carpenter --- drivers/firmware/arm_scmi/driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index d21c7eafd641..703f16ef3953 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -2739,8 +2739,8 @@ static int scmi_probe(struct platform_device *pdev) if (ret) goto clear_dev_req_notifier; - /* Bail out anyway when coex enabled */ - return ret; + /* Bail out anyway when coex disabled. */ + return 0; } /* Coex enabled, carry on in any case. */