From patchwork Thu Dec 15 03:47:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Golle X-Patchwork-Id: 33467 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp123182wrn; Wed, 14 Dec 2022 19:50:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf7Ll8cYz4THkyg6o9NpxHEyAr5QjfGrCfiT8nw8qrEAMIyxfHaej8+ky/nFzdq4omyIe09p X-Received: by 2002:a05:6402:c07:b0:46b:203:f388 with SMTP id co7-20020a0564020c0700b0046b0203f388mr22939968edb.39.1671076222617; Wed, 14 Dec 2022 19:50:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671076222; cv=none; d=google.com; s=arc-20160816; b=Cl0RL0SFmUR98YUu52ZgTneIfsu0+HVIqxya3R8w2dx42jAyN5bPFmvgnL0VNUEPsQ b6/658bTiSkf7rRJ7ybkz6u+0EjbAbeOiAg1kLr2fYvTJFuVk60scJL4ITy4cGS3AU9z OOt68APl0gVJr3qZd4tBnovpxy6y0aLM805IsSnqDS/b0Jl35fYQKEKVwngcSn0d8cll 0fTB0HII29qcWJdXVDtZEFVQB2Fmy7iW8MJuWOQmdNs3qCgzfTsSxBUOzHO6cHXdGbTc Dot9odJjeLIaC2exseaPKfZUv4qriOOZ+ToHiMLrXwhHmQfHfVRu0NAlb5eInghY+JTy DFwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:to:from:date; bh=G5NEhko4JXxYmLxhzCwpLP2OhNuJ/Xt7AkxACKjpuGE=; b=rqwUyluRP8AF0wbEEhdUQogX/7Qe2tfK5PRtVwPVXowilMWq4sktBbwQFkl09dV0iw qckmsbSXP/Gc44HnKXQqXRxBjDbvB/gAjskvEyub1O3JXgeYVVXlUwFnOdbpnBU1t4zt 7n5R1ygqqYsvzOYQuxJFGRYVhSRstqCV/WIHZix147QSiOH0Hss1OUZtm/+Gk4Jsx1E7 YrbSjR3CirL/gWTJO7nduD2hRFur6pwbX+QzieqMh30qqUudwm6a8XA66wAk2w80vJkH /VkNWqE4JhYIyJjV3kp/sYorL2E6t0lTilqIEDhZDCM58Kn5bk6kWd51m/zFy4B8WcUm 2r5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s17-20020a056402165100b0046a222b78a5si12719676edx.249.2022.12.14.19.49.58; Wed, 14 Dec 2022 19:50:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229600AbiLODsO (ORCPT + 99 others); Wed, 14 Dec 2022 22:48:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbiLODsM (ORCPT ); Wed, 14 Dec 2022 22:48:12 -0500 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BFD34385E; Wed, 14 Dec 2022 19:48:11 -0800 (PST) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.94.2) (envelope-from ) id 1p5fE5-0003wP-G6; Thu, 15 Dec 2022 04:48:05 +0100 Date: Thu, 15 Dec 2022 03:47:59 +0000 From: Daniel Golle To: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Jakub Kicinski , Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger Subject: [PATCH net v3] net: dsa: mt7530: remove redundant assignment Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752250421331607771?= X-GMAIL-MSGID: =?utf-8?q?1752250421331607771?= Russell King correctly pointed out that the MAC_2500FD capability is already added for port 5 (if not in RGMII mode) and port 6 (which only supports SGMII) by mt7531_mac_port_get_caps. Remove the reduntant setting of this capability flag which was added by a previous commit. Fixes: e19de30d2080 ("net: dsa: mt7530: add support for in-band link status") Reported-by: Russell King (Oracle) Reviewed-by: Russell King (Oracle) Signed-off-by: Daniel Golle --- Changes since v2: correct commit title 'reduntant' -> 'redundant' Changes since v1: Use 12 chars for fixes tag, fix Russell's contact drivers/net/dsa/mt7530.c | 3 --- 1 file changed, 3 deletions(-) base-commit: 7e68dd7d07a28faa2e6574dd6b9dbd90cdeaae91 diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index e74c6b406172..908fa89444c9 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2919,9 +2919,6 @@ static void mt753x_phylink_get_caps(struct dsa_switch *ds, int port, config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE | MAC_10 | MAC_100 | MAC_1000FD; - if ((priv->id == ID_MT7531) && mt753x_is_mac_port(port)) - config->mac_capabilities |= MAC_2500FD; - /* This driver does not make use of the speed, duplex, pause or the * advertisement in its mac_config, so it is safe to mark this driver * as non-legacy.