From patchwork Wed Dec 14 01:51:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Golle X-Patchwork-Id: 33016 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp478583wrn; Tue, 13 Dec 2022 17:55:45 -0800 (PST) X-Google-Smtp-Source: AA0mqf6YA5vItacdClJH3POSiR5KSzTCOPA3ogrhSKYLoDUO9Z+43njXfrOGI2hUw5JxdtTTHoUc X-Received: by 2002:a05:6402:3648:b0:462:9baa:7507 with SMTP id em8-20020a056402364800b004629baa7507mr19576896edb.8.1670982945354; Tue, 13 Dec 2022 17:55:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670982945; cv=none; d=google.com; s=arc-20160816; b=npZNSHEnSv1Ce2kScAg4AB/LHHGQxP5S89Nk1TMUXmUCbJnIrPRWQZK1BVE0+9Vmtn Uy+P0b4eyiOX3H+6sq37aDnZbOFmPtRCHPaf6CAg7lsQDH3cmb9oKcshYZmgcQFmxMjA 4cKFmKz8dJmsaYJRC9GSzqu3DvMQ6ppNiDb5eaVHKcteA0jwrehbZu/yKsZalW9IWb42 bSBF98GUjXT4C9a++TurSWqJZbpXLEbRh4b8oCfiQ3skpaEWXPSnIcyZyorESjMPPC55 2oqB9ez/0nlZ63McmQo4eZ4CJq0wXH+2qZcU9wPIeMGRoXWFMPdrwuo+rGEZWVU2AZw4 grjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date; bh=YHtf0kOSuEev5ouGyIn3BKGnCBgaIol4Kd3vp4RlFSY=; b=p1fgZRxY3BH7Hc1i7kA29ua5TgLrPQI5sPlwr6P+J6v92z3hicPbryxZHFiqZH6zvL pMQpZrQS//luBA24TofTXBgv/j56aH4flGd5sELyYv9qhSr7M8Y0I3gz+9P0nxfcAwRn 8MhGg0derNkCgKDrnksZuu+QRAGNza3qThmmNsb0OVTinbYm+9aqj0RqxpVZlxpCXtuc 0K2P2Zg0K24bXx8gVojrujIIVxHc8ucGcGGCGfmsDCPpXq/bzpHEvtqAW0RRdG3pDHzE cTCjalndFxtbELnEKWgpJjXcUxU2J62tXwJ9t+OABL+OqAbjmIdgJJKm+X04woala2g1 u/0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m23-20020a509317000000b0046ccfa8e6d5si9714140eda.331.2022.12.13.17.55.21; Tue, 13 Dec 2022 17:55:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236910AbiLNBvY (ORCPT + 99 others); Tue, 13 Dec 2022 20:51:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbiLNBvW (ORCPT ); Tue, 13 Dec 2022 20:51:22 -0500 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D0DD2715B; Tue, 13 Dec 2022 17:51:20 -0800 (PST) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.94.2) (envelope-from ) id 1p5GvS-00055K-Ur; Wed, 14 Dec 2022 02:51:15 +0100 Date: Wed, 14 Dec 2022 01:51:06 +0000 From: Daniel Golle To: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Jakub Kicinski , Russell King , Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger Subject: [PATCH net v2] net: dsa: mt7530: remove reduntant assignment Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752152612836050806?= X-GMAIL-MSGID: =?utf-8?q?1752152612836050806?= Russell King correctly pointed out that the MAC_2500FD capability is already added for port 5 (if not in RGMII mode) and port 6 (which only supports SGMII) by mt7531_mac_port_get_caps. Remove the reduntant setting of this capability flag which was added by a previous commit. Fixes: e19de30d2080 ("net: dsa: mt7530: add support for in-band link status") Reported-by: Russell King (Oracle) Reviewed-by: Russell King (Oracle) Signed-off-by: Daniel Golle --- drivers/net/dsa/mt7530.c | 3 --- 1 file changed, 3 deletions(-) base-commit: 7e68dd7d07a28faa2e6574dd6b9dbd90cdeaae91 diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index e74c6b406172..908fa89444c9 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2919,9 +2919,6 @@ static void mt753x_phylink_get_caps(struct dsa_switch *ds, int port, config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE | MAC_10 | MAC_100 | MAC_1000FD; - if ((priv->id == ID_MT7531) && mt753x_is_mac_port(port)) - config->mac_capabilities |= MAC_2500FD; - /* This driver does not make use of the speed, duplex, pause or the * advertisement in its mac_config, so it is safe to mark this driver * as non-legacy.