From patchwork Mon Nov 14 18:29:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tanjuate Brunostar X-Patchwork-Id: 19984 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2297572wru; Mon, 14 Nov 2022 10:30:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf7loYgkN6qQjR2Fz3hv8PSWiZ4rqfrZ3yxzI7EnoPWz6AvQPO7WDyM8Z/ptHCCK/2nBEjPr X-Received: by 2002:a17:903:453:b0:186:7070:8ab4 with SMTP id iw19-20020a170903045300b0018670708ab4mr559372plb.23.1668450619059; Mon, 14 Nov 2022 10:30:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668450619; cv=none; d=google.com; s=arc-20160816; b=m/409XKjZrlORXvSNW8ZKurjJC0LfOkqcQn2lNNHHukvuYfU/CcG1hqkVu9gA4kPnw n7GAVSz5RXAcdlWkFZVEFqyCGb2SBGgSe/wy9HbVHIee7fOlwrAsGeYL4u0x2UOJ+Y4V 5YpJM6fscglGX7YOiWLXad/YvN5wUM9+osCNDGevStDWBpeEU9OHNmxwzaSgaOq/ZgCe VANSEww3nQNuX4kWQkW/v/Vg1Pm8xUWP6Q9JTQGfTAUfdbdocbAAqON/76nFTReaA0tq dLLfZ/A/w/0IkmSbFPzqEa05vWnRfx8Prrec5IK2ASMSKGzV1PH/420NcsziJ9M2YIRs Ol6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=mFdoRLFi7JhrraRn7c45wb3bzWJSqovAGo3bjhp7fyI=; b=FOLznNd8YWAQ11NdWGbR56IqFYAl84TC33NVC3jo5FJZwLqUZfkD5ohOsta319/ctE lTuOzRL5t3XNJFghkxaeFd4/2kxOwVlNI6l6gT4BYZ6M6nn9GC4Lh9UqMaNVxjFZPmJN 01qCI5H0c53mWyovQtht6XRu8k75xGl6E4ZQMiBuowynbRbIjEsMKiw/pi0cMPFI+eeR Wh+igy/Ze0H00MIUmh15gYrcpY5uSHXWr+Htzx0aFJA2utYN6Rslvif7Ppk8JLU3bPrT r4sNywkqOi4DNWLgg27sNHYzt+kWUMAeOKSD2FIYN8kaj5SjM/F/lVcqIZcoLPAn4ClO 3WQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=liFrItsG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n12-20020a170902d2cc00b0017f9db0233fsi11279247plc.448.2022.11.14.10.30.05; Mon, 14 Nov 2022 10:30:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=liFrItsG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236828AbiKNS3b (ORCPT + 99 others); Mon, 14 Nov 2022 13:29:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236514AbiKNS3a (ORCPT ); Mon, 14 Nov 2022 13:29:30 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA4C423BE0 for ; Mon, 14 Nov 2022 10:29:28 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id g12so20751715lfh.3 for ; Mon, 14 Nov 2022 10:29:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=mFdoRLFi7JhrraRn7c45wb3bzWJSqovAGo3bjhp7fyI=; b=liFrItsGHqZP/eACX5yenPbHtuAo4/hvIHDLAvGPjBQWPP8vZ6QudAW28PsZIYpU5w Msx1qh5y7W+69zUV6LV99T13e9TtmYZCxZYwkC0SBSWBZZKudvQklEIdw0fN4hHtSgba bRcrACytvTbaJgrybCqEJsttaJKTmajYyFinLXR07RKrwl0tLqWo8reEO1vckuSawGnU o4Yhg4R1mBgZKW+O9ce2KAQITkqwTLIidXlBqrjDqW9Cw8cxQt3c9KeR/JDr0SIuwxnd rzuzlecSbpVGjXaYOnIQh0trAZ4GhuEc8uFCCd1rh7IwDjgQq3h8/FVEOcj7Dz0WInfx EI2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mFdoRLFi7JhrraRn7c45wb3bzWJSqovAGo3bjhp7fyI=; b=XMJzXC6EfM9IZRlo/OnlORj9gRETarnm9wSMA8jN27bsxh0nGI8GA1Z7jt6sDMaAhM 5SLUQ8DEL9i6F2PrwiNSQ4UUJ3r5vIVqz6Vfrr44IxoBcd4XG1im4SII98vLXPmgXWTp XPrUZK2QWj6gjdHrsn/vJnxtt8kcWbjgTj3K+t2ggUWoH3nOZE3O2OpjhiNOhY8IcOpn F71/xoK/efWsT3uqUatyXhu1WYwkVbrs3C5kx3/Yyir+YZUyN3tb6LsfZ6RclBmW1D+4 RXdgjSyeXnFc/9ybM6txOtY5c3eSutEwpXBt8mOrFFy9uCgO0iyz6yMQnDvqRq1Tx6Dw 6UAw== X-Gm-Message-State: ANoB5plSVhYRm75iQgigy6FvK9MlMSBMyQbqW1IA5tpZyn41rQmFzyJP J5U4NH/SHJtR8rNNjc+xpQt0MPkZLss= X-Received: by 2002:a05:6512:1398:b0:497:456d:890 with SMTP id p24-20020a056512139800b00497456d0890mr4126440lfa.687.1668450566908; Mon, 14 Nov 2022 10:29:26 -0800 (PST) Received: from elroy-temp-vm ([20.240.130.248]) by smtp.gmail.com with ESMTPSA id y26-20020a2e545a000000b0027718ee951dsm2123739ljd.37.2022.11.14.10.29.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Nov 2022 10:29:26 -0800 (PST) Date: Mon, 14 Nov 2022 18:29:25 +0000 From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: [PATCH v3] staging: vt6655: change the function name s_vFillRTSHead Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749497276307256692?= X-GMAIL-MSGID: =?utf-8?q?1749497276307256692?= Remove the use of Hungarian notation, which is not used in the Linux kernel. Reported by checkpatch Add indentation to the affected function to follow the Linux kernel coding style. This improves visibility Signed-off-by: Tanjuate Brunostar --- v2: corrected confusing changlog message on this patch v3: removed unnecessary function prototype drivers/staging/vt6655/rxtx.c | 40 ++++++++++++----------------------- 1 file changed, 13 insertions(+), 27 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 31ae99b3cb35..715b323cd2a8 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -23,7 +23,7 @@ * s_uGetTxRsvTime- get frame reserved time * s_vFillCTSHead- fulfill CTS ctl header * s_vFillFragParameter- Set fragment ctl parameter. - * s_vFillRTSHead- fulfill RTS ctl header + * fill_rts_header- fulfill RTS ctl header * s_vFillTxKey- fulfill tx encrypt key * s_vSWencryption- Software encrypt header * vDMA0_tx_80211- tx 802.11 frame via dma0 @@ -85,16 +85,6 @@ static const unsigned short fb_opt1[2][5] = { #define DATADUR_A_F1 13 /*--------------------- Static Functions --------------------------*/ -static void s_vFillRTSHead(struct vnt_private *pDevice, - unsigned char byPktType, - void *pvRTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - struct ieee80211_hdr *hdr, - unsigned short wCurrentRate, - unsigned char byFBOption); - static void s_vGenerateTxParameter(struct vnt_private *pDevice, unsigned char byPktType, struct vnt_tx_fifo_head *, @@ -555,19 +545,15 @@ s_uFillDataHead( return buf->duration; } -static -void -s_vFillRTSHead( - struct vnt_private *pDevice, - unsigned char byPktType, - void *pvRTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - struct ieee80211_hdr *hdr, - unsigned short wCurrentRate, - unsigned char byFBOption -) +static void fill_rts_header(struct vnt_private *pDevice, + unsigned char byPktType, + void *pvRTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + struct ieee80211_hdr *hdr, + unsigned short wCurrentRate, + unsigned char byFBOption) { unsigned int uRTSFrameLen = 20; @@ -912,7 +898,7 @@ s_vGenerateTxParameter( buf->rrv_time_a = vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSize, wCurrentRate, bNeedACK); buf->rrv_time_b = vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrameSize, pDevice->byTopCCKBasicRate, bNeedACK); - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); } else {/* RTS_needless, PCF mode */ struct vnt_rrv_time_cts *buf = pvRrvTime; @@ -931,7 +917,7 @@ s_vGenerateTxParameter( buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSize, wCurrentRate, bNeedACK); /* Fill RTS */ - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); } else if (!pvRTS) {/* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf = pvRrvTime; @@ -945,7 +931,7 @@ s_vGenerateTxParameter( buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrameSize, wCurrentRate, bNeedACK); /* Fill RTS */ - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); } else { /* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf = pvRrvTime;