From patchwork Thu Nov 3 19:15:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tanjuate Brunostar X-Patchwork-Id: 15106 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp719956wru; Thu, 3 Nov 2022 12:17:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5hBXyvvDKwWNsYQD+qEvJ18+lhCGTnWtYJFcK+qzB+fb6NsNbv63ziUPG/WTlEsC/xjnzm X-Received: by 2002:a63:5702:0:b0:44b:290:f24f with SMTP id l2-20020a635702000000b0044b0290f24fmr27272493pgb.558.1667503064503; Thu, 03 Nov 2022 12:17:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667503064; cv=none; d=google.com; s=arc-20160816; b=Nvm55z8gIJmbiLTD2qwta+0qikK0l2khUUhZS8zTtVKRTFLJRP1ywpWJrfrHi/7syO D7Y/RJiZMciTXCAnVdecUHORSCwSpe9UHDX9nAwcK+GI3VCKo6qURp7h5KSwu/AX76Ux dqhk68N148WQelCwg8LNSACv2oUqZ4Fd/4Ls/sIwYAmpLHepv+fwC6jaMqN53Ty3RS+E B0721j03qrMSCenOkGCH4OuyHXWidq+L8RyKFQfdrG7qOiWczoYPoq3xKWi3hr0mVlHd hlMZhsB8SaOEbBivgzNOLO1e5Y6vLNYH7xow5spbdfRaLalTLhe/EwftoBc8NjWV1jeu 5nLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:to:from:date:dkim-signature; bh=YCCC/aaN0XwGV5+u45rOCEbVu+I1nibQFzTI08X/CaE=; b=BFo0ejFRXsR/kZ3Ch5yhUtz2koQaJ+6DSOO9AbaYBgY2rkd1tysSZ1nU2IXTYBesNG NY9RMVNVlXkdaaMA5uwY+V+tCshZoCP9U01iDgkqE0MkU8W2yhcCuEpDJIS0/qaesqtN zaEzX4zVhQUXlcdwVFkCpl7eyS0vyBzsPkFPLTFGJKozJ2VA0mCz2NC5t7YuQc8gJ1oo m8D2+HjtQTdLd3S1LpUTRQA8DJdwH+dc2grWMFeAc8iO/ZogU/ulW5SRmnpSWm9g3lC1 iI93G8NGEdsjILcYPliSKpVJCv+nPd3GmTV05Lu8zWvle2rB37Y6IiNDsk5HrQiuMtHv lDwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VFQpT11C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m5-20020a17090b068500b001faf26eed66si626281pjz.150.2022.11.03.12.17.26; Thu, 03 Nov 2022 12:17:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VFQpT11C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229570AbiKCTPX (ORCPT + 99 others); Thu, 3 Nov 2022 15:15:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231382AbiKCTPK (ORCPT ); Thu, 3 Nov 2022 15:15:10 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 672EE1F63E for ; Thu, 3 Nov 2022 12:15:07 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id p8so4418999lfu.11 for ; Thu, 03 Nov 2022 12:15:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=YCCC/aaN0XwGV5+u45rOCEbVu+I1nibQFzTI08X/CaE=; b=VFQpT11C9r1bia/G9DdHNF9ckFzQSI3EmESar5wRAdAUX6Cyp0dhYYqk/vDA4KJXHS DrvB6y4K9uy73vrA1dN94MD/D9kA4sMFW6oDQg/NimpDud6epm/ykPmd1E3SqNbqQVIP 0gaGiZ8PUuB7TWPwnHxjwzYdrxBw+HC1JszdeV5F6LugdYs5S5sfyrGB42tfKpr7t62O 7TBapxU5oBGQv56G178SOTiiw6yqjwKfuLu1/moJLY3yUkXbR2RrQq6UdkbmPKC4jgPj vdgZJ8ja0L1DjrWfWV+Gg4u8UvQopDkV0HO4VMH2sjLX6nMzMPns2vSP3HKrQPgU5a37 IWhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YCCC/aaN0XwGV5+u45rOCEbVu+I1nibQFzTI08X/CaE=; b=DeBR0hbgniNkvyBZHZQWteSewRkop7RtGaN1jF832wmRfmYMyKvIaJoLx0QV/g7Grk tO/vPaGAte0FHITmBCUHqWmdDPRaHEGG89fab0Ncee9+n8Wh1xJ6kx21xPrMo8U+m0M/ i+T8VWvjTUsMGi/wpX9PfMuMuuslG7K+SMFuk64izL9FYuMVClAt0RKu/vwICvEzdBVk RghiIO+XuJJYyzjQgSlbruJqTBoAQVw01jannHJ0JvDy6mDnNwj+v2vOTtGQd85aPC9u oYlzu97JQdquVTek1nP3ifiYjHbqzzi8JQBsfk17YBpNOo/ebWswMEm1y3oE0tCTQJpC wn8g== X-Gm-Message-State: ACrzQf0+r0touUy5jjfPT6TJMynKaCYSWp3BKNQOoUYJ6X2sehHPGUzM oW8nCnf/2ohGfmIta6c043B4YLGxs48y/A== X-Received: by 2002:a05:6512:b0e:b0:4ae:23c9:1b32 with SMTP id w14-20020a0565120b0e00b004ae23c91b32mr11629860lfu.246.1667502905605; Thu, 03 Nov 2022 12:15:05 -0700 (PDT) Received: from elroy-temp-vm ([20.240.130.248]) by smtp.gmail.com with ESMTPSA id c4-20020ac244a4000000b004a47a92ff4csm218348lfm.193.2022.11.03.12.15.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 12:15:05 -0700 (PDT) Date: Thu, 3 Nov 2022 19:15:04 +0000 From: Tanjuate Brunostar To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: [PATCH v2] staging: vt6655: change the function name s_vFillRTSHead Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748393911824348006?= X-GMAIL-MSGID: =?utf-8?q?1748503693203606749?= Remove the use of Hungarian notation, which is not used in the Linux kernel. Reported by checkpatch Add indentation to the affected function headers to follow the Linux kernel coding style Signed-off-by: Tanjuate Brunostar --- v2: corrected confusing changlog message on this patch drivers/staging/vt6655/rxtx.c | 48 ++++++++++++++++------------------- 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 31ae99b3cb35..debc5d5daede 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -23,7 +23,7 @@ * s_uGetTxRsvTime- get frame reserved time * s_vFillCTSHead- fulfill CTS ctl header * s_vFillFragParameter- Set fragment ctl parameter. - * s_vFillRTSHead- fulfill RTS ctl header + * fill_rts_header- fulfill RTS ctl header * s_vFillTxKey- fulfill tx encrypt key * s_vSWencryption- Software encrypt header * vDMA0_tx_80211- tx 802.11 frame via dma0 @@ -85,15 +85,15 @@ static const unsigned short fb_opt1[2][5] = { #define DATADUR_A_F1 13 /*--------------------- Static Functions --------------------------*/ -static void s_vFillRTSHead(struct vnt_private *pDevice, - unsigned char byPktType, - void *pvRTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - struct ieee80211_hdr *hdr, - unsigned short wCurrentRate, - unsigned char byFBOption); +static void fill_rts_header(struct vnt_private *pDevice, + unsigned char byPktType, + void *pvRTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + struct ieee80211_hdr *hdr, + unsigned short wCurrentRate, + unsigned char byFBOption); static void s_vGenerateTxParameter(struct vnt_private *pDevice, unsigned char byPktType, @@ -555,19 +555,15 @@ s_uFillDataHead( return buf->duration; } -static -void -s_vFillRTSHead( - struct vnt_private *pDevice, - unsigned char byPktType, - void *pvRTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - struct ieee80211_hdr *hdr, - unsigned short wCurrentRate, - unsigned char byFBOption -) +static void fill_rts_header(struct vnt_private *pDevice, + unsigned char byPktType, + void *pvRTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + struct ieee80211_hdr *hdr, + unsigned short wCurrentRate, + unsigned char byFBOption) { unsigned int uRTSFrameLen = 20; @@ -912,7 +908,7 @@ s_vGenerateTxParameter( buf->rrv_time_a = vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSize, wCurrentRate, bNeedACK); buf->rrv_time_b = vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrameSize, pDevice->byTopCCKBasicRate, bNeedACK); - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); } else {/* RTS_needless, PCF mode */ struct vnt_rrv_time_cts *buf = pvRrvTime; @@ -931,7 +927,7 @@ s_vGenerateTxParameter( buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSize, wCurrentRate, bNeedACK); /* Fill RTS */ - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); } else if (!pvRTS) {/* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf = pvRrvTime; @@ -945,7 +941,7 @@ s_vGenerateTxParameter( buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrameSize, wCurrentRate, bNeedACK); /* Fill RTS */ - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); } else { /* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf = pvRrvTime;