From patchwork Thu Nov 3 11:29:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tanjuate Brunostar X-Patchwork-Id: 14822 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp469220wru; Thu, 3 Nov 2022 04:31:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7/gfrHa7hNcz5myTo6uc4Zu6xgtxHT3nco9d/atBGF6vIoe4DYb+GRs4srNl7vnwzJEKYb X-Received: by 2002:a17:907:6d03:b0:782:abba:936c with SMTP id sa3-20020a1709076d0300b00782abba936cmr28565738ejc.758.1667475094001; Thu, 03 Nov 2022 04:31:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667475093; cv=none; d=google.com; s=arc-20160816; b=0N9mwuumg+kIBB2hf7YSWVjXWmFKaPmKX9EGwFH4XShzwrlzPprcq937XtfHLT/7wh Urpz+25tNgpapgeDYkd42hX2cAKCnO4WL4gxFfcmjf/ABYnAAdNN09QSZnzMOpmIGoB/ r5PvKo0UYApRSBjvmgZtqvHm0usuH1mxXP8Iim7glh+oasNOUNsqlXdZoj8C4VLNChgk xn1WD0pJ4YD2R0rR+M9u2A2o6/4WH1DdYY7Ph9x4XLgw772Zm0D46UcsREsApSrkpC/p 9qKcL1VP8AZgAK5YRmZcBmB+homnbYAvGuhmRt47tTCfY49fcohhhGv0MlnzMw5/q+xF 09WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:to:from:date:dkim-signature; bh=Ji8a4yG4RjSdG7BLCUtmcpBYrxK+oJyQ34/a2EhpGDc=; b=MFlZ57YoZKPMl3Y0KD90VsClwuhgdiwcc+KslxFJdHlqKnOdm/80sIzOYK6xl20FlR T/N8ZEo8pkQIBKY1bjVJP1Yug7mJRPsqYqWacx20TrP9wuqMBRfk8vnnMcLTF26/4+PT +lGASxTjDWzseoZMaGLHFpzerJJEiIAvvAhuLkMjyoYP0oIJqKJeFp5Q8hpoZTEq8svE v2nzGOQJaRvhczqIQuCeKGvD2lVh/pNIMM4XPcuoPWbG26F5pjWHGkhp51wUk0VGz7x0 soh6YPsfUC1qnVK0VciaIAEpbC1RYu+T6JuhPUdFBD5rO+WeEt9u91gyB5gb+SOov+NM Wu7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="i437q/kU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k8-20020a17090627c800b0078c2c22d6cesi839092ejc.70.2022.11.03.04.31.09; Thu, 03 Nov 2022 04:31:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="i437q/kU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229809AbiKCL3N (ORCPT + 99 others); Thu, 3 Nov 2022 07:29:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbiKCL3L (ORCPT ); Thu, 3 Nov 2022 07:29:11 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E035811811 for ; Thu, 3 Nov 2022 04:29:08 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id c1so637010lfi.7 for ; Thu, 03 Nov 2022 04:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=Ji8a4yG4RjSdG7BLCUtmcpBYrxK+oJyQ34/a2EhpGDc=; b=i437q/kUp1uPQM4UD6FyTPNjz/1+HTAK5HrZQ45guWjdEBZMg1e4w8DTUZc44Mbix9 lsuLn29TKXwj3Emf47sO7JCc91PLpS8alu+6kbOWEcbyRoxQT2TPt3JyagDsK0R+uou4 iyOmjPVS+Q1r/0RIiXQ28XjFNMshPlsuer6oOPgPFSkEkG+c+ptVBs0oSSHgm2IqD3dv XdYmreEpBMdSwY+9zZy2CvuZ6QryWhGoOJw+KI6cc1kS7UIcaBJ2R4qCEF9N4v8YWMbx cnTY/RQ/eSJBmn6376Jh3p7WD8ACNyiVRmLI2uqdXje/66a4qdKCQ02n1rr1TvmkSDMq bopA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ji8a4yG4RjSdG7BLCUtmcpBYrxK+oJyQ34/a2EhpGDc=; b=EA+3nieOdQKSSjRjOo38G1QQpkd8j5BlFt2P1G1Lji7zgOrIgl/4i+6X4uL3fksLJV GZ5XhBDoLBPwDFKhPKfW6EInJ3Yzxwor4/BtikRKZAdru/s+RyKzFMnyTrXBSXrFdcoT xxNEWRwVhzSUwDBp+fKgZrBxNc0djFA7eV7s3hQ45qmdyclcKhvtVJL8qmJ3e6eOUgPV LABo5seBsgkL9wT9i070QbmebpYozXVSf8W1Xf5YDe+Ra9N3hQ/hgbwmrnbLiSyDFuUE d7sZDZKTdPdJ7xzy7Jlt72loApVngaLeJWpaEPP5iQLaoZRaKpGfJHRmq0evzpOHbYXG r/uA== X-Gm-Message-State: ACrzQf35rWKpStQzRr0aOQfI5+pwl06af9P04mwE2CP1BURde2ffKsYc ZpAG0UVZ3YgUtVZL/x7OPV2zKvL5RRUB7A== X-Received: by 2002:a05:6512:3c8f:b0:4a2:5959:8b5e with SMTP id h15-20020a0565123c8f00b004a259598b5emr12323417lfv.647.1667474947037; Thu, 03 Nov 2022 04:29:07 -0700 (PDT) Received: from elroy-temp-vm ([20.240.130.248]) by smtp.gmail.com with ESMTPSA id s17-20020a056512203100b004a2cd6d5ad6sm100308lfs.19.2022.11.03.04.29.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 04:29:06 -0700 (PDT) Date: Thu, 3 Nov 2022 11:29:06 +0000 From: Tanjuate Brunostar To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: [PATCH] staging: vt6655: change the function name s_vGenerateTxParameter Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748474364150322022?= X-GMAIL-MSGID: =?utf-8?q?1748474364150322022?= Remove the use of Hongarian notation which is not used in Linux kernel. Join some lines of code to avoid a line ending in a '(' Reported by Checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 54 ++++++++++++++++------------------- 1 file changed, 25 insertions(+), 29 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index debc5d5daede..793a63b2ff46 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -10,7 +10,7 @@ * Date: May 20, 2003 * * Functions: - * s_vGenerateTxParameter - Generate tx dma required parameter. + * generate_tx_parameter - Generate tx dma required parameter. * vGenerateMACHeader - Translate 802.3 to 802.11 header * cbGetFragCount - Calculate fragment number count * csBeacon_xmit - beacon tx function @@ -95,17 +95,17 @@ static void fill_rts_header(struct vnt_private *pDevice, unsigned short wCurrentRate, unsigned char byFBOption); -static void s_vGenerateTxParameter(struct vnt_private *pDevice, - unsigned char byPktType, - struct vnt_tx_fifo_head *, - void *pvRrvTime, - void *pvRTS, - void *pvCTS, - unsigned int cbFrameSize, - bool bNeedACK, - unsigned int uDMAIdx, - void *psEthHeader, - unsigned short wCurrentRate); +static void generate_tx_parameter(struct vnt_private *pDevice, + unsigned char byPktType, + struct vnt_tx_fifo_head *, + void *pvRrvTime, + void *pvRTS, + void *pvCTS, + unsigned int cbFrameSize, + bool bNeedACK, + unsigned int uDMAIdx, + void *psEthHeader, + unsigned short wCurrentRate); static unsigned int s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType, @@ -864,21 +864,17 @@ s_vFillCTSHead( - * unsigned int cbFrameSize, Hdr+Payload+FCS */ -static -void -s_vGenerateTxParameter( - struct vnt_private *pDevice, - unsigned char byPktType, - struct vnt_tx_fifo_head *tx_buffer_head, - void *pvRrvTime, - void *pvRTS, - void *pvCTS, - unsigned int cbFrameSize, - bool bNeedACK, - unsigned int uDMAIdx, - void *psEthHeader, - unsigned short wCurrentRate -) +static void generate_tx_parameter(struct vnt_private *pDevice, + unsigned char byPktType, + struct vnt_tx_fifo_head *tx_buffer_head, + void *pvRrvTime, + void *pvRTS, + void *pvCTS, + unsigned int cbFrameSize, + bool bNeedACK, + unsigned int uDMAIdx, + void *psEthHeader, + unsigned short wCurrentRate) { u16 fifo_ctl = le16_to_cpu(tx_buffer_head->fifo_ctl); bool bDisCRC = false; @@ -1107,8 +1103,8 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType, memset((void *)(pbyTxBufferAddr + wTxBufSize), 0, (cbHeaderLength - wTxBufSize)); /* Fill FIFO,RrvTime,RTS,and CTS */ - s_vGenerateTxParameter(pDevice, byPktType, tx_buffer_head, pvRrvTime, pvRTS, pvCTS, - cbFrameSize, bNeedACK, uDMAIdx, hdr, pDevice->wCurrentRate); + generate_tx_parameter(pDevice, byPktType, tx_buffer_head, pvRrvTime, pvRTS, pvCTS, + cbFrameSize, bNeedACK, uDMAIdx, hdr, pDevice->wCurrentRate); /* Fill DataHead */ uDuration = s_uFillDataHead(pDevice, byPktType, pvTxDataHd, cbFrameSize, uDMAIdx, bNeedACK, 0, 0, uMACfragNum, byFBOption, pDevice->wCurrentRate, is_pspoll);