From patchwork Tue Oct 25 08:20:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paulo Miguel Almeida X-Patchwork-Id: 10588 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp878102wru; Tue, 25 Oct 2022 01:28:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6EAl4dhotPUfzHaAkdxtBwS3m2oKyPLW473lZ/VgCAG7/qGr4pH8HyFGPUkhQ+3no4IZKv X-Received: by 2002:aa7:c054:0:b0:453:98c6:f6c4 with SMTP id k20-20020aa7c054000000b0045398c6f6c4mr34351140edo.2.1666686518868; Tue, 25 Oct 2022 01:28:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666686518; cv=none; d=google.com; s=arc-20160816; b=xP4o1NBrgc6dYRXsgZs7Cl4x4PC3BrmZ0KJnr+8ZqLxWq0z2R0GR6TQ99e7jHFdEzd gpyItlULT8IfYleeLQ9cCilDrilh5byph1LLJtSlM+Aa0bcdl6o9UubXhiXn9YioLgAJ o3zY/e/nEGFZBq+Ia+CL7bHk+GU/lOYPvRg5qp4kTyTamUV8HuhA3vrXHFogTkRxrklI KoBF5G2goDWMli3+MDEfXK2WLotvNEghAAs4zXU2aELlTMfSD9BxEAxG5ptbhwdYcys2 o0k+zPnVoM7i3dsqElmEfn+HXFiL1dH/5wahdxbS7JzyaJ+1QE9/dXynCAt4JngtBsz8 F0NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=hvpi/0hv5kwOhSpI6auXNn4+exWXdyR8pJzRSsgKkfY=; b=fvqMNte/H7REj3N4Nim3xdayICsy13cSiME9MEQhOVQsTkKOsYH5Az9pNi+yyaaKXV JMARE0deE/seEEkJxdqjW3F+gf3IS8HZlbpAeAnQEZHebA5yDA4StwRostCtxawpAt7A KmDHquqKfTbKPqE3jw4H5Tf2AFsOm8A2rp8qMF5frqCRqY3AmoBEIOmBvv5/SvFU2spK N7RYZdxxY+qpa9DP9aj95esMT3OQ/luerqB23fnilw1zTBmF2M2YBg32YluQixITw2Pu Tk9Om7EcGvbLovUEHJ7+AzT3znBdqLAmlmr1w3GV6+8y3JDdN9BUHy4xuHlwkpQOlvbZ 6nxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=SldVfq6U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q9-20020a170906770900b007a0f4d6bf83si1752241ejm.305.2022.10.25.01.28.14; Tue, 25 Oct 2022 01:28:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=SldVfq6U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231240AbiJYIUp (ORCPT + 99 others); Tue, 25 Oct 2022 04:20:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232102AbiJYIUk (ORCPT ); Tue, 25 Oct 2022 04:20:40 -0400 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D82EDD2CFE for ; Tue, 25 Oct 2022 01:20:38 -0700 (PDT) Received: by mail-oi1-x22c.google.com with SMTP id o64so13308488oib.12 for ; Tue, 25 Oct 2022 01:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=hvpi/0hv5kwOhSpI6auXNn4+exWXdyR8pJzRSsgKkfY=; b=SldVfq6UtUw8/E8uuD2Mv2nV74ZmTFj1gsPKITkVZY9Nny096pqIdCIDaZHvkvaHWB ila45Io6vb1LMjxDOP/K8zeIpPHQK1j716DNAdkkdmOhkQtej0hgW+YTExbLFCEroavx WcFvpgwU8/iNYALOa5sNqRndSqHB97ptGdbDoAgjyqSvLze/2U96HgSAB/UNKNiUQgVR jcFHwri1clWWl2qvpCDZ3OJIRdzvROQC66XFpJELNepSiaSrNgibfKqCH26T6RjlbfeV /Turt4TaWN9fntByk9k4LThOWfYGX9tE8wNmXyPuzKfVdLrLxhKKL3pjvFS7BWRwc6A2 Gx7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hvpi/0hv5kwOhSpI6auXNn4+exWXdyR8pJzRSsgKkfY=; b=aVBxKnboG+b3xNPbcFfd1JxGUoSnwnddOrlS4SnLWUIW4j+4INbvO749I3pOD/aMi+ Gxs5yo0Eilcvd92oh2HJpslBBfqr2sUtZ5imn476qkTkcomv1slDQhLtldTNtk4IwwLH EoCLbk0YHRwXPypeOdZHdMy6/Pl1unFcrDyjx0fvmTGwAXEvk5yG1rRHHEzRfQB8z9KJ g0uA3YvHc988KDZeF4aD27uqqTGbwR/IhMlYV+xiXZ7sMAd/OAkmdT51aS4nP2M2lrV/ FCQPcPGCBqwckXk06HIQxmDbmwJUrMKDSW/+kxfC451UYxnW7Xh18YSlFGWow6VwPvci sxdQ== X-Gm-Message-State: ACrzQf2YReipF9ct0RVcTYh9jaD0KI8jJAZ/19Cg8PHf68s3+JHEcR5u XtopGS8tjXyvJ3lylMDwMC5vUIoUYoFyiu1S X-Received: by 2002:a17:90a:7805:b0:20d:4fd9:9a0e with SMTP id w5-20020a17090a780500b0020d4fd99a0emr43652081pjk.169.1666686027363; Tue, 25 Oct 2022 01:20:27 -0700 (PDT) Received: from mail.google.com (122-58-209-93-fibre.sparkbb.co.nz. [122.58.209.93]) by smtp.gmail.com with ESMTPSA id b10-20020a170902650a00b0017f756563bcsm812496plk.47.2022.10.25.01.20.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 01:20:26 -0700 (PDT) Date: Tue, 25 Oct 2022 21:20:19 +1300 From: Paulo Miguel Almeida To: Felix Kuehling , Alex Deucher , Christian =?utf-8?b?S8O2bmln?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, paulo.miguel.almeida.rodenas@gmail.com Subject: [PATCH] [next] amdkfd: remove unused struct cdit_header Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747647483634285895?= X-GMAIL-MSGID: =?utf-8?q?1747647483634285895?= struct cdit_header was never used across any of the amd drivers nor this is exposed to UAPI so it can be removed. This patch removes struct cdit_header and refactor code accordingly Signed-off-by: Paulo Miguel Almeida --- At some point, removing this structure was suggested during a review for a different patch but the clean up patch was never sent. https://lore.kernel.org/lkml/0eeaa0b7-7ae6-c244-cfcd-86333d8f9b8b@amd.com/ --- drivers/gpu/drm/amd/amdkfd/kfd_crat.h | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.h b/drivers/gpu/drm/amd/amdkfd/kfd_crat.h index 482ba84a728d..22893ff7b9a1 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.h +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.h @@ -29,11 +29,10 @@ #pragma pack(1) /* - * 4CC signature values for the CRAT and CDIT ACPI tables + * 4CC signature value for the CRAT ACPI table */ #define CRAT_SIGNATURE "CRAT" -#define CDIT_SIGNATURE "CDIT" /* * Component Resource Association Table (CRAT) @@ -292,27 +291,6 @@ struct crat_subtype_generic { uint32_t flags; }; -/* - * Component Locality Distance Information Table (CDIT) - */ -#define CDIT_OEMID_LENGTH 6 -#define CDIT_OEMTABLEID_LENGTH 8 - -struct cdit_header { - uint32_t signature; - uint32_t length; - uint8_t revision; - uint8_t checksum; - uint8_t oem_id[CDIT_OEMID_LENGTH]; - uint8_t oem_table_id[CDIT_OEMTABLEID_LENGTH]; - uint32_t oem_revision; - uint32_t creator_id; - uint32_t creator_revision; - uint32_t total_entries; - uint16_t num_domains; - uint8_t entry[1]; -}; - #pragma pack() struct kfd_dev;