| Message ID | Y1JlnJ/UpBgm9XEC@elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp591087wrr;
Fri, 21 Oct 2022 02:40:21 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM7Vc0oUMPzud9Q2h5MEbKTL4XfaSF3HyWrz+ofX+AqVSybXtnVciBX902wMBX+FeBpZy5xV
X-Received: by 2002:a17:90b:3e86:b0:20d:ab3e:bc50 with SMTP id
rj6-20020a17090b3e8600b0020dab3ebc50mr21243012pjb.53.1666345220879;
Fri, 21 Oct 2022 02:40:20 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1666345220; cv=none;
d=google.com; s=arc-20160816;
b=gvE63ww6hCUMeMkZ3OR+GyZwzEwy31mvxuwd0e0GwKynWzRYU2X1dZsJXnKAoaJOOJ
ghAyLOjBt2g4Ev5xr+5so66Sh6/94DAR5Iy5hR3DviB+8Q5kzj3Edtfvd+/BptMl8NjS
7AvSWfDwjowW2Tzf+ltEKd7DGejQI2HuHNdDQieysnkh/WeGyOwzG0KWHoW79+ffbNwE
S0VGQupeNSn6QXeazLrWBTsJXAJC7Lc6j0T89rJU4RL0A4Pv4gMrrqMnfrBAW/VsXaWn
4J+6/JiSNjCs+k8EpQSTIECbFnem/Jev8CUv4FThWBuBBjIyNGsC4LqL99aknomrIrmy
6ozg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-disposition:mime-version:message-id
:subject:to:from:date:dkim-signature;
bh=C2MVCCy2Kj88bAGrrwyous+SY2zFdp50BJwaTNbSgJs=;
b=QUH9DBeTMfZMlr5367mdKS6/++Q2in7t39ZgTgj0QDfLsfuCIoGVmvKQQWeH7HBhzI
bOnrOC7RKYyqsU/DDrXej8aNFbjcqyWCtcsnKG8WRq1skcuDzUzwc9Q/C3rNa44Ift/a
lLUS7Ilo76rbvoAvyEmSjnu4p0sjqxsLk4++OjVtVH+5z0J6xnWpXyg2AD852/p/Me8c
oC0IXn4MpR8190sP0DyI3cA/92vosR2qLt3HMHUmsJ3FrF0sQlEbDDfdEu3mTuBf81p/
zffK0maeKQafAcPEEO2HlaMjGmOy1TIfHlyx/xeNkc/g2DVhfK39ox/L3Y8kqxqPpdwM
ELdA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@gmail.com header.s=20210112 header.b=e1Ug2fbq;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
v10-20020a17090a00ca00b001fdd4a9fd3fsi5785372pjd.146.2022.10.21.02.40.07;
Fri, 21 Oct 2022 02:40:20 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@gmail.com header.s=20210112 header.b=e1Ug2fbq;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230119AbiJUJ0L (ORCPT <rfc822;pwkd43@gmail.com> + 99 others);
Fri, 21 Oct 2022 05:26:11 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45982 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229988AbiJUJ0H (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 21 Oct 2022 05:26:07 -0400
Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com
[IPv6:2a00:1450:4864:20::12b])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFB7216D55C
for <linux-kernel@vger.kernel.org>;
Fri, 21 Oct 2022 02:25:51 -0700 (PDT)
Received: by mail-lf1-x12b.google.com with SMTP id f37so4043385lfv.8
for <linux-kernel@vger.kernel.org>;
Fri, 21 Oct 2022 02:25:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20210112;
h=content-disposition:mime-version:message-id:subject:to:from:date
:from:to:cc:subject:date:message-id:reply-to;
bh=C2MVCCy2Kj88bAGrrwyous+SY2zFdp50BJwaTNbSgJs=;
b=e1Ug2fbqBV828vW2hp81OZQM8ZZrtqzFoCgUtgF1WPGaTyc+HKq4vG6c/GhnbLHqs/
G34p+YJXUqnyngkTTPuvqC3bVytW4N/GYy4OyczPzpg+BBUlNFmJwrqC4xICbSIJdGVq
oTLTLNJXWuZlKtpB3+ZcBBceSmeXnnTjQCghJpJqk+BztA39iGgHGgeYr1Ypb5DonO0A
JWnPCiGhpyQg5gtS4ywgKcQRgr3cLDK3m/cZ6jrod8s+I6nZbZX3XkZxrYocUebwMO1v
RZBtWS7qIZ1PY9GrYy4RBUurwv1D8cznf9ihBC01AYjnLx2RhjAL4LG31co9eZKB1iQg
m15w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-disposition:mime-version:message-id:subject:to:from:date
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=C2MVCCy2Kj88bAGrrwyous+SY2zFdp50BJwaTNbSgJs=;
b=FjeH6GpgB3da3nPWVbpFe13ErORd3twwswaREbAZUpbQ0ftkAy2tLnVI88AFvDad4R
kZwBZo7GU9s0pkHp/Czpmo4DvTqFE/c2OsI2n/cd11XtXEL9hImr3dbUfROIYU3J6zX3
BTiFtjaVda/OZl6BuWxsHIoT2I9O9H9lrj8sI3N3p39DGoJ5wHh6Mc94Pwj9XJjFW3JU
ErNZ+J7logyFx8aXc9ZhrkrgLdmlEdIDzvNbrGEzXXo/M6H3Sf2YnU90Gx+opWP565Ne
XCMdN17uv2CYrTlDPMOJ6bLdi120N49fZNCqxjSG9gT79wjQcuc+cgLyW2+6KFzssjWc
Hs4Q==
X-Gm-Message-State: ACrzQf2p8/rbXu855apPCU8B4DIQV7/654RFNmbvlHSeYHlO/XbXSL+l
o8SmScwyl2oVxvymFqZroj5DQpJntAYJ8qbu
X-Received: by 2002:ac2:44c1:0:b0:4a6:113f:ab60 with SMTP id
d1-20020ac244c1000000b004a6113fab60mr4222002lfm.475.1666344349940;
Fri, 21 Oct 2022 02:25:49 -0700 (PDT)
Received: from elroy-temp-vm ([20.240.130.248])
by smtp.gmail.com with ESMTPSA id
n13-20020ac2490d000000b0049b8c0571e5sm3091491lfi.113.2022.10.21.02.25.49
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 21 Oct 2022 02:25:49 -0700 (PDT)
Date: Fri, 21 Oct 2022 09:25:48 +0000
From: Tanjuate Brunostar <tanjubrunostar0@gmail.com>
To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: [PATCH v4] staging: vt6655: Fix Lines should not end with a '('
Message-ID:
<Y1JlnJ/UpBgm9XEC@elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,
FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1747289606499429442?=
X-GMAIL-MSGID: =?utf-8?q?1747289606499429442?=
|
| Series |
[v4] staging: vt6655: Fix Lines should not end with a '('
|
|
Commit Message
Tanjuate Brunostar
Oct. 21, 2022, 9:25 a.m. UTC
Code style warnings reported by checkpatch.
Improve the layout of a function header:
Put the first parameter immediately after the '(' and align the other
parameters underneath it.
Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@gmail.com>
---
v2: put static and void on the same line and adjusted the indentation as
suggested by Greg KH
---
v3: Reformat the code by inserting tabs and white space as recommended
by Nam Cao and Julia Lawall
---
v4: final version of this patch
drivers/staging/vt6655/rxtx.c | 78 +++++++++++++++--------------------
1 file changed, 33 insertions(+), 45 deletions(-)
Comments
On 21-10-2022 14:55, Tanjuate Brunostar wrote: > Code style warnings reported by checkpatch. > Improve the layout of a function header: > Put the first parameter immediately after the '(' and align the other > parameters underneath it. > > Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@gmail.com> > > --- > v2: put static and void on the same line and adjusted the indentation as > suggested by Greg KH > --- > v3: Reformat the code by inserting tabs and white space as recommended > by Nam Cao and Julia Lawall > --- > v4: final version of this patch > > drivers/staging/vt6655/rxtx.c | 78 +++++++++++++++-------------------- > 1 file changed, 33 insertions(+), 45 deletions(-) > > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c > index 5bdb5176772c..1e5036121665 100644 > --- a/drivers/staging/vt6655/rxtx.c > +++ b/drivers/staging/vt6655/rxtx.c > @@ -85,35 +85,27 @@ static const unsigned short wFB_Opt1[2][5] = { > #define DATADUR_A_F1 13 > > /*--------------------- Static Functions --------------------------*/ > -static > -void > -s_vFillRTSHead( > - struct vnt_private *pDevice, > - unsigned char byPktType, > - void *pvRTS, > - unsigned int cbFrameLength, > - bool bNeedAck, > - bool bDisCRC, > - struct ieee80211_hdr *hdr, > - unsigned short wCurrentRate, > - unsigned char byFBOption > -); > - > -static > -void > -s_vGenerateTxParameter( > - struct vnt_private *pDevice, > - unsigned char byPktType, > - struct vnt_tx_fifo_head *, > - void *pvRrvTime, > - void *pvRTS, > - void *pvCTS, > - unsigned int cbFrameSize, > - bool bNeedACK, > - unsigned int uDMAIdx, > - void *psEthHeader, > - unsigned short wCurrentRate > -); > +static void s_vFillRTSHead(struct vnt_private *pDevice, > + unsigned char byPktType, > + void *pvRTS, > + unsigned int cbFrameLength, > + bool bNeedAck, > + bool bDisCRC, > + struct ieee80211_hdr *hdr, > + unsigned short wCurrentRate, > + unsigned char byFBOption); > + > +static void s_vGenerateTxParameter(struct vnt_private *pDevice, > + unsigned char byPktType, > + struct vnt_tx_fifo_head *, > + void *pvRrvTime, > + void *pvRTS, > + void *pvCTS, > + unsigned int cbFrameSize, > + bool bNeedACK, > + unsigned int uDMAIdx, > + void *psEthHeader, > + unsigned short wCurrentRate); > > static unsigned int > s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType, > @@ -121,22 +113,18 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType, > unsigned int uDMAIdx, struct vnt_tx_desc *pHeadTD, > unsigned int uNodeIndex); > > -static > -__le16 > -s_uFillDataHead( > - struct vnt_private *pDevice, > - unsigned char byPktType, > - void *pTxDataHead, > - unsigned int cbFrameLength, > - unsigned int uDMAIdx, > - bool bNeedAck, > - unsigned int uFragIdx, > - unsigned int cbLastFragmentSize, > - unsigned int uMACfragNum, > - unsigned char byFBOption, > - unsigned short wCurrentRate, > - bool is_pspoll > -); > +static __le16 s_uFillDataHead(struct vnt_private *pDevice, > + unsigned char byPktType, > + void *pTxDataHead, > + unsigned int cbFrameLength, > + unsigned int uDMAIdx, > + bool bNeedAck, > + unsigned int uFragIdx, > + unsigned int cbLastFragmentSize, > + unsigned int uMACfragNum, > + unsigned char byFBOption, > + unsigned short wCurrentRate, > + bool is_pspoll); > > /*--------------------- Export Variables --------------------------*/ > Can we also work upon the naming convention from pDevice -> p_device and other places if that make sense here. Regards, ~Praveen.
On 10/21/22 11:25, Tanjuate Brunostar wrote: > Code style warnings reported by checkpatch. > Improve the layout of a function header: > Put the first parameter immediately after the '(' and align the other > parameters underneath it. > > Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@gmail.com> > > --- > v2: put static and void on the same line and adjusted the indentation as > suggested by Greg KH > --- > v3: Reformat the code by inserting tabs and white space as recommended > by Nam Cao and Julia Lawall > --- > v4: final version of this patch > > drivers/staging/vt6655/rxtx.c | 78 +++++++++++++++-------------------- > 1 file changed, 33 insertions(+), 45 deletions(-) > > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c > index 5bdb5176772c..1e5036121665 100644 > --- a/drivers/staging/vt6655/rxtx.c > +++ b/drivers/staging/vt6655/rxtx.c > @@ -85,35 +85,27 @@ static const unsigned short wFB_Opt1[2][5] = { > #define DATADUR_A_F1 13 > > /*--------------------- Static Functions --------------------------*/ > -static > -void > -s_vFillRTSHead( > - struct vnt_private *pDevice, > - unsigned char byPktType, > - void *pvRTS, > - unsigned int cbFrameLength, > - bool bNeedAck, > - bool bDisCRC, > - struct ieee80211_hdr *hdr, > - unsigned short wCurrentRate, > - unsigned char byFBOption > -); > - > -static > -void > -s_vGenerateTxParameter( > - struct vnt_private *pDevice, > - unsigned char byPktType, > - struct vnt_tx_fifo_head *, > - void *pvRrvTime, > - void *pvRTS, > - void *pvCTS, > - unsigned int cbFrameSize, > - bool bNeedACK, > - unsigned int uDMAIdx, > - void *psEthHeader, > - unsigned short wCurrentRate > -); > +static void s_vFillRTSHead(struct vnt_private *pDevice, > + unsigned char byPktType, > + void *pvRTS, > + unsigned int cbFrameLength, > + bool bNeedAck, > + bool bDisCRC, > + struct ieee80211_hdr *hdr, > + unsigned short wCurrentRate, > + unsigned char byFBOption); > + > +static void s_vGenerateTxParameter(struct vnt_private *pDevice, > + unsigned char byPktType, > + struct vnt_tx_fifo_head *, > + void *pvRrvTime, > + void *pvRTS, > + void *pvCTS, > + unsigned int cbFrameSize, > + bool bNeedACK, > + unsigned int uDMAIdx, > + void *psEthHeader, > + unsigned short wCurrentRate); > > static unsigned int > s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType, > @@ -121,22 +113,18 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType, > unsigned int uDMAIdx, struct vnt_tx_desc *pHeadTD, > unsigned int uNodeIndex); > > -static > -__le16 > -s_uFillDataHead( > - struct vnt_private *pDevice, > - unsigned char byPktType, > - void *pTxDataHead, > - unsigned int cbFrameLength, > - unsigned int uDMAIdx, > - bool bNeedAck, > - unsigned int uFragIdx, > - unsigned int cbLastFragmentSize, > - unsigned int uMACfragNum, > - unsigned char byFBOption, > - unsigned short wCurrentRate, > - bool is_pspoll > -); > +static __le16 s_uFillDataHead(struct vnt_private *pDevice, > + unsigned char byPktType, > + void *pTxDataHead, > + unsigned int cbFrameLength, > + unsigned int uDMAIdx, > + bool bNeedAck, > + unsigned int uFragIdx, > + unsigned int cbLastFragmentSize, > + unsigned int uMACfragNum, > + unsigned char byFBOption, > + unsigned short wCurrentRate, > + bool is_pspoll); > > /*--------------------- Export Variables --------------------------*/ > Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
On Fri, Oct 21, 2022 at 11:49 AM Praveen Kumar <kumarpraveen@linux.microsoft.com> wrote: > > On 21-10-2022 14:55, Tanjuate Brunostar wrote: > > Code style warnings reported by checkpatch. > > Improve the layout of a function header: > > Put the first parameter immediately after the '(' and align the other > > parameters underneath it. > > > > Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@gmail.com> > > > > --- > > v2: put static and void on the same line and adjusted the indentation as > > suggested by Greg KH > > --- > > v3: Reformat the code by inserting tabs and white space as recommended > > by Nam Cao and Julia Lawall > > --- > > v4: final version of this patch > > > > drivers/staging/vt6655/rxtx.c | 78 +++++++++++++++-------------------- > > 1 file changed, 33 insertions(+), 45 deletions(-) > > > > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c > > index 5bdb5176772c..1e5036121665 100644 > > --- a/drivers/staging/vt6655/rxtx.c > > +++ b/drivers/staging/vt6655/rxtx.c > > @@ -85,35 +85,27 @@ static const unsigned short wFB_Opt1[2][5] = { > > #define DATADUR_A_F1 13 > > > > /*--------------------- Static Functions --------------------------*/ > > -static > > -void > > -s_vFillRTSHead( > > - struct vnt_private *pDevice, > > - unsigned char byPktType, > > - void *pvRTS, > > - unsigned int cbFrameLength, > > - bool bNeedAck, > > - bool bDisCRC, > > - struct ieee80211_hdr *hdr, > > - unsigned short wCurrentRate, > > - unsigned char byFBOption > > -); > > - > > -static > > -void > > -s_vGenerateTxParameter( > > - struct vnt_private *pDevice, > > - unsigned char byPktType, > > - struct vnt_tx_fifo_head *, > > - void *pvRrvTime, > > - void *pvRTS, > > - void *pvCTS, > > - unsigned int cbFrameSize, > > - bool bNeedACK, > > - unsigned int uDMAIdx, > > - void *psEthHeader, > > - unsigned short wCurrentRate > > -); > > +static void s_vFillRTSHead(struct vnt_private *pDevice, > > + unsigned char byPktType, > > + void *pvRTS, > > + unsigned int cbFrameLength, > > + bool bNeedAck, > > + bool bDisCRC, > > + struct ieee80211_hdr *hdr, > > + unsigned short wCurrentRate, > > + unsigned char byFBOption); > > + > > +static void s_vGenerateTxParameter(struct vnt_private *pDevice, > > + unsigned char byPktType, > > + struct vnt_tx_fifo_head *, > > + void *pvRrvTime, > > + void *pvRTS, > > + void *pvCTS, > > + unsigned int cbFrameSize, > > + bool bNeedACK, > > + unsigned int uDMAIdx, > > + void *psEthHeader, > > + unsigned short wCurrentRate); > > > > static unsigned int > > s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType, > > @@ -121,22 +113,18 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType, > > unsigned int uDMAIdx, struct vnt_tx_desc *pHeadTD, > > unsigned int uNodeIndex); > > > > -static > > -__le16 > > -s_uFillDataHead( > > - struct vnt_private *pDevice, > > - unsigned char byPktType, > > - void *pTxDataHead, > > - unsigned int cbFrameLength, > > - unsigned int uDMAIdx, > > - bool bNeedAck, > > - unsigned int uFragIdx, > > - unsigned int cbLastFragmentSize, > > - unsigned int uMACfragNum, > > - unsigned char byFBOption, > > - unsigned short wCurrentRate, > > - bool is_pspoll > > -); > > +static __le16 s_uFillDataHead(struct vnt_private *pDevice, > > + unsigned char byPktType, > > + void *pTxDataHead, > > + unsigned int cbFrameLength, > > + unsigned int uDMAIdx, > > + bool bNeedAck, > > + unsigned int uFragIdx, > > + unsigned int cbLastFragmentSize, > > + unsigned int uMACfragNum, > > + unsigned char byFBOption, > > + unsigned short wCurrentRate, > > + bool is_pspoll); > > > > /*--------------------- Export Variables --------------------------*/ > > > > Can we also work upon the naming convention from pDevice -> p_device and other places if that make sense here. > > Regards, > > ~Praveen. > I intend to do this as a separate patch
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 5bdb5176772c..1e5036121665 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -85,35 +85,27 @@ static const unsigned short wFB_Opt1[2][5] = { #define DATADUR_A_F1 13 /*--------------------- Static Functions --------------------------*/ -static -void -s_vFillRTSHead( - struct vnt_private *pDevice, - unsigned char byPktType, - void *pvRTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - struct ieee80211_hdr *hdr, - unsigned short wCurrentRate, - unsigned char byFBOption -); - -static -void -s_vGenerateTxParameter( - struct vnt_private *pDevice, - unsigned char byPktType, - struct vnt_tx_fifo_head *, - void *pvRrvTime, - void *pvRTS, - void *pvCTS, - unsigned int cbFrameSize, - bool bNeedACK, - unsigned int uDMAIdx, - void *psEthHeader, - unsigned short wCurrentRate -); +static void s_vFillRTSHead(struct vnt_private *pDevice, + unsigned char byPktType, + void *pvRTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + struct ieee80211_hdr *hdr, + unsigned short wCurrentRate, + unsigned char byFBOption); + +static void s_vGenerateTxParameter(struct vnt_private *pDevice, + unsigned char byPktType, + struct vnt_tx_fifo_head *, + void *pvRrvTime, + void *pvRTS, + void *pvCTS, + unsigned int cbFrameSize, + bool bNeedACK, + unsigned int uDMAIdx, + void *psEthHeader, + unsigned short wCurrentRate); static unsigned int s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType, @@ -121,22 +113,18 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType, unsigned int uDMAIdx, struct vnt_tx_desc *pHeadTD, unsigned int uNodeIndex); -static -__le16 -s_uFillDataHead( - struct vnt_private *pDevice, - unsigned char byPktType, - void *pTxDataHead, - unsigned int cbFrameLength, - unsigned int uDMAIdx, - bool bNeedAck, - unsigned int uFragIdx, - unsigned int cbLastFragmentSize, - unsigned int uMACfragNum, - unsigned char byFBOption, - unsigned short wCurrentRate, - bool is_pspoll -); +static __le16 s_uFillDataHead(struct vnt_private *pDevice, + unsigned char byPktType, + void *pTxDataHead, + unsigned int cbFrameLength, + unsigned int uDMAIdx, + bool bNeedAck, + unsigned int uFragIdx, + unsigned int cbLastFragmentSize, + unsigned int uMACfragNum, + unsigned char byFBOption, + unsigned short wCurrentRate, + bool is_pspoll); /*--------------------- Export Variables --------------------------*/