From patchwork Thu Oct 20 17:20:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 6305 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp231619wrr; Thu, 20 Oct 2022 10:24:52 -0700 (PDT) X-Google-Smtp-Source: AMsMyM74xkZzY+fo3xdKS7YAMzxFOWuZ3qFaR57LD5jq/KqRr7C1QTsq3XW1mvwH9s32AljuT37L X-Received: by 2002:a05:6402:440f:b0:45d:297b:c70a with SMTP id y15-20020a056402440f00b0045d297bc70amr13434943eda.187.1666286692322; Thu, 20 Oct 2022 10:24:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666286692; cv=none; d=google.com; s=arc-20160816; b=qw63arCjj9VU9Mbn87tGjTLy7jMY6Jv52XDWDMiOwK5IE37NB6MGi7lQr+LfFlB5Uz K5mf2Vs7bhQXwH08OdG3scgz09Sheys4IFuIt4bO+HpUP1MA2Q+0syPa6vHL/ZKcAGEy 2HXWebwIZ/CbHnsoGJGeDJ64ZhA0jErWcfZPsXOUHdhB3Yn8JlLhSXsBCyTrM1yTgsIS R+QEEE5IsLqxrebFk8eaYI2IONE77/UeEuZyEikK/Fwyb0MUci6++wjGf2uyfNl9YjG+ N/oDBiNNbCAkHK6ix8pkZ/Gn7KY/g9HTxNvi94dZgKey8a4ZzJWjeanK/kyEtbVCU5sr daNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:to:from:date:dkim-signature; bh=GeL/jsE0cOlHsOp7RCLPq5AF+Z6iajFprQ67d75ZHRY=; b=TQ+AVd3ioo2FyirvEb7qUjjIrYGSL8/8BYnY4PcSyy06bmgMfxl+xWfKpnwWPVjYEY Af2FMlGtvRXNeaP5TdHdSZEOI1g8qa2c6WK2Hn45UL+dqWJhcNM0NX/9DmmpYOsEu2Kt 9bBzer98UcIg4GDCwT3Wb6NRbM/Gn4zKcXX74zLgGvPu0bvn6A0o6HAjdLpWKwnaO/6Y DkALoXQVWPdo+Pne/0Fjo2DHnqVOYDuHgv5GWDy1WJJhMgFUjyVQJMvDyaoCqwGs5e/e LozWMU44tSkFcnIMgOqBFyhq0R9MFwxYYUMaKh71bnm8C5PVkDBONUZ0t4+DvmCZdcPS QCLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b="FbODB1m/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e5-20020a170906844500b00783757c8e5esi14489965ejy.931.2022.10.20.10.24.27; Thu, 20 Oct 2022 10:24:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b="FbODB1m/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229494AbiJTRUV (ORCPT + 99 others); Thu, 20 Oct 2022 13:20:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbiJTRUS (ORCPT ); Thu, 20 Oct 2022 13:20:18 -0400 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59396FAE6E for ; Thu, 20 Oct 2022 10:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666286405; bh=y6f5yuwFB+7dnXtKXxkno+O53LHKdZ313hR7lgO+0+8=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:MIME-Version: Content-Type; b=FbODB1m/snmKR53dyym2wqd6Gay0C6rLOo+K86CJCJCk4Xf+yEhg3vnvY5bJbwB2v 3hHER9fH5oznV88TxzD99EsxH9V0wMjFE47PIWRQi3oKZ8xEjno9fOZReDSNEvYkGA dpDOraP8vkHzshmUcQ4jnOWV84Y3L0twWyK0YT00= Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP via [213.182.55.206] Thu, 20 Oct 2022 19:20:04 +0200 (CEST) X-EA-Auth: wpa2NRXTxRpbcD6NcHXdGUXpqYLgRLwpFui68DnSAbKr31OTGDY/COyXD9aKaffAbelAvE0GWuk1GAAiWY9OcUfuTBr7wkDw Date: Thu, 20 Oct 2022 22:50:00 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kumarpraveen@linux.microsoft.com, saurabh.truth@gmail.com Subject: [PATCH v5] staging: most: dim2: correct misleading struct type name Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747228234405171385?= X-GMAIL-MSGID: =?utf-8?q?1747228234405171385?= Correct the misleading struct type name dim_ch_state_t to dim_ch_state since this not a typedef but a normal structure declaration. Suggested-by: Julia Lawall Signed-off-by: Deepak R Varma --- Changes in v5: This patch was part of a patch set earlier. Since the only other patch of the set is to be handled separately, the patch set is no more applicable. Hence this now becomes a standalone patch in v5. Feedback from gregkh@linuxfoundation.org Changes in v4: 1. Correct patch subject and log message. Use struct type name instead of variable name for the change description. Feedback from julia.lawall@inria.fr Changes in v3: 1. Patch introduced in the patch set drivers/staging/most/dim2/dim2.c | 4 ++-- drivers/staging/most/dim2/hal.c | 4 ++-- drivers/staging/most/dim2/hal.h | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) -- 2.30.2 diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c index ab72e11ac5ab..5547b69b31a4 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -161,7 +161,7 @@ static int try_start_dim_transfer(struct hdm_channel *hdm_ch) struct list_head *head = &hdm_ch->pending_list; struct mbo *mbo; unsigned long flags; - struct dim_ch_state_t st; + struct dim_ch_state st; BUG_ON(!hdm_ch); BUG_ON(!hdm_ch->is_initialized); @@ -259,7 +259,7 @@ static void retrieve_netinfo(struct dim2_hdm *dev, struct mbo *mbo) static void service_done_flag(struct dim2_hdm *dev, int ch_idx) { struct hdm_channel *hdm_ch = dev->hch + ch_idx; - struct dim_ch_state_t st; + struct dim_ch_state st; struct list_head *head; struct mbo *mbo; int done_buffers; diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c index 65282c276862..a5d40b5b138a 100644 --- a/drivers/staging/most/dim2/hal.c +++ b/drivers/staging/most/dim2/hal.c @@ -943,8 +943,8 @@ u8 dim_service_channel(struct dim_channel *ch) return channel_service(ch); } -struct dim_ch_state_t *dim_get_channel_state(struct dim_channel *ch, - struct dim_ch_state_t *state_ptr) +struct dim_ch_state *dim_get_channel_state(struct dim_channel *ch, + struct dim_ch_state *state_ptr) { if (!ch || !state_ptr) return NULL; diff --git a/drivers/staging/most/dim2/hal.h b/drivers/staging/most/dim2/hal.h index 20531449acab..ef10a8741c10 100644 --- a/drivers/staging/most/dim2/hal.h +++ b/drivers/staging/most/dim2/hal.h @@ -27,7 +27,7 @@ enum mlb_clk_speed { CLK_8192FS = 7, }; -struct dim_ch_state_t { +struct dim_ch_state { bool ready; /* Shows readiness to enqueue next buffer */ u16 done_buffers; /* Number of completed buffers */ }; @@ -87,8 +87,8 @@ void dim_service_ahb_int_irq(struct dim_channel *const *channels); u8 dim_service_channel(struct dim_channel *ch); -struct dim_ch_state_t *dim_get_channel_state(struct dim_channel *ch, - struct dim_ch_state_t *state_ptr); +struct dim_ch_state *dim_get_channel_state(struct dim_channel *ch, + struct dim_ch_state *state_ptr); u16 dim_dbr_space(struct dim_channel *ch);