From patchwork Thu Feb 23 22:10:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan McDowell X-Patchwork-Id: 61090 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp575762wrd; Thu, 23 Feb 2023 14:49:50 -0800 (PST) X-Google-Smtp-Source: AK7set8MsB4SGZMAs55aOxU4X1xFwTmXBPCFevpq36D/e+BFG7JAEVBFMCMzjfkppRPFq0wIQ3N0 X-Received: by 2002:a05:6402:11c6:b0:4af:593c:c07f with SMTP id j6-20020a05640211c600b004af593cc07fmr12428271edw.3.1677192590632; Thu, 23 Feb 2023 14:49:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677192590; cv=none; d=google.com; s=arc-20160816; b=U3kKwSFyj8zFIbwWCQDm85jTb6GmBiWeOZiuYt2pqL/aD9TJXw5g1JsMRonbOMSTJn HYoBCKTE9cyeJRg1Dj0pLSgCEHP1VV6aQYKqUm8MdK13cxtwD/XiOQ7+hShmXPLpmrW1 tqrW7+795mn8Q5GFqJTwswfo1Wtko3Ttb32ua0TYrD2nZtKhaKtI2szittLmaNaYiQjA LnDPuxrtazQff+/FYCXZFSALDKpd4GtzJfyzFsrC7AeMjCvgekpqHfdtEMuZ2iq47sXZ AXs444BgvebnmgcjTxP8amCxh4emVJ336NfdbOXJWjG4PXC1I/Bo1dsa2YlzPDw8DgVt 7XUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=OayevMSfxq/5eX7TpSmF0QlP82H2HgfsyAnEkZU+mEc=; b=oz9jEekULu9y9+oj2Rjm6LDZy08dfWLG8/VjEgNoaHhw0kIvAjwAO4pxRJo2i5CY/+ EXBwIRnBbipzbcEsqSdGfvODyEmT5aKqH0F59dHG0DApeo6GgcPRnir0OeNOK2XtouNU xRc/ALP2heW8t+4SCyRsKrpKb5+JraDIT2b+IxRpkMPsqkOG0LgBi4tYVB7E2zGtI5By nwPh/OFKvQt3rY+gxEp0cVgmiwwHvJpuVEH2zj2fKt/hC5YkKXdf/iT6m03OT+T1bE/d SL+tgB/xY5iWFDQ461CpOJhvuw5mdHzV5qWOJzvNjQUxG/5sqfYNCp+MJQLvqP3526/7 2Hyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@earth.li header.s=the header.b=S4GmgWq5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v23-20020aa7cd57000000b004a235a340ebsi5270561edw.163.2023.02.23.14.49.27; Thu, 23 Feb 2023 14:49:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@earth.li header.s=the header.b=S4GmgWq5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbjBWWoH (ORCPT + 99 others); Thu, 23 Feb 2023 17:44:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbjBWWnv (ORCPT ); Thu, 23 Feb 2023 17:43:51 -0500 Received: from the.earth.li (the.earth.li [IPv6:2a00:1098:86:4d:c0ff:ee:15:900d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B38C729E04; Thu, 23 Feb 2023 14:43:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=earth.li; s=the; h=Content-Type:MIME-Version:Message-ID:Subject:Cc:To:From:Date:Sender: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=OayevMSfxq/5eX7TpSmF0QlP82H2HgfsyAnEkZU+mEc=; b=S 4GmgWq5qCgQofTIzv22+JjJsXXugKSV9oHd74EDUz29uCCD+x27smX83w2au/Pak1aeR7oljs7Mqg 4u4BeLksHOyzJz7omYcjK9tGt/NwmuowgzSTSYrqLTA7I6Gtj0YSw+OZClJgKs27ssmY0ulZf/qSQ L8GCkGLRmutnhsg/SJAORok3iX16wiLk9N7igXf7PSEsWr0MkjW+xg70R6LkcuUkLQXB+KIFOW/Ph lkJv6kaX/1Obz+55c6SFSIG7glMurpxpU33TMAp6i89QRbi2vfQgA9ttNGIxt0Y87dnLHlABckvEu JLANLMVg9c/9pO/kAmZi4QCof0KW0M8wQ==; Received: from [2001:4d48:ad59:1403::17ca] (helo=sevai.o362.us) by the.earth.li with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pVJnR-0047pv-Ji; Thu, 23 Feb 2023 22:10:37 +0000 Date: Thu, 23 Feb 2023 22:10:33 +0000 From: Jonathan McDowell To: Antoine Tenart , Herbert Xu , "David S. Miller" Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] crypto: inside-secure: Raise firmware load failure message to error Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758663897873488695?= X-GMAIL-MSGID: =?utf-8?q?1758663897873488695?= At the moment if there is no firmware available for the safexcel driver it will fail to load with a cryptic: crypto-safexcel f2800000.crypto: TRC init: 15360d,80a (48r,256h) crypto-safexcel f2800000.crypto: HW init failed (-2) Raise the logging level of the firmware load failure to err rather than dbg so that it's obvious what the reason for the HW init failure is. Signed-off-by: Jonathan McDowell --- drivers/crypto/inside-secure/safexcel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c index 6858753af6b3..5e10ab24be3b 100644 --- a/drivers/crypto/inside-secure/safexcel.c +++ b/drivers/crypto/inside-secure/safexcel.c @@ -474,7 +474,7 @@ static int eip197_load_firmwares(struct safexcel_crypto_priv *priv) goto retry_fw; } - dev_dbg(priv->dev, "Firmware load failed.\n"); + dev_err(priv->dev, "Firmware load failed.\n"); return ret; }