From patchwork Wed Mar 1 19:58:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 63064 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3840791wrd; Wed, 1 Mar 2023 12:04:57 -0800 (PST) X-Google-Smtp-Source: AK7set9g7uoxtKgG0BU0Lo3Tv2imF9fFN7DpNI6EnAYY0ox8VLg/fWLkugH/WREdfUiMGYZITjlp X-Received: by 2002:a17:902:dac8:b0:19a:a210:825 with SMTP id q8-20020a170902dac800b0019aa2100825mr8787360plx.20.1677701096679; Wed, 01 Mar 2023 12:04:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677701096; cv=none; d=google.com; s=arc-20160816; b=UTpgaCydvAY+WnN4+yATx9f5JwXH6visq13DzWQd20Lvvuvep5Bn5vUusNTT/ljRZY cqzqowsz6OSRXsHv4npWvwDWbhwoXWH6G3FmKN2+MPvpnEvjWFiytB5O1oJ3zzVZsfLr BU0FbJEnVWWBXRFszlUrY9lHGorHZ90EhRoo10QCf368NdrDSqToheh6veMeXNz9tr5E 8bqUSdbsieM7cMu8OM2LhEVRpI4ObKgQi6mJV3rwp1GnNgvLjo3M3JaoV4+4UboxPXya HRgTdnlgKtmGeiAjHQ8A9g0X/vGUUC3Y2fTpe6FsLOAtIO11ygCK4ASSS4/6QwkirxP4 4CVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=YHfFZez6g7pN5Tpn3Tv9Xb9ULzAbCcqHpks4W72b/9s=; b=F6M4Tvz7rZpmEwcgZHQLSV7pTHgzr4+ak2WQVF93ji8uSGzcyeSYm2/syIi+EV6kbE ZnEbQLJSvFEhs7KV3V1DhteaSk4XqcyTxNDMpYlfp6x1yjoacY0oKj6comBQdPnmXvd4 7A9cSo5VaeB5aXLaTXLmF20B83JU20SDEUH0OlqwF+cjysWyFKynUdUSlzUywTfHtyWk PTd8FrKv9kzMMzJ/xbrwrodLnrVa4kywb0EUjtwZmWqDZ6/9GIaspph0zgVtF8jPs+vj ARk5Dhm+7+fgScC5HgIRJwg9+tkRQh+Rm/ACT9G8ip3tfGIbQnUGUMEv7Q0l7jBK0Vbb G4Iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=DY4M36Rw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p3-20020a1709026b8300b0019479636f8csi12113302plk.20.2023.03.01.12.04.42; Wed, 01 Mar 2023 12:04:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=DY4M36Rw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229453AbjCAT6x (ORCPT + 99 others); Wed, 1 Mar 2023 14:58:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjCAT6w (ORCPT ); Wed, 1 Mar 2023 14:58:52 -0500 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47E671BE1 for ; Wed, 1 Mar 2023 11:58:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1677700704; bh=VAuRPN7+KGTNR1+VCFMHhxksGYKTXl+HO2HTsfXfvqM=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type; b=DY4M36RwwqKcfemZNla36rdJ51NQMusT5P9slKXJawwaQr+C1iFOGLrkeHiUVY0EI SpA/DuBFLGFVTT+EhT7Vin49qSoOeB8D2PbDvpzviRdMRCUN/eio7kEdjLujcuCFa0 NvqtJIOd5YBZPKua03yl38M4klXbNeUwFRiTYiEM= Received: by b221-3.in.mailobj.net [192.168.90.23] with ESMTP via ip-20.mailobj.net [213.182.54.20] Wed, 1 Mar 2023 20:58:24 +0100 (CET) X-EA-Auth: ZT5g9yCX4u6x+3sfSSH/SrdotTfxuHXI4qIJfeKi32aEOhGPEI++CpQ9p+GzxhETdiM3h23ngSjlySbwXad8tifFL2Y7TWJw Date: Thu, 2 Mar 2023 01:28:20 +0530 From: Deepak R Varma To: Alain Volmat , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar , Deepak R Varma Subject: [PATCH RESEND] drm/sti: Avoid full proxy f_ops for sti debug attributes Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759197105055509543?= X-GMAIL-MSGID: =?utf-8?q?1759197105055509543?= Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy factory file operations structure and function wrapping at runtime. As a replacement, a combination of DEFINE_DEBUGFS_ATTRIBUTE macro paired with debugfs_create_file_unsafe() is suggested to be used instead. The DEFINE_DEBUGFS_ATTRIBUTE utilises debugfs_file_get() and debugfs_file_put() wrappers to protect the original read and write function calls for the debug attributes. There is no need for any runtime proxy file operations to be managed by the debugfs core. Following coccicheck make command helped identify this change: make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma Acked-by: Alain Volmat --- Note: Change cross compile tested using stm32_defconfig for arm Resending patch for review and feedback. Initially sent on Jan 11 2023 drivers/gpu/drm/sti/sti_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c index ef6a4e63198f..c9be82043638 100644 --- a/drivers/gpu/drm/sti/sti_drv.c +++ b/drivers/gpu/drm/sti/sti_drv.c @@ -67,8 +67,8 @@ static int sti_drm_fps_set(void *data, u64 val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(sti_drm_fps_fops, - sti_drm_fps_get, sti_drm_fps_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(sti_drm_fps_fops, + sti_drm_fps_get, sti_drm_fps_set, "%llu\n"); static int sti_drm_fps_dbg_show(struct seq_file *s, void *data) { @@ -97,8 +97,8 @@ static void sti_drm_dbg_init(struct drm_minor *minor) ARRAY_SIZE(sti_drm_dbg_list), minor->debugfs_root, minor); - debugfs_create_file("fps_show", S_IRUGO | S_IWUSR, minor->debugfs_root, - minor->dev, &sti_drm_fps_fops); + debugfs_create_file_unsafe("fps_show", S_IRUGO | S_IWUSR, minor->debugfs_root, + minor->dev, &sti_drm_fps_fops); DRM_INFO("%s: debugfs installed\n", DRIVER_NAME); }