From patchwork Mon May 15 02:36:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yahu Gao X-Patchwork-Id: 93815 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp6622648vqo; Sun, 14 May 2023 19:52:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Cj4ETsRJCsVdm0T+O2Wxpvd7ISbXXiRKWUiqTW6XSj8C4r8Iy9CACJZ/RtxBmaxa4G7vu X-Received: by 2002:a05:6a21:7891:b0:101:73a9:1680 with SMTP id bf17-20020a056a21789100b0010173a91680mr26371207pzc.8.1684119136703; Sun, 14 May 2023 19:52:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1684119136; cv=pass; d=google.com; s=arc-20160816; b=MLkpfOOR+MU5cPFzPpSihZF3ltomdSoW0/2aUuXmyrG9mMbTUsGyiPb7T2bDk5zO6P zvej/ipDhcFTm2pwJAbGmucFGcp4OjdysE5a3S4jr0Tm8cG852evfXaUI5XVIAUQCTkU rZDU5S4C8rHfga88qK17JHp8hFxleR4tviHj+zoqyGqz5j5Gtk/Z9hUsUihlAmVJbPWz Nrc3oF+X7sq1mNFEGwj1CNkoeMwf1VMUUJ1XbAJtQEpbJXazO1+Z569cm4mSal42N2d1 TfSs8vFInxpcnQE/QrjKERfQS3E04iwI/XIMUlJN2E+nxI+ifju4hly+VUxTOksV+7o+ IAkw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :message-id:date:subject:cc:to:from:dkim-signature; bh=XY59rOFlkGPlORf+kVDsYxk89suEwM7CTq/ZKpjLUTI=; b=Pkg2S1Z3Wp5LbWDjp0cF1fHn83ESzl7HtAprmLXqS0HUMwNrMFf6p1B0kBHwMGey12 JWiLUQoqWUGOs9T0f5uJW4ozBsG5a/7yBYrlBYPtQ2VyB0zVAiFFAygPBMydcTm7up+g q+GsL7Xet9HuNc0PKWxdACP0UcLMYaElMgkVQRvoTYIZhgdw3XU8CC4yIxV3jILNcrqi UP79gZBQzfrml8ov5T/C5RRhAjZh5hgVfmxdGoqHXlMCZG7OzAL39cs6Q+kMgMOBNdAb VSXOcdpSKw/DNh9oZC9ET/H7/ZKI4vlkKNYQJrGvCwo9wK36VizKDo+cGXUQFhL+zmTL bTUA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@outlook.com header.s=selector1 header.b=Ml6pmwX+; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s133-20020a632c8b000000b0052c22753de4si14889129pgs.662.2023.05.14.19.51.42; Sun, 14 May 2023 19:52:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@outlook.com header.s=selector1 header.b=Ml6pmwX+; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230281AbjEOChg (ORCPT + 99 others); Sun, 14 May 2023 22:37:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238207AbjEOChb (ORCPT ); Sun, 14 May 2023 22:37:31 -0400 Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2040.outbound.protection.outlook.com [40.92.98.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9086B8; Sun, 14 May 2023 19:37:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JW51PlF6C30GNUvps70X50UuiinTcMdNTkWNaxkxuTaA4HWS1Km00hMk3iBastiFIQH6Y/0Nwo6JE5Zoq79jOgT2SaIvvEAgIvOocUSArTsRnlF9++t66zmWCephuV1uAF5DH9IcFJvDaVy6CkQurihpyINAdxFkDn7t4ispVtvknyrdfjABJsEwacvALXnqbX0+zyKUSb3Qszs91xiEj1RItmZcdPxhVPUi7nKWzGAjStPQgYA+kAMvpAgYJRde96DcYDe37yz0vhziR/7D8LsffUGmcpkiLmrg9RTMRGIJPcXJKK56VrRkK44HgwlvpHF4Rhd66uup7LjWGB56bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XY59rOFlkGPlORf+kVDsYxk89suEwM7CTq/ZKpjLUTI=; b=aKiSxvM+zJeEbSYXYQbr2EGy/7UrCV/r4h0IXjatidLWyThQlXYjDRn6QVuV165BU/e8DsbAktwO3K6yyZEYPFVgNMQf/UYtxFuZ9Z9pxqBmu7EsctznIpKTb4K0h6XjwOhe4GpkrXtpSAtpGTVFaF+H4drwkb+1ZOJq5p7q/FZkNA1tp8IcX0hfNuQtw3Z5ffOqBDnJNCHN2D44uYoFbv2CI4o/DFBpSCfdXxPe+nNi75XexpP0a+O5W9nswsmy2LwHOGlxc/7NJVqnY9T27eG6Yn9sfftjNnZCQB4RpBtw5833WuaPdA9gkK2rCIR63Lyr38Z32KhUwK2Pou3giA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XY59rOFlkGPlORf+kVDsYxk89suEwM7CTq/ZKpjLUTI=; b=Ml6pmwX++YRv34qDQSX9zbYMqD0mkWuSj21WUjob7NNVLCFycAPLw2wY9AOxtzEDdELkERhpjxv8pKTL2JYmXsJUGFvVnXaKnkdQ05nrT7NMw+e9ODNyUOARJWKTNRPh7rU8Ni3zIoXpWsfWurzwzHFx14Zy2GPBwQz2W/XD3DI7Si7UYWXDVn/jkAyvcUnItZmUsmnACf9amfLfS+8uUbRcm93D/X2yU4aX1esgXMovFdxZa+vTvv3CZmO6FW53ThnTuykVX9XtVadt347xi+po0YIesYM9CpIc8KpknsnIv/Smg05WX+fECgV50jC9jTXhHTHXy+sDg+1PHOBWyg== Received: from OS3P286MB0632.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:d9::7) by TYTP286MB3504.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3a2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Mon, 15 May 2023 02:37:22 +0000 Received: from OS3P286MB0632.JPNP286.PROD.OUTLOOK.COM ([fe80::dc0c:66b7:19f4:48ad]) by OS3P286MB0632.JPNP286.PROD.OUTLOOK.COM ([fe80::dc0c:66b7:19f4:48ad%4]) with mapi id 15.20.6387.030; Mon, 15 May 2023 02:37:22 +0000 From: Yahu Gao To: dlemoal@kernel.org Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Yahu Gao Subject: [PATCH v3] ata: libata-core: Simplies if condition Date: Mon, 15 May 2023 10:36:58 +0800 Message-ID: X-Mailer: git-send-email 2.39.1 X-TMN: [9PpA/4siy5S5idJJdg1OegB6vLhRltQ7] X-ClientProxiedBy: SG2PR01CA0167.apcprd01.prod.exchangelabs.com (2603:1096:4:28::23) To OS3P286MB0632.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:d9::7) X-Microsoft-Original-Message-ID: <20230515023658.37239-1-yahu.gao@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3P286MB0632:EE_|TYTP286MB3504:EE_ X-MS-Office365-Filtering-Correlation-Id: 82f29d1f-1a28-4509-6bbf-08db54ed4f5f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LU0Qt1J2ehYXT9gVczmWySeYf7GiuTBE21MurZiXKIjZtbg3D2ZS3fzEJGb+Tfc24ts/0Q/oMSrjwCWsjKAnIjhAKPzzpRMcSnVovWKw4IF61WY9yFkx1tQYUcKDZeYQ7zHMhSYI5KFsIqWzG7U+SN/Nz0tWy08lggSi2p762rwfHl+mCur1NtLhxc4V+CWnDkXZ0sSqCaE+i2S+Sw1/hT5O6kO8IOkL2wsyp3C+XYBJjVqe3T91nBWX5nfNgYC9O0Bbtc6ae1KfGgCl1+fSdCOv2sLFelLDppMpxxT/lf8kPj1NS1BI3QEjg9y1RJzIOiPlqZlTNaauq17CYfOeSIhhmzVxO1JL54u5oSzBxT8kyo5g+hDNln0npiEqslNu+Q7iF/YKGrdDdoNimfjVdPi+ZefTIzoeWGe4l6Y2LDilGuojeiIlhF889laRuD4zvNWH8+qZ6hYRosMyzKl3ss0G0RXRxSy3X91jFr+gOlXq/G8Lt7O6z/kEzV0BDQeiUKkQCRkuoVMBB0SbvI+7x4pDDATsi+kHWh/Fd+KTangjA6pxMyxPuk/Ykvpi5O5n X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: GuMLHOYwMREY5sxTR8gKJATxy1iEXxxfAiCpDItqaP8+mu02Sl1siEGbpnwcZNtRIpnATuCl0bzXz7RuxAmi9VGreAYRkFG037nxmpj6Q6d4YOlUlE3ho8qN0/WcOI+egoC1L3xdhU05Z77DVb8jgT7wTIhBC7S8xXyELQuUnOpQjakjzecrnyZk68kaKVbFtdxlIfs2jUwsZ+iFEGYbxs23ga9h92Rp3EgDVFEZhwR+fU5RQ0XHC7hn6VVg7zKxYsTszeXzceemAXWeNR5xggD4plYNXHsRQ6csIL4DQkRe8SKOMcEovuhc29XY7e58ZNCA1n+ln1OC6/x1TeuLV2w5d0STATs9nT4ma2taN1adi8sA50c9G90Yn5uXpcbHGEexF4J7u7MQvzSQGEx1QlL0Gy6MDHOIx8Q/GOBvHjhxPSv9DihTsR/6poIs0E583T+9F0cOZ7Hnvq+5G5cTZM3FsaTRTHl5oCY3wM6+JKSt28DAvEwctgmU9uTNFNZxBkMpnxxl3GSlFFuDRuvunwRFvX0Pk4QlWTJ9JjUSW5jiEI2dFD2olCDOhJ8CyZSY4ApqsEAhbrvqH+aEwVvg8QBt7jcww3lHq7uQhLlFZ1GCNN8xWUpDHbpDpe5dXVOi623yAYxduWRLehJP++P6rQExYVbtH3EM5pGXwikP69kwGohLXmqhi5w3aQL9Kc0PaZxqFfJOOKnHP+anInmcOyn48uS8a7yH+0fL8uI0iUSTWX6GCM6q8laE9eDhhey2wOdT5GhGWwVeZxQr2pyF88KAD3+rq02eMSaklWH1RhB9yCHoyfkJkboKQW1fu9pJ7ylGmHUFtW3U/BI71JdoS647fy/EtTKMJKyTxlqExidXwwjeK21Cnz0LbRpHitLo4yDy5rDlJZ4fofGgbaaj+Z/ZsfS60JlMCik67m7aBuztFNQRntUKR+v/ml2gReW10RTH9HtPGsEPqk4w3iZ2H+PQyZQs/ULRIWDe9y171wIY+fN+cBKxqmXLHGM9H8V8xvh8SqeIQ6/uSTnWeU9lggnr3LKwk46VoidwQc4APZjZgv0A+Us4Icz3yQTluqOyALeZ1xmUjgtugB4CB4kJSqgSoLt5k9Xa0BucMU8A64n8xjTvD1CozkSr49eS0VgsBTeAIFVN9rmFpJUppSQFrZTJta47SqnkKYIlH8JYAsoRneIDiovQE4lm/KvR602qSlP0fWf/7Tge5Yn9zUTw3Q== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82f29d1f-1a28-4509-6bbf-08db54ed4f5f X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB0632.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2023 02:37:22.3527 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYTP286MB3504 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765926907436288920?= X-GMAIL-MSGID: =?utf-8?q?1765926907436288920?= From: Yahu Gao Simplify the condition used in ata_dev_revalidate() to not issue identify commands to port multiplier devices. Signed-off-by: Yahu Gao --- drivers/ata/libata-core.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) Changes since V1: 1. Update the subject 2. Add more descriptive 3. Remove review-by without email 4. keep "ata_class_enabled(new_class) &&" condition diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 14c17c3bda4e..2c9472b00f17 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -3802,11 +3802,7 @@ int ata_dev_revalidate(struct ata_device *dev, unsigned int new_class, return -ENODEV; /* fail early if !ATA && !ATAPI to avoid issuing [P]IDENTIFY to PMP */ - if (ata_class_enabled(new_class) && - new_class != ATA_DEV_ATA && - new_class != ATA_DEV_ATAPI && - new_class != ATA_DEV_ZAC && - new_class != ATA_DEV_SEMB) { + if (ata_class_enabled(new_class) && new_class == ATA_DEV_PMP) { ata_dev_info(dev, "class mismatch %u != %u\n", dev->class, new_class); rc = -ENODEV;