Message ID | E1pYOKD-000GYe-HX@formenos.hmeau.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp857619wrd; Sat, 4 Mar 2023 02:08:36 -0800 (PST) X-Google-Smtp-Source: AK7set+A9wfqkXhBoDqP9fyXJ25BAcwDe2KYqQdaUknaKhgtsAKO76QVLpC3TyvAxr+Uy+w2T1Wy X-Received: by 2002:a17:902:cec1:b0:19c:a86d:b34e with SMTP id d1-20020a170902cec100b0019ca86db34emr6153095plg.4.1677924516685; Sat, 04 Mar 2023 02:08:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677924516; cv=none; d=google.com; s=arc-20160816; b=OivBMIKYkMXm5JDR5Vx1d9D//f3Sokzh1r7FmbOM4qi3gkse6EakJuEaxoNjLtpe1N 4uX0qWvIe2+N/dog0MC67pWuCZb9GlYx8C5dda61dDj35k/1RTxh00Biocr2FW50n5cg kJQtmD9tQAVHqCbJ1FTQZt9Fz3R9zYlniqoqLh4nyWUAFElKRoSyQ8wDWbgnhpGtBZ1L HwR/AZ/b5AD84t/CMlmp6/snf7ttzDaLa6m+EiU9wzi8c1Nxn328bJL6YsRNgk9tjF7u ZpbKx3JATIJw6HAI/TgLdMFyoD4ZlKItEkbjGh7miDxYgEyyx/hiA2JBycHfLv4zEfS/ 1vKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:to:references:subject:date:from; bh=P+JG/92ObhsF2nBY8X79/wmwvl2kYUoL8Q7g3NiTKAs=; b=kw4ULLHrBnQBQb5/XcvwdWnhS64L8RjutI6bSUysvcdK9BRDebp8QcEOvyU3aJylp4 fZmbU19xw9SfugLMPeD9rn7dk1jGFX0bEzIR5bx0ppA/6HG127UCABbsGOPBPfLdzxf0 6IWpwN5jQUI6ewFpkk5ZhjEXRZ2Uvm88cqvG1/CeFE9k5Uilukw3lbb23JgeJaVbrC/b jciSY532qkw4tZ8GEu2Utpu/VWLEo58ECP7FonZcG2WTzi3FCj9MyILt9N08OryUSjQf yV/rsHLdYwb0nFv2RNFqnLc/7WPv5kyYLqay9h/Kr9RLsDyUvQj/BxEfN3G3qfYXGdFr WMlg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u1-20020a17090282c100b0019905ccbcc1si4422026plz.317.2023.03.04.02.08.20; Sat, 04 Mar 2023 02:08:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229512AbjCDJha (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Sat, 4 Mar 2023 04:37:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjCDJh3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 4 Mar 2023 04:37:29 -0500 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E35E4B477; Sat, 4 Mar 2023 01:37:27 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1pYOKD-000GYe-HX; Sat, 04 Mar 2023 17:37:10 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Sat, 04 Mar 2023 17:37:09 +0800 From: "Herbert Xu" <herbert@gondor.apana.org.au> Date: Sat, 04 Mar 2023 17:37:09 +0800 Subject: [v5 PATCH 1/7] crypto: stm32 - Save 54 CSR registers References: <ZAMQjOdi8GfqDUQI@gondor.apana.org.au> To: Linus Walleij <linus.walleij@linaro.org>, Lionel Debieve <lionel.debieve@foss.st.com>, Li kunyu <kunyu@nfschina.com>, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mcoquelin.stm32@gmail.com Message-Id: <E1pYOKD-000GYe-HX@formenos.hmeau.com> X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_00,HELO_DYNAMIC_IPADDR2, PDS_RDNS_DYNAMIC_FP,RDNS_DYNAMIC,SPF_HELO_NONE,SPF_PASS,TVD_RCVD_IP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759431378046830292?= X-GMAIL-MSGID: =?utf-8?q?1759431378046830292?= |
Series |
crypto: stm32 - Save and restore between each request
|
|
Commit Message
Herbert Xu
March 4, 2023, 9:37 a.m. UTC
The CSR registers go from 0 to 53. So the number of registers
should be 54.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---
drivers/crypto/stm32/stm32-hash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Sat, Mar 4, 2023 at 10:37 AM Herbert Xu <herbert@gondor.apana.org.au> wrote: > The CSR registers go from 0 to 53. So the number of registers > should be 54. > > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Hm I don't know where this misunderstanding comes from. I think it's this tendency by some engineers to use index 1 :/ The datasheet for U8500 says: 0xF8 HASH_CSFULL HASH context full register 0xFC HASH_CSDATAIN HASH context swap data input register 0x100 HASH_CSR0 HASH context swap register 0 0x104 to 0x1CC HASH_CSR1 to 51 HASH context swap register 1 to 51 0xf8, 0xfc, 0x100 = 3 registers 0x104 to 0x1cc = 51 registers Indeed 54. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Tested-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c index 7bf805563ac2..bde2b40a6a32 100644 --- a/drivers/crypto/stm32/stm32-hash.c +++ b/drivers/crypto/stm32/stm32-hash.c @@ -68,7 +68,7 @@ #define HASH_MASK_DATA_INPUT BIT(1) /* Context swap register */ -#define HASH_CSR_REGISTER_NUMBER 53 +#define HASH_CSR_REGISTER_NUMBER 54 /* Status Flags */ #define HASH_SR_DATA_INPUT_READY BIT(0)