diff mbox series

[RESEND] cred: Use KMEM_CACHE instead of kmem_cache_create

Message ID CY8PR11MB77794B8F64015E2D2D606CE097552@CY8PR11MB7779.namprd11.prod.outlook.com
State New
Headers
Series [RESEND] cred: Use KMEM_CACHE instead of kmem_cache_create |

Commit Message

Kunwu Chan Feb. 23, 2024, 10:16 a.m. UTC 
  From: Kunwu Chan <chentao@kylinos.cn>

commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
introduces a new macro.
Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
to simplify the creation of SLAB caches.

Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
---

Notes:
    I'am Kunwu.Chan, the problem(https://lore.kernel.org/all/CAHC9VhTJXfPztz2W_V6sp41PJW8dzvZH0YdnRXd7tUZOF1Q09Q@mail.gmail.com/) may be caused by my email server.
    I change the email and send it to myself, the raw email seems ok.
    So i resend it.

 kernel/cred.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Paul Moore Feb. 23, 2024, 10:38 p.m. UTC | #1 
On Fri, Feb 23, 2024 at 5:16 AM Kunwu Chan <kunwu.chan@hotmail.com> wrote:
>
> From: Kunwu Chan <chentao@kylinos.cn>
>
> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
> introduces a new macro.
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> ---
>
> Notes:
>     I'am Kunwu.Chan, the problem(https://lore.kernel.org/all/CAHC9VhTJXfPztz2W_V6sp41PJW8dzvZH0YdnRXd7tUZOF1Q09Q@mail.gmail.com/) may be caused by my email server.
>     I change the email and send it to myself, the raw email seems ok.
>     So i resend it.
>
>  kernel/cred.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, that worked much better.  As the prior patch sat for weeks
without any objections I've gone ahead and merged this via the lsm/dev
tree; if anyone has any objections please let me know before the
upcoming merge window.

> diff --git a/kernel/cred.c b/kernel/cred.c
> index c033a201c808..02a96e9d9cfd 100644
> --- a/kernel/cred.c
> +++ b/kernel/cred.c
> @@ -606,8 +606,8 @@ int set_cred_ucounts(struct cred *new)
>  void __init cred_init(void)
>  {
>         /* allocate a slab in which we can store credentials */
> -       cred_jar = kmem_cache_create("cred_jar", sizeof(struct cred), 0,
> -                       SLAB_HWCACHE_ALIGN|SLAB_PANIC|SLAB_ACCOUNT, NULL);
> +       cred_jar = KMEM_CACHE(cred,
> +                               SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT);
>  }
>
>  /**
> --
> 2.39.2
diff mbox series

Patch

diff --git a/kernel/cred.c b/kernel/cred.c
index c033a201c808..02a96e9d9cfd 100644
--- a/kernel/cred.c
+++ b/kernel/cred.c
@@ -606,8 +606,8 @@  int set_cred_ucounts(struct cred *new)
 void __init cred_init(void)
 {
 	/* allocate a slab in which we can store credentials */
-	cred_jar = kmem_cache_create("cred_jar", sizeof(struct cred), 0,
-			SLAB_HWCACHE_ALIGN|SLAB_PANIC|SLAB_ACCOUNT, NULL);
+	cred_jar = KMEM_CACHE(cred,
+				SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT);
 }
 
 /**