diff mbox series

scsi: libsas: fix whitespace formatting

Message ID CH0PR20MB381839E1C7FCA1F477D7823D9C81A@CH0PR20MB3818.namprd20.prod.outlook.com
State New
Headers
Series scsi: libsas: fix whitespace formatting |

Commit Message

Nick Spooner Dec. 1, 2023, 7:38 p.m. UTC 
  Resolve whitespace issues reported by checkpatch.pl:

WARNING: Missing a blank line after declarations
CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: spaces preferred around that '|' (ctx:VxV)

Signed-off-by: Nick Spooner <nicholas.spooner@seagate.com>
---
 drivers/scsi/libsas/sas_init.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Martin K. Petersen Dec. 6, 2023, 2:23 a.m. UTC | #1 
Nick,

> Resolve whitespace issues reported by checkpatch.pl:

checkpatch.pl is for validating patches. We only adjust formatting for
existing code when we have to change the code for functional reasons.
diff mbox series

Patch

diff --git a/drivers/scsi/libsas/sas_init.c b/drivers/scsi/libsas/sas_init.c
index 9c8cc723170d..91946f56b236 100644
--- a/drivers/scsi/libsas/sas_init.c
+++ b/drivers/scsi/libsas/sas_init.c
@@ -309,6 +309,7 @@  int sas_phy_reset(struct sas_phy *phy, int hard_reset)
        } else {
                struct sas_rphy *rphy = dev_to_rphy(phy->dev.parent);
                struct domain_device *ddev = sas_find_dev_by_rphy(rphy);
+
                ret = sas_smp_phy_control(ddev, phy->number, reset_type, NULL);
        }
        return ret;
@@ -346,9 +347,9 @@  static int sas_set_phy_speed(struct sas_phy *phy,
        } else {
                struct sas_rphy *rphy = dev_to_rphy(phy->dev.parent);
                struct domain_device *ddev = sas_find_dev_by_rphy(rphy);
+
                ret = sas_smp_phy_control(ddev, phy->number,
                                          PHY_FUNC_LINK_RESET, rates);
-
        }
 
        return ret;
@@ -612,7 +613,7 @@  static inline ssize_t phy_event_threshold_store(struct device *dev,
 }
 
 DEVICE_ATTR(phy_event_threshold,
-       S_IRUGO|S_IWUSR,
+       S_IRUGO | S_IWUSR,
        phy_event_threshold_show,
        phy_event_threshold_store);
 EXPORT_SYMBOL_GPL(dev_attr_phy_event_threshold);