From patchwork Tue Aug 1 12:02:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 129290 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp2649952vqg; Tue, 1 Aug 2023 06:01:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlGy994wp7o6F6xlZ9ouQzpd/0F/Z40gEdlCa6qwFr+sZx7DKJkTFUfN5gC6vdYHdaStTKQj X-Received: by 2002:a17:90a:13c4:b0:268:47c2:e490 with SMTP id s4-20020a17090a13c400b0026847c2e490mr11465567pjf.1.1690894893281; Tue, 01 Aug 2023 06:01:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690894893; cv=none; d=google.com; s=arc-20160816; b=Ib8UplH95KIFVMpd2b/l74rmYj/roMqPHxj6zl3dcHxUeboWa1VvTz0hu5rI7riaAZ 16EOi5SldTltCekCyNT4FxxeAWop38Yyw/94Cnlfn5HOCa0Ji8/ADyi00rINU1zQ9gI5 +s3uIvZhqtmGr2mxngmLyM9Xq2aR3/akOJP32e7/pZRMuu9zIkjGrPMDijXiqVAW0N5w AderfpbdI7bgiy+1Hpux+zt/hpgIVnsuqgGTKtzBSK0wSsh1VLISBuyxpVIfUpuATP+7 87oN4EhCpeH2xrA78hSMnfProKjPj7O4ub4culvWMS570etm2Kf260QIFR9l2xG7er5+ YV9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=dZ24obycD5mrkQpoUsQoswLpJmFabLRX8Q+g0alpa64=; fh=hx4ic7VsPQW0JstbLQfs1hoDrPDHT45KE0LM6zp9p28=; b=kLdMG8YbZpgOTI9O83JUbyLrrTCRPeumZIgnFZVhC0K3HYv0AGHDYtKQdS7w8KMj26 EMcn1hjQsRZQ5tV6jxJ9mGlZOi1ojcbJLDwpgY/N2/aYnbJXvFfn8XU8YqZbRo4Fmbul 4yt5YGTCLEi2wSS9SigZhPe/a/kiregzgOzSgMS6P3biPrd9OWELawgbCIAYAODwnLUv Y4qQ7eUEo7Lwsp9tzcI9aiRr3d20LbvUOHVBjvPpq0g/oy6yrf616rFDE+Wh7HTj0d2h DZX/FMKwgIqBQG2BW0Oa1n/mFZHCDQ451Vc55WMVuApGmRdRdDKymfpxKjny1yYt+orz NzKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="c/9EB8Xk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q62-20020a17090a754400b00265e48c115csi4806639pjk.114.2023.08.01.06.01.17; Tue, 01 Aug 2023 06:01:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="c/9EB8Xk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234217AbjHAMEw (ORCPT + 99 others); Tue, 1 Aug 2023 08:04:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234574AbjHAMDL (ORCPT ); Tue, 1 Aug 2023 08:03:11 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 772F1A1; Tue, 1 Aug 2023 05:02:17 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-4fe389d6f19so3094235e87.3; Tue, 01 Aug 2023 05:02:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690891335; x=1691496135; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dZ24obycD5mrkQpoUsQoswLpJmFabLRX8Q+g0alpa64=; b=c/9EB8XkZx4fheyF95mnag4F9DbjGT8wXzwdS4bzQq1QkPLYTiW2v+zHyGKCm9fZq9 nMLkf7QQNzOdBHs4cICcBMR4v7gXBay+FrfSl5DZp2HyEyEcJSJ66H+AiK1J5J+t2njT FURvjTGAmnAiMtuiNsO6FQw6/+Tb9Mr+wihrP4DHHYCLpl5BeB38S4zR37IT8VgKK4sF 6M6/nNghvI1Tj2w4Gz8VyMShcL9DR/qjnP2eTEajov3OXyxwGhdRgYflB33Ve4/tmiU/ GHLLiEdN+lEqOV8r9RklwWRvVf7Z++fR7APSOvStAl9kBm7TF95okjyv94oB7yN4U9V+ m+aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690891336; x=1691496136; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dZ24obycD5mrkQpoUsQoswLpJmFabLRX8Q+g0alpa64=; b=Fgt+XGjMnsRtkP81grNGg4x+XcYr2bhMsING/Yr0wj5ieOd4bB4zt2a+EelZj1vpj+ voFnoZBciJjWXAT11tMrDokN/7NAAaPdOOy+jn4Mx0s2cx+z9/fQ2R1Fxr6eTlaXaxqT CLIq30n/sPe4zqdB1a+ur37ku3rHT9m/n2bwgpvPpV6HJs8D6AUFKOzwfCYrcU9RopdA /r98Nygq2rdcV8w/KfbQ7R3goeZSz6YruNCB/zo/JlafhLmcuXAu+mIajknkuUKUGuTV JfVWR0KA1SSKp1frRtTNSCry++DkHePo3ZwUBc7wnn2S3T10MHlG15ZLrIpZXlXmTXsR tyeg== X-Gm-Message-State: ABy/qLZvokMk2BLIAm4vKiUZhqju3BVRy1PmX21iOblz8CvTimIZ5gor k9KaSbkcHfxyQAKmf6cErk0UyoAggRI= X-Received: by 2002:a05:6512:3e02:b0:4f9:596d:c803 with SMTP id i2-20020a0565123e0200b004f9596dc803mr2817166lfv.53.1690891335344; Tue, 01 Aug 2023 05:02:15 -0700 (PDT) Received: from fedora ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id j16-20020a19f510000000b004fe15543d31sm2501193lfb.192.2023.08.01.05.02.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 05:02:14 -0700 (PDT) Date: Tue, 1 Aug 2023 15:02:10 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Andreas Klinger , Jonathan Cameron , Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 1/8] iio: mb1232: relax return value check for IRQ get Message-ID: <9e18cf49a8bb581a84c3fa548ea577e2a3eb840d.1690890774.git.mazziesaccount@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773031803840181967 X-GMAIL-MSGID: 1773031803840181967 fwnode_irq_get() was changed to not return 0 anymore. Drop check for return value 0. Signed-off-by: Matti Vaittinen Acked-by: Jonathan Cameron Reviewed-by: Andy Shevchenko --- Revsion history: v5 =>: - No changes v4 => v5: - drop unnecessary data->irqnr = -1 assignment The patch changing the fwnode_irq_get() got merged during 5.4: https://lore.kernel.org/all/fb7241d3-d1d1-1c37-919b-488d6d007484@gmail.com/ This is a clean-up as agreed. --- drivers/iio/proximity/mb1232.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/iio/proximity/mb1232.c b/drivers/iio/proximity/mb1232.c index fb1073c8d9f7..614e65cb9d42 100644 --- a/drivers/iio/proximity/mb1232.c +++ b/drivers/iio/proximity/mb1232.c @@ -76,7 +76,7 @@ static s16 mb1232_read_distance(struct mb1232_data *data) goto error_unlock; } - if (data->irqnr >= 0) { + if (data->irqnr > 0) { /* it cannot take more than 100 ms */ ret = wait_for_completion_killable_timeout(&data->ranging, HZ/10); @@ -212,10 +212,7 @@ static int mb1232_probe(struct i2c_client *client) init_completion(&data->ranging); data->irqnr = fwnode_irq_get(dev_fwnode(&client->dev), 0); - if (data->irqnr <= 0) { - /* usage of interrupt is optional */ - data->irqnr = -1; - } else { + if (data->irqnr > 0) { ret = devm_request_irq(dev, data->irqnr, mb1232_handle_irq, IRQF_TRIGGER_FALLING, id->name, indio_dev); if (ret < 0) {