From patchwork Wed Jan 11 15:51:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 42067 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3397025wrt; Wed, 11 Jan 2023 07:54:45 -0800 (PST) X-Google-Smtp-Source: AMrXdXudNDCMt31eD6mVI7DwBKUyrpgZbtKig480DY6N8JHeiTtUYc3bVoCZ4s+wX11bC79/BDES X-Received: by 2002:a05:6a21:3d0e:b0:b2:40a8:abc0 with SMTP id bi14-20020a056a213d0e00b000b240a8abc0mr94338242pzc.40.1673452485693; Wed, 11 Jan 2023 07:54:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673452485; cv=none; d=google.com; s=arc-20160816; b=xQC3/SS/E4RHCHKDOdf9CCZEXzvQNu2JmoxPHmsTWCzuVLs1kee6Rwn+pjr3JtBiA2 YsWeXeiNWwjf6LwkS0814oqQ7yHrHLwwfEI23Sb5bDPH1Mn6YXS0EenbV50VJenNhB/c YagrmCc10cclHRJyEDHPeY9oZlv7jnFYQgnAlGRcVVqavKCn2rckIpZCh4xa2qORrMyC 5Yl8/1W3ryd6eohAJpD2Q30Zo9EAJS1qoBR8qDD9vD84o1qf5tzeLicCI9xV5jM9g8j+ HX84D3C73NWhrFKRApIYVQybZgbdzI5C9g5Xm8l/e3B0i/5ITtGVJjBarZy2zVBwsBeM GcnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MrFdJGPyDA1XYRbFtRJz6rGa2tgrVfbQ2tEaDypDloM=; b=En6uw+i80n96lo0lANUrpEMzx9NOuTy7Mk5+ISzrexJHjPT9PIucqE/NqUkEkAsxqv 8YfUbJucsAjMsCT3Kn3/GO1vlLk/iNJHPPO1cu1Vx7B4dyxSc6B4q8tcUChLN4NS5yh1 BkHLDkMtVPvnP9+0t4fYQRxeTNfleMZ71DIf3WIf4ayt3GAn8NBGNZ8RMFkZBOMLWh6k sP4FoNdxMMMZDYrBEmLmgwUu+XF9fruUMf1sWf5FgzkznP9dVrUc4+I3p+cdRDVqfwtx u0gM1n8WieJXAP6qlIpaEACV3tFHDzNF8G9ru/nAd6Tcg1DrlVPq8SjdTEbY1bHKvtZU UYtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=bqX2UtXr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u6-20020a654c06000000b0046ef21af717si15894259pgq.683.2023.01.11.07.54.32; Wed, 11 Jan 2023 07:54:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=bqX2UtXr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238196AbjAKPwC (ORCPT + 99 others); Wed, 11 Jan 2023 10:52:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239316AbjAKPvf (ORCPT ); Wed, 11 Jan 2023 10:51:35 -0500 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36CA9BCBF for ; Wed, 11 Jan 2023 07:51:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1673452284; bh=THQIBZsCDLUDELR9zM2u/FFpjKMFppx+9GbC/MJGIh0=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=bqX2UtXrBjNnUqciMOAPWkkrCwZAjnnJ5asG9VanqoB0V+1AB5H53NDjuVlZVegNb 9+9LQfuRq+Wng1TCzL7uQOIBf0DO6UbXo2nQm70n0oLhKh7cjEJuIpQNNmqso3oVcK qsyJpH2MC3wR0bOwR/sdV9DbwquJl0NOCZiXxKqA= Received: by b-4.in.mailobj.net [192.168.90.14] with ESMTP via ip-206.mailobj.net [213.182.55.206] Wed, 11 Jan 2023 16:51:24 +0100 (CET) X-EA-Auth: 9JimyKqsqRTHIQ0l7mD0jb69Pga8jl5XRjRQnAeWaucLzoY+0wvBYU2iC6EpI1rGzIsbtQiGAzRKXkGmu2mjFH7VsNcbfXVK Date: Wed, 11 Jan 2023 21:21:20 +0530 From: Deepak R Varma To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar Subject: [PATCH v3 1/2] drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes Message-ID: <9e08dd1b5fabf3e4f54dda27dd1d6ea1dbe6c542.1673451705.git.drv@mailo.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754742113995706991?= X-GMAIL-MSGID: =?utf-8?q?1754742113995706991?= Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy factory file operations structure and function wrapping at runtime. As a replacement, a combination of DEFINE_DEBUGFS_ATTRIBUTE macro paired with debugfs_create_file_unsafe() is suggested to be used instead. The DEFINE_DEBUGFS_ATTRIBUTE utilises debugfs_file_get() and debugfs_file_put() wrappers to protect the original read and write function calls for the debug attributes. There is no need for any runtime proxy file operations to be managed by the debugfs core. Following coccicheck make command helped identify this change: make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: Deepak R Varma --- Changes in v3: - Fix checkpatch complaint around function parameter alignment Changes in v2: - Include coccicheck make command in the patch log message for clarity. Suggested by Rodrigo Vivi drivers/gpu/drm/i915/display/intel_drrs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_drrs.c b/drivers/gpu/drm/i915/display/intel_drrs.c index 5b9e44443814..29c6421cd666 100644 --- a/drivers/gpu/drm/i915/display/intel_drrs.c +++ b/drivers/gpu/drm/i915/display/intel_drrs.c @@ -374,16 +374,16 @@ static int intel_drrs_debugfs_ctl_set(void *data, u64 val) return ret; } -DEFINE_SIMPLE_ATTRIBUTE(intel_drrs_debugfs_ctl_fops, - NULL, intel_drrs_debugfs_ctl_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(intel_drrs_debugfs_ctl_fops, + NULL, intel_drrs_debugfs_ctl_set, "%llu\n"); void intel_drrs_crtc_debugfs_add(struct intel_crtc *crtc) { debugfs_create_file("i915_drrs_status", 0444, crtc->base.debugfs_entry, crtc, &intel_drrs_debugfs_status_fops); - debugfs_create_file("i915_drrs_ctl", 0644, crtc->base.debugfs_entry, - crtc, &intel_drrs_debugfs_ctl_fops); + debugfs_create_file_unsafe("i915_drrs_ctl", 0644, crtc->base.debugfs_entry, + crtc, &intel_drrs_debugfs_ctl_fops); } static int intel_drrs_debugfs_type_show(struct seq_file *m, void *unused)