From patchwork Thu Aug 24 15:08:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 136850 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a7d1:0:b0:3f2:4152:657d with SMTP id p17csp1233012vqm; Thu, 24 Aug 2023 09:19:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFRMdc/GHal8uNivI2BCFyefYygMP0YXv6senRlGA341ouoOSV6e9tpSVdV8FN/WTlCSzbx X-Received: by 2002:a2e:8796:0:b0:2bc:cff6:f506 with SMTP id n22-20020a2e8796000000b002bccff6f506mr6697609lji.0.1692893942669; Thu, 24 Aug 2023 09:19:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692893942; cv=none; d=google.com; s=arc-20160816; b=I4MMRhjHQ8HYJthu4xyK26PMC8tiVsdkrxrC8A9gmi3Yi0tol/Va4EKsdt1SIvlQYC eiQc3LEUKImBDL28QdL3v3yHlkWaRXJgpelT5rsCMOuZqPzz+BtvSj+NW5ifITEKjDHj 9pniRX9gXGfeDlXE/+oHG3gh0UZmEOzuN+3YQImRXGqo1q3fssqiAlY6dbk44bQJ8lOr BTduy3UeEqj56zkjXiUxZB3OTl+D8Q53nwXdcUiOe5LVBAJRWUu0198AMv+uU6AQOZKh aMxYQevzXpz5xppdSd14UpWHEsq+gt3TD5K4xra8Q3914iOvWYdQwpOfxvG5Anlz/+W6 MAHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=pTTIx/3wsXgqu/LoOf+f6JsbAYTQNIF6xZRMzHo5bD0=; fh=wcJXU+GRAJ+lFf7so8itXL2pGJ6fujr2XomH/f1be3s=; b=MG4P0lShDJejMrMZjTPfgkSMxyZVuR/czXg+xc4LVlwbQakUEFboj/IrYS6rXwqtJQ 1YbBwUN0VuNoKtNDNZ1qkhC0wXO+RuG6fybeoU/jhweQ4XjHS+w3tghT1Sj7PtGoBvQh 2SdAaqdWVrMCHisyFMSrQTYk89Fytd7+7EuqwNr3S9xQcgzMm3nVa18zF+e3LTPgevFY BaxEVxUpDMKDqpkim98Ydeazpxg2bNuvHvirjkseiD+qwPtnfhDxfJsoLfq5/tumTtpz 1nhf2fFW01p2PZIi5M8LCmS60Ctb5yWCeLcse9ABRs191W0OUQjOoJXSPNGeITesgM/K Vbpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n11-20020a170906724b00b009888e0923cfsi10110798ejk.712.2023.08.24.09.18.37; Thu, 24 Aug 2023 09:19:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242128AbjHXPJJ (ORCPT + 99 others); Thu, 24 Aug 2023 11:09:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242154AbjHXPJA (ORCPT ); Thu, 24 Aug 2023 11:09:00 -0400 Received: from laurent.telenet-ops.be (laurent.telenet-ops.be [IPv6:2a02:1800:110:4::f00:19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 030941BC5 for ; Thu, 24 Aug 2023 08:08:56 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:3c6b:f703:5ab5:f36d]) by laurent.telenet-ops.be with bizsmtp id dT8t2A00G01sfPQ01T8th6; Thu, 24 Aug 2023 17:08:53 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qZBwx-001dhY-L3; Thu, 24 Aug 2023 17:08:53 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qZBx7-000VzG-AC; Thu, 24 Aug 2023 17:08:53 +0200 From: Geert Uytterhoeven To: Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v2 8/8] drm/ssd130x: Switch preferred_bpp/depth to 1 Date: Thu, 24 Aug 2023 17:08:46 +0200 Message-Id: <9dbc3b5124c69514c123f9b880fdd372928e69df.1692888745.git.geert@linux-m68k.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775127958486499505 X-GMAIL-MSGID: 1775127958486499505 The native display format is R1. Hence change the preferred_depth and preferred_bpp to 1, to avoid the overhead of using XR24 and the associated conversions when using fbdev emulation and its text console. Signed-off-by: Geert Uytterhoeven Reviewed-by: Javier Martinez Canillas Tested-by: Javier Martinez Canillas --- v2: - Add Reviewed-by, Tested-by. --- drivers/gpu/drm/solomon/ssd130x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c index 18007cb4f3de5aa1..0d2b36ba40113fa3 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -1049,7 +1049,7 @@ static int ssd130x_init_modeset(struct ssd130x_device *ssd130x) drm->mode_config.max_width = max_width; drm->mode_config.min_height = mode->vdisplay; drm->mode_config.max_height = max_height; - drm->mode_config.preferred_depth = 24; + drm->mode_config.preferred_depth = 1; drm->mode_config.funcs = &ssd130x_mode_config_funcs; /* Primary plane */ @@ -1179,7 +1179,7 @@ struct ssd130x_device *ssd130x_probe(struct device *dev, struct regmap *regmap) if (ret) return ERR_PTR(dev_err_probe(dev, ret, "DRM device register failed\n")); - drm_fbdev_generic_setup(drm, 32); + drm_fbdev_generic_setup(drm, 1); return ssd130x; }