Message ID | 9db9653eb33d345d305e918215216348a8f193da.1685082026.git.mazziesaccount@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp277223vqr; Fri, 26 May 2023 00:05:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6M4cDxQZktv6o/uz8fc51good9rL5BRwfHS9euveN1jwPZYhIiHh2c0YXRPPkSNmW/gJHY X-Received: by 2002:a05:6a20:8421:b0:10c:7676:73af with SMTP id c33-20020a056a20842100b0010c767673afmr1005671pzd.53.1685084726713; Fri, 26 May 2023 00:05:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685084726; cv=none; d=google.com; s=arc-20160816; b=1EfB7i3YYbT1IXq58M+//fjEyMAIQ5/BWsYd6sChAmTUmjSg7gavS/K5HF7ZoAuEF5 1ulsKASc5bOWoXIQ5BrhmZwtRlrmBvHIh9moalhxq29Xm12pk23WmGxwjfVOQNL8Xx8s ab0zensZxKCtc7rH7benSF9Flsij5azreB6N9dPoyHPROruNIs58klKwi2frySwqqS+I hElJmsLkS4S9iAFMAfwR/YIn15gLIQ4kO97qk/1xEsjYIeA5JaXWZBL3BdWSBi/JDxqk 73ECsoj+3Q0dL3f1SKm7jyPFSPddcyQFh5u2M6Sg1HeF/4A1WSDYXbvjChPTMuNzy0Jr dWQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ekbpAMbogTlMCWxkxFZ/eQBJQS9KZeZKKkgzxsIBTZY=; b=bc71+Wklmy2/51OXYSlj9thUI3QRpmUVmVWg/hq9FOkUH6i0n7YtokHK+C44lQglb8 gDIiabT29VVj1Xx9GHW06bkDBsWHL5lObmO0FlFi/rTRaxyYhZj1R9RiSTiiAOZKiaD1 XmcCFBT5jq9h0Wp8ptVbgaCU4Sab6OJhX/tf1XztLnnMT7T5i2NvoUjnMKtcDTKctumx UK6xXZMsiuZ6ZzIPg+ATn9cawNV0I8PkwnW79wFTDBkBVSrXxSGqQCuw3dMwXc3hshRS vD9lSLZ1PEd4QjpbjeBzrJDWFZ7Bg2XlWsiSTUiz4CGim4sYVzMnIoslYzOE/CeIugHv oBDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=swo3Sx3G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e21-20020aa79815000000b0064d71cbb1ccsi2809091pfl.87.2023.05.26.00.05.15; Fri, 26 May 2023 00:05:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=swo3Sx3G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242168AbjEZGjR (ORCPT <rfc822;zhanglyra.2023@gmail.com> + 99 others); Fri, 26 May 2023 02:39:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242258AbjEZGjJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 26 May 2023 02:39:09 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7418E12F; Thu, 25 May 2023 23:39:04 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4f4db9987f8so1285550e87.1; Thu, 25 May 2023 23:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685083143; x=1687675143; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ekbpAMbogTlMCWxkxFZ/eQBJQS9KZeZKKkgzxsIBTZY=; b=swo3Sx3G1UOBDNaL7TLrRZ5pQB/6afRbf8eQBpp9b1OaBl7qkV9Yxk0SqRq0yePA18 ZKv1bPnEl7wMGTPLzvoaZtjDHe8nkwbU5pybFPwKDNauvtpgVcg/O+tw5mTdjHSjStBG yyP3YnlUR51SJ2O95YR7Sp3Ji9z1kAInjJVXtbFGs5Adtb48Zyh7ttRnntgEvp+hF88q v2G+jHWagwpjRk3ZrlNpgM08lGmFRHBp5VCx/SEBP+MX32Hxmjg133eGpcr5PaK5BKel L88+H53RnL1ZExbKN0NwzYroA481IHdtNGLAfDr9xx1sTeo4kYglbNM3i6Jj3uVmhfjz 5p7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685083143; x=1687675143; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ekbpAMbogTlMCWxkxFZ/eQBJQS9KZeZKKkgzxsIBTZY=; b=FB6TpBrt4hbM+ybDODTgSU4zJRIK5Jwn8LkOHknM5L3sEqnFEImuvHY8jMFOHkepxp Pg4cJrV6gcZtxRzvyDstQj/W3XumAe/ayhxIFYGeR2mnyW8Ey522nG3/VfWPyfbjmPf+ AAErGi55HjeqLg+/db5w7OLuVABYxrqZBV177gK+kufFq+HTGk7bQ/AfGrvoXdx7uZIQ 5Qumy1dzXUOSNyM85QgUsgR/DJcEDr1ygaydt+8Xyldy4JK+PUMzesDDoV2vnXNtfZoK CJKaLdMkiTlVxZwDpZp+H5Cfvg4Vge0CwHx+fIsr7KCCL0mnCzqpjQu4qf38WBYAEV/I PMRg== X-Gm-Message-State: AC+VfDxI3tvNR+SNr7/JU7F+CbJN08cz1WbikS/kevx+7W9CEYj1QRRY iAyC8dd9hO9XFaXB/Dqo1s8= X-Received: by 2002:a05:6512:3d90:b0:4f3:a55c:ebdc with SMTP id k16-20020a0565123d9000b004f3a55cebdcmr1440553lfv.17.1685083142646; Thu, 25 May 2023 23:39:02 -0700 (PDT) Received: from fedora ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id p11-20020a05651211eb00b004f13ca69dc8sm486674lfs.72.2023.05.25.23.39.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 23:39:01 -0700 (PDT) Date: Fri, 26 May 2023 09:38:58 +0300 From: Matti Vaittinen <mazziesaccount@gmail.com> To: Matti Vaittinen <mazziesaccount@gmail.com>, Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Daniel Scally <djrscally@gmail.com>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Wolfram Sang <wsa@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Michael Hennerich <Michael.Hennerich@analog.com>, Jonathan Cameron <jic23@kernel.org>, Andreas Klinger <ak@it-klinger.de>, Marcin Wojtas <mw@semihalf.com>, Russell King <linux@armlinux.org.uk>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jonathan =?iso-8859-1?q?Neusch=E4fer?= <j.neuschaefer@gmx.net>, Linus Walleij <linus.walleij@linaro.org>, Paul Cercueil <paul@crapouillou.net>, Akhil R <akhilrajeev@nvidia.com>, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org Subject: [PATCH v6 6/8] pinctrl: pistachio: relax return value check for IRQ get Message-ID: <9db9653eb33d345d305e918215216348a8f193da.1685082026.git.mazziesaccount@gmail.com> References: <cover.1685082026.git.mazziesaccount@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="o9c5bgYMrd+9nbej" Content-Disposition: inline In-Reply-To: <cover.1685082026.git.mazziesaccount@gmail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766939402344917174?= X-GMAIL-MSGID: =?utf-8?q?1766939402344917174?= |
Series |
fix fwnode_irq_get[_byname()] returnvalue
|
|
Commit Message
Matti Vaittinen
May 26, 2023, 6:38 a.m. UTC
fwnode_irq_get[_byname]() were changed to not return 0 anymore. Drop check for return value 0. Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> --- Revision history: - No changes Please note, I took Linus' reply to v4 cover-letter as ack && added the tag. Please let me know if this was not Ok. The first patch of the series changes the fwnode_irq_get() so this depends on the first patch of the series and should not be applied alone. --- drivers/pinctrl/pinctrl-pistachio.c | 6 ------ 1 file changed, 6 deletions(-)
Comments
On Fri, 26 May 2023 09:38:58 +0300 Matti Vaittinen <mazziesaccount@gmail.com> wrote: > fwnode_irq_get[_byname]() were changed to not return 0 anymore. > > Drop check for return value 0. > > Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > --- > Revision history: > - No changes > > Please note, I took Linus' reply to v4 cover-letter as ack && added the > tag. Please let me know if this was not Ok. Whilst I understand your point as Linus said he'd pick the patches up, I would have left it to Linus to Ack explicitly but added a note here to say he basically already did. LGTM Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > The first patch of the series changes the fwnode_irq_get() so this depends > on the first patch of the series and should not be applied alone. > --- > drivers/pinctrl/pinctrl-pistachio.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c > index 53408344927a..8c50e0091b32 100644 > --- a/drivers/pinctrl/pinctrl-pistachio.c > +++ b/drivers/pinctrl/pinctrl-pistachio.c > @@ -1393,12 +1393,6 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl) > dev_err(pctl->dev, "Failed to retrieve IRQ for bank %u\n", i); > goto err; > } > - if (!ret) { > - fwnode_handle_put(child); > - dev_err(pctl->dev, "No IRQ for bank %u\n", i); > - ret = -EINVAL; > - goto err; > - } > irq = ret; > > bank = &pctl->gpio_banks[i];
diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c index 53408344927a..8c50e0091b32 100644 --- a/drivers/pinctrl/pinctrl-pistachio.c +++ b/drivers/pinctrl/pinctrl-pistachio.c @@ -1393,12 +1393,6 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl) dev_err(pctl->dev, "Failed to retrieve IRQ for bank %u\n", i); goto err; } - if (!ret) { - fwnode_handle_put(child); - dev_err(pctl->dev, "No IRQ for bank %u\n", i); - ret = -EINVAL; - goto err; - } irq = ret; bank = &pctl->gpio_banks[i];