From patchwork Fri Dec 8 16:08:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 175887 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5555576vqy; Fri, 8 Dec 2023 08:09:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IGD4vFmmh0pipjbJj4Z5Pdp2BhsUd5xq+WeH9LUhQrX5xodzCbmsDr/6PV4dc7KVliHpqDB X-Received: by 2002:a17:90a:cb94:b0:286:9cdc:c2e1 with SMTP id a20-20020a17090acb9400b002869cdcc2e1mr264219pju.13.1702051775725; Fri, 08 Dec 2023 08:09:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702051775; cv=none; d=google.com; s=arc-20160816; b=A5Z6F33WVTBvj57Ygrmwh0ZJKhdL3rEno0JnCBC0vCo3/4scHblp1Jc9PfWkGe8mFL zIEk9IFSxuLbZx8IpLx6+5aD7IV4gJWLfNBozD9gw2CazBu9dkaf1VAW3fzKy6rS5mIw batYPKCrOxJNb3cuvM1+N/XiLQq3XWT9Tmdg1cvFXT/YokSktabnt8FQGNZtsJSovmUq rl687Sgipu+M89APf6ATa0pY8A+4wjXGMOkOeT6QIZ7WuQaOrq+P/LaYtaDyd5Nu7Xe3 IkGDPI1NYO8iQuDT3+h3EQ+kjnVru1sQQAzzkQ6rCl5CdzXWbYulPLavQo9f1PmJmUxQ avbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=lPsIqd6GyW1gNAvnb+HyHwECw/HPLQVIp/t+BHjQi0Y=; fh=s0Gx9AMFtMTCDS4nZmC1Kt+CYwr1GWTLQST3h3KzV/o=; b=KdpUCsZ3hvIwOxvzBod49eGKhiQ5V34lF3dWkBZf0YBymebqUSwSKt3CdEyLBIgkd8 n909p1oqwVffPrD16QXXjn4novwsxcDfmKXdSqBejoH7r/KCzBiDntQmzOHVquw32l4D Jxjd5sLVkEaMbOhJcuWFZ1vplyu4niXDiPWhV2vcUUQdJ25XlyeaMnETxxzNIABJzMyV uPQYOXpb+nTkYvbboWuWIfC0wH6uHBktsaGBT+ImMH/gwZ3hdudqnm1OxbJgWPhSQTut YzhBjAu+Ruz+KozfB95WPxzGI8RaJS/QVFoQol14J2QVc6LrKO1f+1ODgQyOasLwsJah qj1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id h15-20020a17090aa88f00b0028a2fd5ba9csi1299000pjq.107.2023.12.08.08.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 08:09:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id EE2F782E1095; Fri, 8 Dec 2023 08:09:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235907AbjLHQJV (ORCPT + 99 others); Fri, 8 Dec 2023 11:09:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233610AbjLHQJN (ORCPT ); Fri, 8 Dec 2023 11:09:13 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D61B9171C for ; Fri, 8 Dec 2023 08:09:19 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBdPe-000088-EY; Fri, 08 Dec 2023 17:09:14 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdPc-00ES0O-Qo; Fri, 08 Dec 2023 17:09:12 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rBdPc-00GUaO-H9; Fri, 08 Dec 2023 17:09:12 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dominik Brodowski , Greg Kroah-Hartman Cc: Pavel Machek , "Steven Rostedt (Google)" , Paolo Abeni , Kalle Valo , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 4/7] pcmcia: omap_cf: Convert to platform remove callback returning void Date: Fri, 8 Dec 2023 17:08:09 +0100 Message-ID: <9d96646b75b10f7562d4d18010e885b7fc55e0ab.1702051073.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1745; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=RbjHfi5RXtO4cc8x56c5B+Z/tmcBf4To9DyVqGrX0Mw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlcz9uzcEXgFvxHOFei0v+/iJGpZmJ3AUq5eLjE /WeNYj57paJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXM/bgAKCRCPgPtYfRL+ TuNiCACNqZGlNha/Xc541obujpShtx6aayui0pbg6Wz+3ZIzoDiAvtzMRVCvJOaLzjEh13m/bGs tClR79pkmqPpYeAmLQ82WGZbEbvjohsA+5bofFYGzUVFAAv5Iu2YGsz8k0KU9Rgs2EPPSJbBuuG rfFcXDs/n1dlm3DpHuCKOO+XlfxABBtBXD3VgxUXBpEg9LWy55JXRewJQtAP2TTG48q+H6uo7nP bu2Sxwmf1MLzIqLOJYkzv6+HFPR5EMBsaLwLZ9dX2LCKdFwDZT6X0dQJUgNR1hdPrH/i2dNQruQ QWYqvuLCEimGnBiIgTqLzjj+njANSuoYpjF1WfJXxEjxile2 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 08 Dec 2023 08:09:31 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784730642877849157 X-GMAIL-MSGID: 1784730642877849157 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pcmcia/omap_cf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pcmcia/omap_cf.c b/drivers/pcmcia/omap_cf.c index e613818dc0bc..80137c7afe0d 100644 --- a/drivers/pcmcia/omap_cf.c +++ b/drivers/pcmcia/omap_cf.c @@ -290,7 +290,7 @@ static int __init omap_cf_probe(struct platform_device *pdev) return status; } -static int __exit omap_cf_remove(struct platform_device *pdev) +static void __exit omap_cf_remove(struct platform_device *pdev) { struct omap_cf_socket *cf = platform_get_drvdata(pdev); @@ -300,14 +300,13 @@ static int __exit omap_cf_remove(struct platform_device *pdev) release_mem_region(cf->phys_cf, SZ_8K); free_irq(cf->irq, cf); kfree(cf); - return 0; } static struct platform_driver omap_cf_driver = { .driver = { .name = driver_name, }, - .remove = __exit_p(omap_cf_remove), + .remove_new = __exit_p(omap_cf_remove), }; static int __init omap_cf_init(void)