From patchwork Sun Dec 17 19:31:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180062 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp861208dyi; Sun, 17 Dec 2023 11:40:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IH7qbfqmiKHBBHXH9eG/yJvsTXjSY+lvti22tzZEhjd/mfhay2rlPYlyH0JyVgOWDkoDeug X-Received: by 2002:a05:6512:a8a:b0:50c:2254:9f5f with SMTP id m10-20020a0565120a8a00b0050c22549f5fmr5859581lfu.34.1702842053340; Sun, 17 Dec 2023 11:40:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702842053; cv=none; d=google.com; s=arc-20160816; b=t3rN5SVoWs7FtGqOGlx1cYp54nnq/oUHceHtR2edKL6CzOzDUaxcnjxaTpBQDH1i9j KzjiyzUgwaKUmf1NxhABGpuXJg5MIXoVQLfeDMzZBF6mTmG1yRcEDhUHjqbDhOCmL3gY oIqh2kPxPtgL89vYc6nqYxb2xviFaSNArhN6jnV9xB6IjuVgZeF565kQKByaX9lQUI+G LQHRm0t5renleN2OliTczHNW64nxwuRPEiTENMHOBvs0adn7T4Z6EmvLjwVAv5NKj6kY HOCyRQFitENiGMw39If5C3YTVeYS5aQH7TT5O2/rhMwQnbczOOrm+12iS3U8MBofgJkD UPxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Ksvta4Y31qY4t6AR5q9nPejIZRte2NZlAYJes54T4k8=; fh=lndhqhM/smUv/sqG9l62mCR6taeFpgcLIT7VIeds5fc=; b=VbhWFSET5ix/TCtYfEZga2l38Asw2uiQi+tg4DJRPodMjcdjdHFRNY7q0aZaiZVRGI g8Nfbqtw9VShZcxlroLejDHVknkjQjJZD47w7zIX7B18EO+n2ppybAyWj8qP1M3cdfJj IELBDRxzkOVsCBR6rkMDqmJG4cliIKhUlP+tqekgMVmoLuRbKc1XgVURi2YZ8AkTsp3h k4yz8JvWGNE+NM2fAkvLGyCpouSBBki5N6h/0P+urffa6gbZQ4ysoT9+zQq3pOMTTgEz 5eZkEBgZUBYrMzlMvukr0uIU0veAhyxCoswJ+H40oNtMgDCMDaRA22TrbdMg0fdamlq4 FKow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2782-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2782-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 18-20020a508e12000000b0054d9f540c4fsi9720905edw.551.2023.12.17.11.40.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 11:40:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2782-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2782-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2782-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A901F1F22E31 for ; Sun, 17 Dec 2023 19:32:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B52A048CCB; Sun, 17 Dec 2023 19:31:59 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16F9A481AB for ; Sun, 17 Dec 2023 19:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEwrh-0007Gf-0H; Sun, 17 Dec 2023 20:31:53 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEwrg-00GXTn-If; Sun, 17 Dec 2023 20:31:52 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEwrg-004owA-9V; Sun, 17 Dec 2023 20:31:52 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Santosh Shilimkar , Krzysztof Kozlowski Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] memory: emif: Simplify code handling CONFIG_OF Date: Sun, 17 Dec 2023 20:31:32 +0100 Message-ID: <9d53683c34a730c8579a1468b643b11d1379106e.1702829744.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1329; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=UHloRVwjjpUa4EBDR6pja+PDlmCiXF568S5ktJTQgoc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlf0yXR76tMQcRZQjv60lpw/WVYuSOoAAM2PoLS ucd3JRLq7aJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX9MlwAKCRCPgPtYfRL+ TsmeB/wM2bxYP6wMGCtl5hvyzR28sHfzThhCfKTnPAfEBBqUgqiKZkpzSO2CVcJhNgLVqV6cgQl wyyncvZe+Dv5+CIhpqlfsNUB8PGtCsN4HYlTa/kxGSgTulv53IzQtKPLiMVaetoMISHEpp2q/mR +N0eoiTwKf25+qC0YTaWuUV0qNt57I9KFRHYPGfcfFZk0oC+FATExB6NsHtog0veYBNSNmDvIVK OPpfiPojLpaBwXDHlZ/RmxSwbT20k0tBV7khG9kt+3+O/awc6q8TIYnSTV39O5Zry2eUfKSJEHL /5A3ZvMtySqt9Jfa2G6zZzsV+FsmGLKEYJyWDpuarMBn1PVk X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785559309081929114 X-GMAIL-MSGID: 1785559309081929114 The first thing that of_get_memory_device_details() does is calling of_parse_phandle(). With CONFIG_OF=n this returns NULL in a static inline function. So the compiler can determine that of_get_memory_device_details() also returns NULL. bloat-o-meter confirms that this patch has no effects on the size of the generated code for CONFIG_OF=n builds. Signed-off-by: Uwe Kleine-König --- drivers/memory/emif.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index dd1d87f8fdc8..5a3194b9b3bc 100644 --- a/drivers/memory/emif.c +++ b/drivers/memory/emif.c @@ -826,7 +826,6 @@ static int is_custom_config_valid(struct emif_custom_configs *cust_cfgs, return valid; } -#if defined(CONFIG_OF) static void __init_or_module of_get_custom_configs(struct device_node *np_emif, struct emif_data *emif) { @@ -983,15 +982,6 @@ static struct emif_data * __init_or_module of_get_memory_device_details( return emif; } -#else - -static struct emif_data * __init_or_module of_get_memory_device_details( - struct device_node *np_emif, struct device *dev) -{ - return NULL; -} -#endif - static struct emif_data *__init_or_module get_device_details( struct platform_device *pdev) {