media: chips-media: wave5: remove duplicate check

Message ID 9bdce1f1-b2f0-4b11-9dfd-16ca7048281b@moroto.mountain
State New
Headers
Series media: chips-media: wave5: remove duplicate check |

Commit Message

Dan Carpenter Nov. 28, 2023, 2:39 p.m. UTC
  We already verified that "ret" is zero a few lines earlier.  Delete this
duplicate check.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/media/platform/chips-media/wave5/wave5-hw.c | 3 ---
 1 file changed, 3 deletions(-)
  

Comments

Nicolas Dufresne Dec. 7, 2023, 7:08 p.m. UTC | #1
Le mardi 28 novembre 2023 à 17:39 +0300, Dan Carpenter a écrit :
> We already verified that "ret" is zero a few lines earlier.  Delete this
> duplicate check.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
>  drivers/media/platform/chips-media/wave5/wave5-hw.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c b/drivers/media/platform/chips-media/wave5/wave5-hw.c
> index 3fcb2d92add8..f1e022fb148e 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-hw.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c
> @@ -578,9 +578,6 @@ int wave5_vpu_dec_init_seq(struct vpu_instance *inst)
>  	dev_dbg(inst->dev->dev, "%s: init seq sent (queue %u : %u)\n", __func__,
>  		p_dec_info->instance_queue_count, p_dec_info->report_queue_count);
>  
> -	if (ret)
> -		return ret;
> -
>  	return 0;
>  }
>
  

Patch

diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c b/drivers/media/platform/chips-media/wave5/wave5-hw.c
index 3fcb2d92add8..f1e022fb148e 100644
--- a/drivers/media/platform/chips-media/wave5/wave5-hw.c
+++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c
@@ -578,9 +578,6 @@  int wave5_vpu_dec_init_seq(struct vpu_instance *inst)
 	dev_dbg(inst->dev->dev, "%s: init seq sent (queue %u : %u)\n", __func__,
 		p_dec_info->instance_queue_count, p_dec_info->report_queue_count);
 
-	if (ret)
-		return ret;
-
 	return 0;
 }