From patchwork Wed Jan 31 13:16:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baolin Wang X-Patchwork-Id: 194741 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp1880170dyb; Wed, 31 Jan 2024 05:17:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IFe7zRX2jBCg8UTWFffentZBiXvgl1/uiydXA0yAooXmi0Vu42cXU2k3l6ld6tqoAdDMLJ+ X-Received: by 2002:a05:620a:214f:b0:783:4bfe:b0e6 with SMTP id m15-20020a05620a214f00b007834bfeb0e6mr1354362qkm.38.1706707053312; Wed, 31 Jan 2024 05:17:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706707053; cv=pass; d=google.com; s=arc-20160816; b=vqKTpKatnFjF36A5Q8LplWyovCyG8cEPEz2x7o0DoeK1W0nblpM59vVXVQ6TVoavd8 1aMZ6cErD0wZEsR+nkyKCkHEFueWWn1kiHRC8zlZwVjB0Rh9rsfDsf4tsZTYkzBpprpg qBvrDLi4h9O75bsr5Ea9mQr/OXHSBQspKBHTf0TkIOsiNPFPtovuYsf2WxCoWHPfn0M7 kjT8rWB2AtEB9B+Sepvgk8n2lRF8AWnUEkq56fYDVXo0hz5nUYBuHt2qVt/K0XLUCDxn wegFhnQCwlLcqZmoXw6MP4QpFErv4CWo5cJQoBoMtsjd3pEdP8hdPNAm5mCR73+uxINV v74w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=R4BfaarR7H+2VERwphKn+Lf333CX+5PuQuJGhvUGjOc=; fh=r8wI/ImuI4x+/yM1SoXRyJRdOP3Nc+eV7dRxeuBc6Jk=; b=HIVoqhByea2kAFhqNP+ohMZd9wp9dWNRiTfs/L4fgeHPGnIfkQ4Cz9jPIBCxM/mDG4 jOauD4i5gCt6zXHJjAuKeZQcWsULAolJ4X5tvnZNNsaA8saBCj0jydZ4OOW2j92yPJPs wNEt2Puz1b/KnSHq5QFdlsab6ZgTbg6tWoQAHA067JGAka5/aZQPUcC4wkhJCXvp1hQq 3NjtdHFTTWiV0ooIGAvDSHtvVvp7CXhEhfS99rmgmAsYtSU9G1HYF7rnTn7K61vlyuHX aU9sO6UuwhkyyWoW7aHceLIU/nT6qT8maTHWa1H5Vt/ktqq+DoRNrtGzQwVJLcjl3l38 57ug==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.alibaba.com header.s=default header.b=JZmxo1ii; arc=pass (i=1 spf=pass spfdomain=linux.alibaba.com dkim=pass dkdomain=linux.alibaba.com dmarc=pass fromdomain=linux.alibaba.com); spf=pass (google.com: domain of linux-kernel+bounces-46477-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-46477-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.alibaba.com X-Forwarded-Encrypted: i=1; AJvYcCW47N66hFZiO2W2XtcGnMK00pOaOM6P3yWSf7byIkoVm0Dl6XneXORcYZeFGApVvUZCBT7a9bdE160MLGyu7LvialY2wA== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id v4-20020a05620a090400b007853d181f63si888720qkv.306.2024.01.31.05.17.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 05:17:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-46477-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.alibaba.com header.s=default header.b=JZmxo1ii; arc=pass (i=1 spf=pass spfdomain=linux.alibaba.com dkim=pass dkdomain=linux.alibaba.com dmarc=pass fromdomain=linux.alibaba.com); spf=pass (google.com: domain of linux-kernel+bounces-46477-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-46477-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.alibaba.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1CB811C20F97 for ; Wed, 31 Jan 2024 13:17:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D59DC7D400; Wed, 31 Jan 2024 13:16:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="JZmxo1ii" Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E2B879938 for ; Wed, 31 Jan 2024 13:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.101 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706707014; cv=none; b=GRBtkMrwgFh6cP3sY2zTIyWjYrUdqZb/qqhn8L3B4v9O9shSSsTrzzHfYr/sch+lRo0CjGN1eq1d1EPzOdRW0HTag85a99USxUfPFJLGE12B+GazaytAMyeOoWy8kcG4607Rc0oB9lFtX+JVEKaNMsZ6GEi8MNPqDWX+dnaAkp4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706707014; c=relaxed/simple; bh=U3vvmNEiNsFCDG9xGZjWzjdbxLLxBPphbAH/1T+fgBc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=BUpBPU7TVKtGGs4uTj3zXdBq5HSkJ0D6Y4I19a96VhAQ7uTeQCV0WTR+DRhrtmSqX/7pDQj9EZjAj+AjvaHTu2u8pAofVkSwo2OJQqgYHOLv4qA6OyFAXjdigvs2dp58Q4+vTV6uf4FBHvSi8BEizEZ6z86NKzf2CMzKi0WghhQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=JZmxo1ii; arc=none smtp.client-ip=115.124.30.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1706707003; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=R4BfaarR7H+2VERwphKn+Lf333CX+5PuQuJGhvUGjOc=; b=JZmxo1ii5jxqtCbBIC4cv78oIDn8OzE79ujXrULStacHpRb/+4iVsEi9FQIDulahxlqz8qKHec96myzMbBFDazAtoAf4W7jPQxFzTzOtyQ9AZM2woD/zBBKdTI5ASQ/+PafRhcUBWWn3OYMJbUMoCeVr+2cs+9OceEoOKIuqTfo= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R711e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0W.jsM4d_1706707001; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W.jsM4d_1706707001) by smtp.aliyun-inc.com; Wed, 31 Jan 2024 21:16:42 +0800 From: Baolin Wang To: akpm@linux-foundation.org Cc: mgorman@techsingularity.net, vbabka@suse.cz, baolin.wang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] mm: compaction: update the cc->nr_migratepages when allocating or freeing the freepages Date: Wed, 31 Jan 2024 21:16:26 +0800 Message-Id: <994af744828efe3c060128445204a56ab41e3ebb.1706706820.git.baolin.wang@linux.alibaba.com> X-Mailer: git-send-email 2.39.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789612054918494119 X-GMAIL-MSGID: 1789612054918494119 Currently we will use 'cc->nr_freepages >= cc->nr_migratepages' comparison to ensure that enough freepages are isolated in isolate_freepages(), however it just decreases the cc->nr_freepages without updating cc->nr_migratepages in compaction_alloc(), which will waste more CPU cycles and cause too many freepages to be isolated. So we should also update the cc->nr_migratepages when allocating or freeing the freepages to avoid isolating excess freepages. And I can see fewer free pages are scanned and isolated when running thpcompact on my Arm64 server: k6.7 k6.7_patched Ops Compaction pages isolated 120692036.00 118160797.00 Ops Compaction migrate scanned 131210329.00 154093268.00 Ops Compaction free scanned 1090587971.00 1080632536.00 Ops Compact scan efficiency 12.03 14.26 Moreover, I did not see an obvious latency improvements, this is likely because isolating freepages is not the bottleneck in the thpcompact test case. k6.7 k6.7_patched Amean fault-both-1 1089.76 ( 0.00%) 1080.16 * 0.88%* Amean fault-both-3 1616.48 ( 0.00%) 1636.65 * -1.25%* Amean fault-both-5 2266.66 ( 0.00%) 2219.20 * 2.09%* Amean fault-both-7 2909.84 ( 0.00%) 2801.90 * 3.71%* Amean fault-both-12 4861.26 ( 0.00%) 4733.25 * 2.63%* Amean fault-both-18 7351.11 ( 0.00%) 6950.51 * 5.45%* Amean fault-both-24 9059.30 ( 0.00%) 9159.99 * -1.11%* Amean fault-both-30 10685.68 ( 0.00%) 11399.02 * -6.68%* Signed-off-by: Baolin Wang --- Changes from v1: - Rebased on the latest mm-unstable branch. --- mm/compaction.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/compaction.c b/mm/compaction.c index 055687e6bd17..363c3e49fe80 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1882,6 +1882,7 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) if (order) prep_compound_page(&dst->page, order); cc->nr_freepages -= 1 << order; + cc->nr_migratepages -= 1 << order; return page_rmappable_folio(&dst->page); } @@ -1904,6 +1905,7 @@ static void compaction_free(struct folio *dst, unsigned long data) list_add(&dst->lru, &cc->freepages[order].pages); cc->freepages[order].nr_pages++; cc->nr_freepages += 1 << order; + cc->nr_migratepages += 1 << order; } /* possible outcome of isolate_migratepages */