Message ID | 97bff55b0141f2d01b47d9450a5672fde147b89a.1691162043.git.bristot@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:44a:b0:3f2:4152:657d with SMTP id ez10csp376314vqb; Fri, 4 Aug 2023 09:24:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHuLlRU6gx4QEdHSeb7s5WlNuyEVNb4LGZJHWlCJ8ueUSzMDp6/6g8RxnV2FBgFPVDzmSTr X-Received: by 2002:a17:903:487:b0:1bc:4adb:ed with SMTP id jj7-20020a170903048700b001bc4adb00edmr1937375plb.38.1691166261694; Fri, 04 Aug 2023 09:24:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691166261; cv=none; d=google.com; s=arc-20160816; b=zCAiEjjNTZ3YbdyF9L+XMgdMrdyg2DggIF7nl3HbXafwjUocuzgCyJM+hBGKqhFxkh mDvhD4eFlA+67KcP36uQQLgp75Rsq02oZsCdOwO2DT53cepB2kqjf2tubRY8klLLr3Z0 xL0S1bvZ7cl4Yl8II0d6XY8sE2/MqLCXUH1mRYbjcRkUFD5v1qrOtinQJgCBFFVYeeyA HhnHZHoI1oxDJUST5vzbIIpELByOewpibQWN6nQKiyeXVvDhmSitkGhJqhYzEGYSUnu6 IIOLQZ8EIoPSX1/dFeXRW7ZrS4sPMSpnlVZV3HMT4YLhM9eQLg9Fq7IrW5lTAwLUOema NhbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pUjcqVjZkiKA/Ka/Yjv8DW2X3nQC5bXJuKPjc/6SGYo=; fh=xOK/STtxvfdsFFx6oPoqk87WRzpPeY52tFJxVRRfZkU=; b=rbacFDlNAtaE6LNkLtN8MvO70NtnmfiTfN8mdeyQ0UftHv7K4bel6gxgQpm/NY++6s EmTV6p3WvG9ts92aPOsXvdH1Alo4sWxJUM1cnUKgywqoQ4tDddnfHPUcs9Z49vDwpDaW 41/kbNxUOVhUMHbgslsngJjyzyb0VHg7Bbw6rOxMtlAnIfBlf4mh4Avk0lAB0xI/VCyQ YV2PTf+O8YrlQLhFjVU7sP859LQbvLLWb4z3zG0rmMeklIx9U1PJZJQQXQvhXudNIn0F jtClFl7RaVG79rjfdKR0A4PdjyUciZV8FfzGnwGpLt80/4GF2/pC5AZqulSRE2sBPmHY uJdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I1i2HxIZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u9-20020a17090341c900b001aadba392c1si2062829ple.464.2023.08.04.09.24.07; Fri, 04 Aug 2023 09:24:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I1i2HxIZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232207AbjHDPwa (ORCPT <rfc822;wenzhi022@gmail.com> + 99 others); Fri, 4 Aug 2023 11:52:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232176AbjHDPw2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 4 Aug 2023 11:52:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B86E9170F; Fri, 4 Aug 2023 08:52:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 55E836207A; Fri, 4 Aug 2023 15:52:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F84FC433CA; Fri, 4 Aug 2023 15:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691164346; bh=tPmxXhf66VncNKJK+vndDb+F6Ii3wvgP4mAYTkpL4kw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I1i2HxIZaHgL1mgzvBOn23KDcqn+sK9vCqus1XqEdcnDg9GTncI29cMTFaospxsQA rPSC18psAjYUQQ9VXSGT9IuNF3GD7dG6DTezEFLKv7TxYd/rcwBeSemuZCkaBU/Nlu PJim7T0MNxbpa7YJE4qrJAPVQLAdGQx4aydG11DdqSOO3hCn3waCgDXGmI/QYdCX3N 8d/b0ygvA2p+f/nhJwB+aass2JRtbkj8/lmoRbA+wgngkZ7vRJjdVx4TxpfM3tNcpe vZfnSsTrqzhh4jaEQjIma5xSV98a49NmD5jVfmn1+zOVJHtuL4uG0g88EZOCy1cTpV X0IUqGLhQhSxQ== From: Daniel Bristot de Oliveira <bristot@kernel.org> To: linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org> Cc: William White <chwhite@redhat.com>, Daniel Bristot de Oliveira <bristot@kernel.org>, Masami Hiramatsu <mhiramat@kernel.org> Subject: [PATCH 1/3] rtla/timerlat_aa: Zero thread sum after every sample analysis Date: Fri, 4 Aug 2023 17:52:11 +0200 Message-Id: <97bff55b0141f2d01b47d9450a5672fde147b89a.1691162043.git.bristot@kernel.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <cover.1691162043.git.bristot@kernel.org> References: <cover.1691162043.git.bristot@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773316353763516511 X-GMAIL-MSGID: 1773316353763516511 |
Series |
rtla fixes for 6.5
|
|
Commit Message
Daniel Bristot de Oliveira
Aug. 4, 2023, 3:52 p.m. UTC
The thread thread_thread_sum accounts for thread interference
during a single activation. It was not being zeroed, so it was
accumulating thread interference over all activations.
It was not that visible when timerlat was the highest priority.
Fixes: 27e348b221f6 ("rtla/timerlat: Add auto-analysis core")
Signed-off-by: Daniel Bristot de Oliveira <bristot@kernel.org>
---
tools/tracing/rtla/src/timerlat_aa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/tracing/rtla/src/timerlat_aa.c b/tools/tracing/rtla/src/timerlat_aa.c index e0ffe69c271c..dec5b4c4511e 100644 --- a/tools/tracing/rtla/src/timerlat_aa.c +++ b/tools/tracing/rtla/src/timerlat_aa.c @@ -159,6 +159,7 @@ static int timerlat_aa_irq_latency(struct timerlat_aa_data *taa_data, taa_data->thread_nmi_sum = 0; taa_data->thread_irq_sum = 0; taa_data->thread_softirq_sum = 0; + taa_data->thread_thread_sum = 0; taa_data->thread_blocking_duration = 0; taa_data->timer_irq_start_time = 0; taa_data->timer_irq_duration = 0;