From patchwork Sat Sep 23 12:17:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 143921 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp211977vqu; Sat, 23 Sep 2023 07:34:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH1A8KJ2UyW9ijtsw75JGE03K4InDTohT/fw8XxdVITP/9eFbLI+wy+vjlU0uiQjT9pFSBE X-Received: by 2002:a17:902:8f97:b0:1c5:e9a8:dbc0 with SMTP id z23-20020a1709028f9700b001c5e9a8dbc0mr2053068plo.51.1695479678141; Sat, 23 Sep 2023 07:34:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695479678; cv=none; d=google.com; s=arc-20160816; b=ldh5H2q6xF1ATdRoxZCZx0sjyzmbkjO2dzqZFsYCyEDVXgrx2WO31SkitO9L9pKPHb 9Dhl3u63ZgeWjwv8wl/xWt9xUM7Itfd07qS3rywVnnRj0iV4w+xvO66OsWKRCfj0b8FT CcmHDKTgtVo2H4AI8uXg/LisdNxyzSzCD9sFWkdPXYRfFKVU6U4SE6pZ6bz/X44ze86Q uKeFALLWLMiNSsEYF3QSXsHL9BEigmoCKpDntdDkLINHkIeilX/n08XA0Hql2Csd9u// 6WtldEHBvibCFFtV7W5Pl9VN1vkN3amDnXjd140f3wWAP97Xfp+Am4T9ZZLbfyLHwKFp Fifg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MZ+x3+dMxPzCGceJF8/93Shpse4vUvBYF6v0b3D2kfE=; fh=P2LlrCXt6+gJz4MxCF/oA6XHLArZCLypbNPcnF1eVUE=; b=CXbEcFANa1MYEmDOqQo1XHI9tPidm1IVw08NMIYpJLH7CRpz+mNqyZ7QyGSRR+0KZK CQYGOMl+JpPVQ4zvX0Z0RI6RA894rT3jgF5IHU/n0cm/W4Yhl0xlm/NpTLhCTQe40ixM fOA3MD1PHdnzBmP6MnIMLfS/f+aUP6nQsMP+oYhml6/kz7+L112EaIFm5BmHRdxkUfeK QkML3Z5BoMGLHhIec3+SP9l9yt02BLxnKmy+FZ+dSCNOzq9mjVDArdaHE3CYJd6vgpHk UOegsLphhkQCJX9+2C/63Stm3tbmHn1LR0A3c2ry8+ANAbscpYceIvfk8jfWxuesIbai NIXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=pWrkqoYW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wanadoo.fr Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id jh19-20020a170903329300b001bba90f8b73si5761351plb.78.2023.09.23.07.34.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Sep 2023 07:34:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=pWrkqoYW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wanadoo.fr Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 6F9C980FCC93; Sat, 23 Sep 2023 05:17:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231343AbjIWMRU (ORCPT + 29 others); Sat, 23 Sep 2023 08:17:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231405AbjIWMRT (ORCPT ); Sat, 23 Sep 2023 08:17:19 -0400 Received: from smtp.smtpout.orange.fr (smtp-24.smtpout.orange.fr [80.12.242.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C804199 for ; Sat, 23 Sep 2023 05:17:11 -0700 (PDT) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id k1ZLq0FE4ttXNk1ZLq9cSW; Sat, 23 Sep 2023 14:17:10 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1695471430; bh=MZ+x3+dMxPzCGceJF8/93Shpse4vUvBYF6v0b3D2kfE=; h=From:To:Cc:Subject:Date; b=pWrkqoYWrs+z0eZtol7HHfGiyoEXhV/dOMobQxnDEhy6fd6vb/VVWl+xgiAj4FXnz 4PvjXGd+S2o3TMbt4Ut7bO62rSgDkrpmxKcfbTt9ZBgTg+WQ1X+cRAIwr8ZPvxx+TL unF0hAolnIG5mmLcu0WkE4eqgFOYmtiwp+867RTzbgveloEchATdFmfzfB359NaQHC y2nJVmMr/0cV50aDKXwfsgFzViVX8Rul99nI4gR5DjZMggg/qrfGY34L7oFPnBMrvX SvRULTOQBPjgKYToaahMrfT2APagS9YohRwfVWOAZ9IrPna8uYXnvjEX6NrQaznMMa +RLYynY5dib/w== X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 23 Sep 2023 14:17:10 +0200 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: [PATCH net-next] iavf: Avoid a memory allocation in iavf_print_link_message() Date: Sat, 23 Sep 2023 14:17:05 +0200 Message-Id: <966968bda15a7128a381b589329184dfea3e0548.1695471387.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sat, 23 Sep 2023 05:17:30 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777839299040806735 X-GMAIL-MSGID: 1777839299040806735 IAVF_MAX_SPEED_STRLEN is only 13 and 'speed' is allocated and freed within iavf_print_link_message(). 'speed' is only used with some snprintf() and netdev_info() calls. So there is no real use to kzalloc()/free() it. Use the stack instead. This saves a memory allocation. Signed-off-by: Christophe JAILLET Reviewed-by: Przemek Kitszel --- drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c index 8ce6389b5815..980dc69d7fbe 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c @@ -1389,18 +1389,14 @@ void iavf_disable_vlan_insertion_v2(struct iavf_adapter *adapter, u16 tpid) static void iavf_print_link_message(struct iavf_adapter *adapter) { struct net_device *netdev = adapter->netdev; + char speed[IAVF_MAX_SPEED_STRLEN]; int link_speed_mbps; - char *speed; if (!adapter->link_up) { netdev_info(netdev, "NIC Link is Down\n"); return; } - speed = kzalloc(IAVF_MAX_SPEED_STRLEN, GFP_KERNEL); - if (!speed) - return; - if (ADV_LINK_SUPPORT(adapter)) { link_speed_mbps = adapter->link_speed_mbps; goto print_link_msg; @@ -1452,7 +1448,6 @@ static void iavf_print_link_message(struct iavf_adapter *adapter) } netdev_info(netdev, "NIC Link is Up Speed is %s Full Duplex\n", speed); - kfree(speed); } /**