From patchwork Wed May 24 12:52:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Rosin X-Patchwork-Id: 98483 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2825196vqo; Wed, 24 May 2023 05:58:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5+LVsvU7AmeXcl8cPdwU8WtKkCQW3ByaiYb6J2mIlomsFabZD0vCqJQlfp93fkJVZmfn0I X-Received: by 2002:a05:6a20:c791:b0:106:25b3:2f92 with SMTP id hk17-20020a056a20c79100b0010625b32f92mr16477173pzb.52.1684933136194; Wed, 24 May 2023 05:58:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1684933136; cv=pass; d=google.com; s=arc-20160816; b=o20tRCU5Jlx5sseb6pRkce8kmlAcWZDmep3/aSLBwUGwCKQOIEhL130IyNpPbCNNEC vt2CEH6oTWGFv+6wuzOCnydmggCIAq/FUCxs2PirmbESkiid92DXQCuX/D3lCWEx9YK2 8/A1fCpp5TOQ1hqc5c6wpbZ1UZE9V4RlP0muS1JgXagymBeqG3AFroyqkcdw0jeyJ/VQ V1/rXkgGkbssDPCjiMKkRydz5Skdc/BWidIuvQ4D2HLfJC9obonat8VqfHJtG84fEK3p NqPxOpdXY/NF+5T98YfqUAEDXYxF0TJifqxtr7ejT2oIrD04xKpKUZAWzxcQJA+TE35Z bpWw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :in-reply-to:content-language:references:cc:to:from:subject :user-agent:date:message-id:dkim-signature; bh=Wmk+PTR2uWy+mNoxLZnuwRlfJDqTBRNtaWyXPwDpbF0=; b=FEmd5gB6aqoxIou6LBLI48islZe+ixPpZ1Kbdz/m5kC7ggC0SxCXyXhdOQCIxnAoyh I58CKvpieZwPlvYlprzJy9OvpZAvg97VSK3+/WKQDoAGbs7VQykXmaXbZpNdt8EU/rr1 WsCLdtOkYAmYvxDWuAuMPeQ9oGewwugOkTOizRDaa16PO4uCzU37kmFcoTyngCiS0pKR mpLX9sx2tGFiO+v2sNh/5q5xrLhqPo2rH25sb7bZv/tbv4tvqZpCDgN724j0NuYVKeX8 x2cqXCwwO1dJg6PNDjse05SA+s7ds8DdBjjwdbJPdKSulrGXBcSRi8R9UyLa9o+EjQAM BmEw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@axentia.se header.s=selector2 header.b=GllLCYET; arc=pass (i=1 spf=pass spfdomain=axentia.se dkim=pass dkdomain=axentia.se dmarc=pass fromdomain=axentia.se); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n7-20020a6543c7000000b00520e69b7439si8030959pgp.560.2023.05.24.05.58.40; Wed, 24 May 2023 05:58:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@axentia.se header.s=selector2 header.b=GllLCYET; arc=pass (i=1 spf=pass spfdomain=axentia.se dkim=pass dkdomain=axentia.se dmarc=pass fromdomain=axentia.se); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233258AbjEXMwr (ORCPT + 99 others); Wed, 24 May 2023 08:52:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231235AbjEXMwo (ORCPT ); Wed, 24 May 2023 08:52:44 -0400 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2101.outbound.protection.outlook.com [40.107.21.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 707E19E for ; Wed, 24 May 2023 05:52:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IasvVHNYDaZIaxUfNmJ33W8lwqVxaqSSLGGCi/25lkgpFi9h/iI/i5smIOuqpZ8wJ92NPrVDZ+/OMwTReWWCKqq9GGZi8QUaiVDWTnp+HjNJbcomcljG0U7+7tPAABJ9WOVLBKYbIgsmaiDTXKMylq/wVRgMpJ4hGjmzd/Q/8b4eZh2UFYaEMGpT8F6OZ0WATO3MfXHBkC6uqKOetwIzGXZSXqJEs1DmhIowHVHqVDOVLAXYZuTqaj6HtK+FDRj9JH6WEWHBi9nMssgLXq3lMko2y0ndM/qIVpDzJq6BfvKwb05D+WzcMAX6CLYCpzNdvbV/sLR1fwyzG7fJRLtFEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wmk+PTR2uWy+mNoxLZnuwRlfJDqTBRNtaWyXPwDpbF0=; b=PiSiYrSj2gaOqJ2ImiRFI/Y1SxyleCzHfcJTrDhfXi19z5KsK2kZWS9SQmnzBXgBIarDV3sjAJx6vMTUEhHvziKcEvPNAKyBuUeUaEPcedoN7HoHWhlOVUAzpdwx6B7r7e2wRWhpWyD+6IQJ7QRmYiQ07Lv0ZoxJe4N/H7TGsp9R9YXSpzTpwuHCNuKaXkZBq0NygJcEbnnTwJtWhyUCUzyXsuSrHQtxZH8sv1eW5fVUmcfzEk2QiJfzaLkXIiu5NjLmeCNziSvZPbhSmvxrlh+AqHmrXV5NtnyIliKupUNgMfU1LVmvV728+0a7TTYzSR5VDSytVCJkdptBcH+0aA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=axentia.se; dmarc=pass action=none header.from=axentia.se; dkim=pass header.d=axentia.se; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axentia.se; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wmk+PTR2uWy+mNoxLZnuwRlfJDqTBRNtaWyXPwDpbF0=; b=GllLCYETwYyzNoNXiwPI2sGcoEaX6c9wXe4A4gYOBgrXiR1+yWKGUD6b7GHZpempYZVGPV8yjjzOaJTzRWasq4YJBgiusB1ws1wBdS0PfjeAVStEpl3FBdUQBUfKl4VWlMhDkp8PoKUpxik2nO1QSjcxiKZAXizfDta7jhYH7yE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=axentia.se; Received: from AM0PR02MB4436.eurprd02.prod.outlook.com (2603:10a6:208:ed::15) by PAVPR02MB9229.eurprd02.prod.outlook.com (2603:10a6:102:326::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29; Wed, 24 May 2023 12:52:40 +0000 Received: from AM0PR02MB4436.eurprd02.prod.outlook.com ([fe80::681f:7dcc:3f6c:3b36]) by AM0PR02MB4436.eurprd02.prod.outlook.com ([fe80::681f:7dcc:3f6c:3b36%5]) with mapi id 15.20.6433.015; Wed, 24 May 2023 12:52:40 +0000 Message-ID: <946cea0c-6d7f-c2e3-4412-4967ece40b94@axentia.se> Date: Wed, 24 May 2023 14:52:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: [PATCH v2] mux: mmio: depend on REGMAP as the code has that dependency From: Peter Rosin To: Philipp Zabel Cc: Randy Dunlap , "linux-kernel@vger.kernel.org" References: <64cf625b-2495-2382-0331-519d1cab0adf@infradead.org> <89199aca-5b57-e8df-03ca-b2658ee9d8b3@axentia.se> <20230210115625.GA30942@pengutronix.de> <31f2a49f-bc48-d502-df31-667ef1a83fab@axentia.se> Content-Language: en-US In-Reply-To: <31f2a49f-bc48-d502-df31-667ef1a83fab@axentia.se> X-ClientProxiedBy: MM0P280CA0117.SWEP280.PROD.OUTLOOK.COM (2603:10a6:190:9::32) To AM0PR02MB4436.eurprd02.prod.outlook.com (2603:10a6:208:ed::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR02MB4436:EE_|PAVPR02MB9229:EE_ X-MS-Office365-Filtering-Correlation-Id: 00ce744a-d253-4d8a-a92c-08db5c55c25f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: McunrYeIJJKS/dhQ9eM+gtK9XmCCE00XVhN1N8HK2EMXDAu4Yqnu5wlHtN6C3++U8PNOuJe5mEH++tQNPSnPFtorTdDd6NOJt+RDHdRACSjF01Kc3FC+LPbGymhc+/ndo32oSPHlu1nTQubKRAbRxP7/g/4dGN5+2TBbLSGY2AL4GI+aPmqR6Ib+gn/P+bjpdJ03A4BL/wUJZVJPNnVrQ+J7fTIU0z7SohQy5C91Nx2gYeFfnrYWbGgT7XSBaJPbwU/KC3uvZAB5oXSvDVHj0Wbm33edk60sBS4Iy0ARwVgQOoJEbN4rLJraJIaUOaoXVwQ019q3loKUpOmh88mbr5BJHwbKGcALQdH9fOX2ms1ELgS8bF4oGqbbjHxXtES/Y2QMidR2ye8z5PEcUWno7OfnnoBRG9lijhmO7lW4wNB9WDzroz5UKJKiYhmLNDeL1tOAKtFkgCLKlDGVjh899EcpZJvxVLHADmbx7wX88o7QXO2Vb4Rk2Ow9PUsXo2aGvRh5YnTEMiGqcsalMoHcD+9dxA0A4yuHEBC1ADb0jKk+j6fV86GmLDbq8eTR3DysMeXRYuyjsxdsCIp/h1f23I0q6NgsljeuszSXNMqq/UbGBsajkIyIRNOrn1Q2m3o1s8EAdoCYhmwclMulYyxy2Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR02MB4436.eurprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(376002)(396003)(136003)(39840400004)(451199021)(31686004)(83380400001)(966005)(5660300002)(54906003)(66946007)(66556008)(4326008)(6916009)(6486002)(316002)(66476007)(41300700001)(86362001)(478600001)(2616005)(31696002)(26005)(6506007)(6512007)(186003)(36756003)(8936002)(2906002)(8676002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?4nsB6AMmBtcFDGs6DHVemcMrvrZS?= =?utf-8?q?M8t9A8vt8tqNvYyYeuS9a4HHIlrSrP/iIPEvfP4g01uqiJrz0uzRBW+YeV/A5lxeR?= =?utf-8?q?0m2xZppdR2s1GjMEFj0I99VG/0QRKNlemFgRhXVwV1SCkU5QZyfCb27YRVygEvBie?= =?utf-8?q?u368TAttEuRGpHKbGW5/N3jqlbt+WsNFPHW+TMXkrUqJ2FCwoHIMRYtWyJkxXmYql?= =?utf-8?q?qCt/ivJX/6FQiFEMblqPBFV/01B/VHLTekxw1t96Vpy6NrX01PPOHUsp8Xmj0rgNc?= =?utf-8?q?llenRbOVCxeIuLfc9YEYggFUfXbs+Khou/pJcDu/2MBbIH2acSghEASYik5leuKdx?= =?utf-8?q?mYpx1z8+2JFyebC9O7etFiNAkzzAy6YlQ/xCaedZeVKcmorV1sABtFbix/ZtJvSSD?= =?utf-8?q?lswBCmORNmwI/h8d5wwR7wsEQsMzASVY+o2Z3KVyVyGzRNC7IcMrVGi+vslqI2xwo?= =?utf-8?q?nJS5JXyNGg5C9r5ZTqxhvKJB8Y9f85AwEzImTU4BKV/F0vl5NMHHS8/0rF3bBz2g0?= =?utf-8?q?z6wjeClo9m+LqsYGX5WJsW6Q4bVoUhd0kJKThzRVWwrRIIFPVIJsIPbyf4zO6vZVm?= =?utf-8?q?+TMlMjO6Dx/SzlV8IO2Wi4lcRJERO7KCpat6BLHSybqHFaiUedigitybcZ3TQpN5W?= =?utf-8?q?gQ23Yk9F9w1E+De890McmEneFG5JYJZ2sEBLyg4/vUqH5RZWq68Gtl2g8vAMPIEYr?= =?utf-8?q?0S0oRHOnm55qonYDl37NNK9UK4l7sc7xlx2Z0KkmwxR0ELmyxYREaUVEo3cdoUwBL?= =?utf-8?q?FNktkbT3wqG6yeK8bgPaZLyl4In7j9ZYGW7iykgs+fYdkrRRX6eV3xkuiiUvCj4Ae?= =?utf-8?q?1ASlw7plkDfdaBlz6/d4+P/d7bIjs37ei5qcymf9Gz+w3Zn+Ju8AY4K+HY9pt0kX/?= =?utf-8?q?+WNRXPp0h56HnwQvkkytBRUQSAJGRBRuJO3QDTeKQGd7Y19lA5CKWutCd3qqTkKu1?= =?utf-8?q?daL9Mmbhce1aohBWFwLeSDWtk9/2GPZOeiZWCVdFc3dqzd+7IszXSkyyf/m7HpHWU?= =?utf-8?q?8Nhu2jnd0/xJbJXBaGBNQbj8bEqUbXXGjMLyGsWH54NCddRPIVW3XY9dm4O95FrXq?= =?utf-8?q?I43imEyC10bIzGroAe+PuAAxuoOZct9Bk9oQ04Y7PkaR4z25+sRB16l6W4IafhbtL?= =?utf-8?q?yuUWzJ9bA/v//wzw8eD/+gB7qibOonoB03EIjRN/IxNjmLcntsJBbHWEKufjcDaV7?= =?utf-8?q?wWHSytGGwn+HyIabLbj6JodEzXzO5H+bszE28FFUXbHNEE4+jI7UKpKprxkSC+Ysa?= =?utf-8?q?OEwZfjrmnINICZ32c5+ODi7R4v/tCNCDlszPTlZ/e1iLvyLuppZW4ZxSVumPq1/lh?= =?utf-8?q?mBnlewBnOtZ6EcojGBYw3hqPe6o0LqIxlSEx+KCNzSsp5oV5V2spdg3LQlsnqj6ic?= =?utf-8?q?8tqpeK/61HFMu077xFA6tgdVizsrvEft7MvkkXum0BboJUZ+cRlKpVpbFiWaqRivI?= =?utf-8?q?1/d0LwmWmLEQqIAhM3YevcCofWNpt99rN1mgjQz2F2KjhDMpk8bLWKGgCbMEhoTqR?= =?utf-8?q?udxthwvm3dF5?= X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-Network-Message-Id: 00ce744a-d253-4d8a-a92c-08db5c55c25f X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 12:52:40.7784 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eeZUnu3WPwha9xOhhejuGUkMUOKs0PPyNVAt+LRgZEaRc4IqPXPkrumOt9UPF43w X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR02MB9229 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766780448330610019?= X-GMAIL-MSGID: =?utf-8?q?1766780448330610019?= If CONFIG_REGMAP is not active, the build errors out like this: ../drivers/mux/mmio.c: In function ‘mux_mmio_probe’: ../drivers/mux/mmio.c:76:34: error: storage size of ‘field’ isn’t known 76 | struct reg_field field; | ^~~~~ In file included from ../include/linux/bits.h:21, from ../include/linux/bitops.h:6, from ../drivers/mux/mmio.c:8: ../include/linux/bits.h:23:28: error: first argument to ‘__builtin_choose_expr’ not a constant 23 | (BUILD_BUG_ON_ZERO(__builtin_choose_expr( \ | ^~~~~~~~~~~~~~~~~~~~~ ../include/linux/build_bug.h:16:62: note: in definition of macro ‘BUILD_BUG_ON_ZERO’ 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); }))) | ^ ../include/linux/bits.h:37:10: note: in expansion of macro ‘GENMASK_INPUT_CHECK’ 37 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l)) | ^~~~~~~~~~~~~~~~~~~ ../drivers/mux/mmio.c:96:29: note: in expansion of macro ‘GENMASK’ 96 | if (mask != GENMASK(field.msb, field.lsb)) { | ^~~~~~~ ../include/linux/build_bug.h:16:51: error: bit-field ‘’ width not an integer constant 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); }))) | ^ ../include/linux/bits.h:23:10: note: in expansion of macro ‘BUILD_BUG_ON_ZERO’ 23 | (BUILD_BUG_ON_ZERO(__builtin_choose_expr( \ | ^~~~~~~~~~~~~~~~~ ../include/linux/bits.h:37:10: note: in expansion of macro ‘GENMASK_INPUT_CHECK’ 37 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l)) | ^~~~~~~~~~~~~~~~~~~ ../drivers/mux/mmio.c:96:29: note: in expansion of macro ‘GENMASK’ 96 | if (mask != GENMASK(field.msb, field.lsb)) { | ^~~~~~~ ../drivers/mux/mmio.c:102:29: error: implicit declaration of function ‘devm_regmap_field_alloc’ [-Werror=implicit-function-declaration] 102 | fields[i] = devm_regmap_field_alloc(dev, regmap, field); | ^~~~~~~~~~~~~~~~~~~~~~~ ../drivers/mux/mmio.c:76:34: warning: unused variable ‘field’ [-Wunused-variable] 76 | struct reg_field field; | ^~~~~ REGMAP is normally "selected", but that causes a recursive dependency. But since REGMAP is "depended on" in other places, do so here as well. The (implicit) REGMAP dependency was lost when the strict dependency on MFD_SYSCON was removed. Reported by: Randy Dunlap Fixes: 8ecfaca7926f ("mux: mmio: add generic regmap bitfield-based multiplexer") Link: https://lore.kernel.org/lkml/64cf625b-2495-2382-0331-519d1cab0adf@infradead.org/ Signed-off-by: Peter Rosin --- drivers/mux/Kconfig | 1 + 1 file changed, 1 insertion(+) Note, there is a patch in linux-next that removes "|| COMPILE_TEST" from the pre-existing depends. Cheers, Peter diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig index 80f015cf6e54..7f07ca06eb2b 100644 --- a/drivers/mux/Kconfig +++ b/drivers/mux/Kconfig @@ -48,6 +48,7 @@ config MUX_GPIO config MUX_MMIO tristate "MMIO/Regmap register bitfield-controlled Multiplexer" depends on OF + depends on REGMAP help MMIO/Regmap register bitfield-controlled Multiplexer controller.