diff mbox series

[v3,2/2] dt-bindings:pinctrl:at91:Adding macros for sama7g5

Message ID 936fd3060662becd5485e32d5947286fcf0a3502.1677520830.git.Ryan.Wanner@microchip.com
State New
Headers
Series Sama7g5 drive strength options updated |

Commit Message

Ryan.Wanner@microchip.com Feb. 27, 2023, 6:07 p.m. UTC 
  From: Ryan Wanner <Ryan.Wanner@microchip.com>

Adding macros for sama7g drive strength.

Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
---
changes since v1:
- Fix ABI break.
- Add explanation for drive strength macros.

changes since v2:
-Fix subject prefix to match subsystem.
-Add more in-depth discription of sama7g5 define values.
-Fix formatting issues.

 include/dt-bindings/pinctrl/at91.h | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Feb. 28, 2023, 10:56 a.m. UTC | #1 
On 27/02/2023 19:07, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
> 
> Adding macros for sama7g drive strength.


Look at output of the command I gave you. Now look at your subject...
Missing spaces.

BTW, it is "Add", not "Adding".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> 
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> ---
> changes since v1:
> - Fix ABI break.
> - Add explanation for drive strength macros.
> 
> changes since v2:
> -Fix subject prefix to match subsystem.
> -Add more in-depth discription of sama7g5 define values.
> -Fix formatting issues.
> 
>  include/dt-bindings/pinctrl/at91.h | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/include/dt-bindings/pinctrl/at91.h b/include/dt-bindings/pinctrl/at91.h
> index e8e117306b1b..a02bee76b1fb 100644
> --- a/include/dt-bindings/pinctrl/at91.h
> +++ b/include/dt-bindings/pinctrl/at91.h
> @@ -42,8 +42,21 @@
>  #define AT91_PERIPH_C		3
>  #define AT91_PERIPH_D		4
>  
> -#define ATMEL_PIO_DRVSTR_LO	1
> +/*These macros are for all other at91 pinctrl drivers*/
> +#define ATMEL_PIO_DRVSTR_LO	0

That's still ABI break, isn't it?


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/include/dt-bindings/pinctrl/at91.h b/include/dt-bindings/pinctrl/at91.h
index e8e117306b1b..a02bee76b1fb 100644
--- a/include/dt-bindings/pinctrl/at91.h
+++ b/include/dt-bindings/pinctrl/at91.h
@@ -42,8 +42,21 @@ 
 #define AT91_PERIPH_C		3
 #define AT91_PERIPH_D		4
 
-#define ATMEL_PIO_DRVSTR_LO	1
+/*These macros are for all other at91 pinctrl drivers*/
+#define ATMEL_PIO_DRVSTR_LO	0
+#define ATMEL_PIO_DRVSTR_LO_1	1
 #define ATMEL_PIO_DRVSTR_ME	2
 #define ATMEL_PIO_DRVSTR_HI	3
 
+/* These macros are for the sama7g5 pinctrl driver
+ * Low D is low drive for GPIO mode or any non high-speed peripheral else Type D output impedance
+ * Hi A is high drive for GPIO mode or any non high-speed peripheral else Type A output impedance
+ * Low C is low drive for GPIO mode or any non high-speed peripheral else Type C output impedance
+ * Low B is low drive for GPIO mode or any non high-speed peripheral else Type B output impedance
+*/
+#define ATMEL_PIO_DRVSTR_LO_D	0
+#define ATMEL_PIO_DRVSTR_HI_A	1
+#define ATMEL_PIO_DRVSTR_LO_C	2
+#define ATMEL_PIO_DRVSTR_LO_B	3
+
 #endif /* __DT_BINDINGS_AT91_PINCTRL_H__ */