From patchwork Mon Oct 24 21:24:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nam Cao X-Patchwork-Id: 10392 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp697725wru; Mon, 24 Oct 2022 16:14:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7hl3EdeLBq9ixp+X81zCp/Hd+sPR216klelghJDI/BOZchrd/HITdA//QLhTNJ08CeM65I X-Received: by 2002:a05:6402:847:b0:453:943b:bf4 with SMTP id b7-20020a056402084700b00453943b0bf4mr32019848edz.301.1666653286018; Mon, 24 Oct 2022 16:14:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666653286; cv=none; d=google.com; s=arc-20160816; b=vPuieLNMtc8O5TmZ3LS63/gt9A+FxtjD2S3obahRIGCRPH78YQ6czCdXKYAfG1TM3V EMyAaoKY1k0yceVwdzXFCmYsvhkPC9y022SKypdbVFdD7TsLc6BSPdjn785IPzmYh2gu bJFbRk2vmFhercy+8LDndkp0uMkQOsu413GWlXZnEzckvkDNr7tcwuCE+vhiekCUZHYK WoCb3/QyUQLAsPsZ2evO0MgeueGgTw/UHBI04UsvRq7hO5l3Iwoa5JmHvtDNa/qh3mg1 enBXeFF9W9UD1QSS2n/A8Gtowml9tmzJEm3tO58xA7f2Nt0ljuU4bAaRjixmKwteFHhQ X/Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=O4TfgwncnU/HwDrEet2mPSVCmyGRLpO7aAKR17oXTOM=; b=yiUe+6iyebPUqBOhRw6W39QbuEH1SrAPBv2WDwBM6V2P17Wl/33EEWMjCMk3Vb6VTM yOxARWPBx8VIqQJFMVK+M4JreoW9jDArGrUgiF14EWIGTEDy80qQXOCZDi622BzxJKSC njLmGElcGvprh/2V+9Pzr7FGngqn3Oyczn2bEGXXvDy2/QpGE5Tfzm9asGOF3dCCngXv AQdTjLgkTzKHRnAQCPvFbvXg9elOSfuyyYvDqpMNNuokz3urcFFS9+SqwUHJMhaqYXl+ B8sM2kh1pHo4R10Gan6gFKOdPAuipEV1+NtSl2R4plO11bf1zjaxioWYfcZtraky9Xhs 8seA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ZvCH3I05; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr21-20020a170907721500b0072fc714c92fsi1064571ejc.902.2022.10.24.16.14.19; Mon, 24 Oct 2022 16:14:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ZvCH3I05; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230204AbiJXXEg (ORCPT + 99 others); Mon, 24 Oct 2022 19:04:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230310AbiJXXDd (ORCPT ); Mon, 24 Oct 2022 19:03:33 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78B9632BB27 for ; Mon, 24 Oct 2022 14:24:32 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id z97so33527734ede.8 for ; Mon, 24 Oct 2022 14:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O4TfgwncnU/HwDrEet2mPSVCmyGRLpO7aAKR17oXTOM=; b=ZvCH3I055bsQxyZ2EFbe/WK0etuo4Ftc4KWHjKWllkkcQHDdtU9Wih+G9leYJphdlX Eqo72/eHiCAO9cKSri1OYJOUn7RxXYE8rqflcXWY5suZSedpJykeoNPQImJy9RNN7zF5 jG0e+X9NHnXcyOZuXz0CMwmvzUSkQ7qWuAbk4bEIGCZk6nUsh4RJKCXjAY55hGqmPAib jc36hCrwkdajUgB6zbzmUgw728cGkuBMXe91Kurk5XmL5KvB5cGJ6jBlQJvp4RQVmVRC k5kucKtxMeIEd6E5Rc6hb/Y7ZV0/gatFY7c8jwDT+tg6kQalpdC6nsclVEeaxYVnOYKm vJIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O4TfgwncnU/HwDrEet2mPSVCmyGRLpO7aAKR17oXTOM=; b=599izUmLkPR8Y2iWu7QYvxbe9hMRYFL5/CaA/loS3DGNrhZ1qvxPrr54a1pSW79bsS +PbphnSJEF/G/QeLQlP0LrnTGwuO+odXdsfH4UNs7EFhUN6YrauN7XT389k2yGMc5Buw DNmvpBk57treA/LUMfRvxfeoUV5/+xhLOvRvnNZK4DY6mSnDr9/XpYdRb+avXyU0CzSs UnqB8RVNVBJY3gnS16vi+dPOfqsFfioGs9imUb6tsEpNZJL97Q7fgZwQtIgEQedde58V vdInUcVePiybOtCOCYDHaX6jCeiAS4ZKlhZrzfOLs90NO8cpqJICElyLG9Hnl287uJJO 9rTQ== X-Gm-Message-State: ACrzQf3qz450WMlRe5Ni8ssHp4WqlNWUPbzkKOPLzIHf6bAZ4l0nbj1/ sSrUu9IYCD1bHyqp3K2UTvU= X-Received: by 2002:a05:6402:40c7:b0:461:ecdb:1c41 with SMTP id z7-20020a05640240c700b00461ecdb1c41mr3511218edb.288.1666646666234; Mon, 24 Oct 2022 14:24:26 -0700 (PDT) Received: from localhost.localdomain (ip-217-105-46-178.ip.prioritytelecom.net. [217.105.46.178]) by smtp.gmail.com with ESMTPSA id r1-20020a1709061ba100b007a9c3831409sm379354ejg.137.2022.10.24.14.24.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 14:24:25 -0700 (PDT) From: Nam Cao To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman Cc: namcaov@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] staging: rtl8712: check for return value of _r8712_init_xmit_priv() Date: Mon, 24 Oct 2022 23:24:08 +0200 Message-Id: <9314f33cc91f69d7d5c79912fe55136faca7927f.1666645510.git.namcaov@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747612635907289389?= X-GMAIL-MSGID: =?utf-8?q?1747612635907289389?= The return value of _r8712_init_xmit_priv() is never checked and the driver always continue execution as if all is well. This will cause problems if, for example, buffers cannot be allocated and the driver continue and use those buffers. Check for return value of _r8712_init_xmit_priv() and return error (if any) during probing. Signed-off-by: Nam Cao --- drivers/staging/rtl8712/os_intfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c index 47d7d998fa86..ade57dd89eee 100644 --- a/drivers/staging/rtl8712/os_intfs.c +++ b/drivers/staging/rtl8712/os_intfs.c @@ -308,7 +308,9 @@ int r8712_init_drv_sw(struct _adapter *padapter) ret = r8712_init_mlme_priv(padapter); if (ret) return ret; - _r8712_init_xmit_priv(&padapter->xmitpriv, padapter); + ret = _r8712_init_xmit_priv(&padapter->xmitpriv, padapter); + if (ret) + return ret; ret = _r8712_init_recv_priv(&padapter->recvpriv, padapter); return ret; memset((unsigned char *)&padapter->securitypriv, 0,