From patchwork Sat Apr 15 16:28:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 83740 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1138336vqo; Sat, 15 Apr 2023 09:43:32 -0700 (PDT) X-Google-Smtp-Source: AKy350Y+rZDrRUzuK50j1v8AwOLRiLAL/z85ScAP/r6aE+M2VioyrRcQOc7OczVKCcX70m1y/+qG X-Received: by 2002:a05:6a20:8b0a:b0:e8:d62c:4aa9 with SMTP id l10-20020a056a208b0a00b000e8d62c4aa9mr9484511pzh.24.1681577011797; Sat, 15 Apr 2023 09:43:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681577011; cv=none; d=google.com; s=arc-20160816; b=HMRjMB6lW0gkkK1NSxvjYqvceDCUFheeB9WlV4q1j6FtBTNaiDwoAZPIr2f4LPzpZT A+44WD/0Rm/umXgKl0oeoVGzxEEudPTl83NR/JDAMXzWU4uYKWYwkrnAQZin1zNO24SL i1YJa1OxUHkma7KP226KcH0KAasxh8BQvHWBzEfgN7K2eaMnazU4WhuekgDzGu0qkPBH sB7qaA2JjNuhmKkEo1Kw+ZaLE6XY6Fhhep3GJNbRxaR5tezapuYMKkLpRhx51qXO+enb 29GMItlCT7SRqookBaHaScNw08Dxtz57h9zrOVzGEUuXOrxmpoujO6LVIqB52ayEBEuT bBmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=YsiWv6bqCCOxDwt4FovLlKlpgNUCDzr+TCLIp5uyNw0=; b=My82ijYTMo8PCXVaT5kqFSEEkugICYUjuexYgbGW4qajLCJSIPRk69GgtvcgZ2GLIl Jlvp/EsUfK4ylXkgizjrFwBk8V4rQxhJakIK1PhNZyfwz0LECFz+fsTJG3oU7dLqTRf3 a68S0NZ9fwNnVPgq4RvxJMb47ayA8GnnaTKnL71NLs6clCmmSZmWFjRoZquP8DrITzjo OwQpNeoi3hRSBFWRWd2T+DO5dFfu2VmVgZ36rR2+buZ1HlN53Xnn4nxNchHh+stZTB5R vLh11RYpHBPg3H2YpZfklWQP1pjGowkdKMPCP6lPo7jPBaOHYpeFDJrluhrh4NnGF5EM 48Xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@orange.fr header.s=t20230301 header.b=GAVwofU1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k63-20020a638442000000b0051b5d2315f2si6694176pgd.734.2023.04.15.09.43.17; Sat, 15 Apr 2023 09:43:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@orange.fr header.s=t20230301 header.b=GAVwofU1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229997AbjDOQ3F (ORCPT + 99 others); Sat, 15 Apr 2023 12:29:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbjDOQ3D (ORCPT ); Sat, 15 Apr 2023 12:29:03 -0400 Received: from smtp.smtpout.orange.fr (smtp-15.smtpout.orange.fr [80.12.242.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 227AC40F5 for ; Sat, 15 Apr 2023 09:29:01 -0700 (PDT) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id nilnpmo5muZFDnilnpv4vy; Sat, 15 Apr 2023 18:29:00 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1681576140; bh=YsiWv6bqCCOxDwt4FovLlKlpgNUCDzr+TCLIp5uyNw0=; h=From:To:Cc:Subject:Date; b=GAVwofU1F+a6cmdEitjtAipdJku2R+oAahfLTu7vabqbm/q2LPX9MKr2CMwU/jNwR /Ia55aBwxSTRQFLF9aESomYpnQyn+y4rNYvyz2wbZ8nKbGDE04hLFMnqXw7eDLeXfR sRmr5z5M4QM3Dx86XWNuvFtIuWL/FnH+Lo00rT3mnt7mfEnPzxxsZ+eFjUPSwvsb3R L///3xfGzxAonw74NTwHO51DvST7KfgthCzF9A5E1ZnL4f6boqmoMyE6f0ohOVbkNh KCbHTbFv+TXmXWZ8SSzqEhSRM8zdadxx8LooDqPMKTotkcrBKGDhnFAZfzaOSRAbVW nTp/ljV2z65/g== X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 15 Apr 2023 18:29:00 +0200 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: Daniel Scally , Mauro Carvalho Chehab Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-media@vger.kernel.org Subject: [PATCH] media: ov5693: Simplify an error message Date: Sat, 15 Apr 2023 18:28:58 +0200 Message-Id: <928f2f70de241d0fa66801b46d736ad0f881eb72.1681576102.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763261297083099643?= X-GMAIL-MSGID: =?utf-8?q?1763261297083099643?= dev_err_probe() already display the error code. There is no need to duplicate it explicitly in the error message. Signed-off-by: Christophe JAILLET Reviewed-by: Daniel Scally --- drivers/media/i2c/ov5693.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c index e3c3bed69ad6..d23786afd754 100644 --- a/drivers/media/i2c/ov5693.c +++ b/drivers/media/i2c/ov5693.c @@ -404,8 +404,8 @@ static int ov5693_read_reg(struct ov5693_device *ov5693, u32 addr, u32 *value) ret = i2c_transfer(client->adapter, msg, 2); if (ret < 0) return dev_err_probe(&client->dev, ret, - "Failed to read register 0x%04x: %d\n", - addr & OV5693_REG_ADDR_MASK, ret); + "Failed to read register 0x%04x\n", + addr & OV5693_REG_ADDR_MASK); *value = 0; for (i = 0; i < len; ++i) {