Message ID | 919a9e77958e3a9fee3e473fd714c4add2991b33.1703710628.git.u.kleine-koenig@pengutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-12259-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1665455dyb; Wed, 27 Dec 2023 13:03:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IEBq9a/2GzWhSTPo7z3rwzmb6lDlgnZEZAFEAq8meERPjs5Zq5yXUiaFViFRMYa/MHpX5rY X-Received: by 2002:a50:c018:0:b0:555:3b23:1d60 with SMTP id r24-20020a50c018000000b005553b231d60mr1673665edb.51.1703711009663; Wed, 27 Dec 2023 13:03:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703711009; cv=none; d=google.com; s=arc-20160816; b=aRLIxL0nXInOXew2wz78cAPXydjuvn8c09/U5wneT0HNMpMmGdxfi37f7XSg+kmB0F 7efy9OSdHGUgfzKgJ/I8nXJfqPe3URjpas82K+xe6LWDpFZJ+L/TEUzAfsP5C9eXvbMw xAfvvr2532H4NWA6d5U+jkG9qJlwzRjnD+oW1Cdw2sZUdHhlyqfrdk/0s1mBm75RKyzL uk4WerDeAaUZdXT8qZp2H9QWuYAzPIRQn4eMWIGfrKTa+5TQhmHkn/0x8mizZrM/t8oz AK3TbJasMI+WH3XXRX3Fo96SwMLgWsPAAkoGe5hQzuRJVALYFMYJ7NemMyrxEF8RoGHO jwFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=GL5PB6fSFH6vkmrxY+bh/EmaqAcTkBrj5oOpcerlx50=; fh=9apTFCoTOjehv4Wznv2mb2xpDvZrq4o37EMnyVq2a9A=; b=DTrPmMUABiZq5LDBi9hTGEgTO2Cw2rQJhR+apA+BVgiSl6EFgNCjHY4fvv0TaLdKO7 mO8DPtKffGT8lGTQUovamDolABp2z7QRvr2xNMTcO9RgONGB5xmHYJFi+85Hz15URVKH WvLfUwbJ1MrojP1h2ipIAYtLuK7MkHobxeMGj6atq+d1V6oXfF3yQE1k4DVhQpihxDop nD2yNeWBzCh9wM1iF8O8nacieOl14kNSjNCQdhySLNKvoHV31Lsi4Zob67NZS4QdqL+l rDpdLaY/7YusYCUMF1RDWe5G6uDhyNK5OMD/gl6/yFiWKl6cV7V3gKBvf7v7cWyHy6dY LIeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12259-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12259-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a3-20020a50c303000000b0055511698b5bsi2016044edb.387.2023.12.27.13.03.29 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 13:03:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12259-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12259-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12259-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4B11F1F22FCF for <ouuuleilei@gmail.com>; Wed, 27 Dec 2023 21:03:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 283884879B; Wed, 27 Dec 2023 21:03:03 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D547A47F79 for <linux-kernel@vger.kernel.org>; Wed, 27 Dec 2023 21:02:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1rIb3J-0000mc-Nc; Wed, 27 Dec 2023 22:02:57 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1rIb3I-001wEw-7j; Wed, 27 Dec 2023 22:02:57 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from <ukl@pengutronix.de>) id 1rIb3J-001ZVU-0m; Wed, 27 Dec 2023 22:02:57 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Jassi Brar <jassisinghbrar@gmail.com> Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 04/12] mailbox: mailbox-test: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 22:02:32 +0100 Message-ID: <919a9e77958e3a9fee3e473fd714c4add2991b33.1703710628.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <cover.1703710628.git.u.kleine-koenig@pengutronix.de> References: <cover.1703710628.git.u.kleine-koenig@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1875; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=2Acds6dO5piUOAVFehlpJWz3DbSbQSTHBdOgG/XhSGc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljJDqNnoboat7qdmB2aD1OkkF8K0e5IDZbr7Lb NgGvZfkKPKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYyQ6gAKCRCPgPtYfRL+ TrtbB/kBNSNYr6CiYZ5+Iqb+3kPQ5dPw3J3J17sxWCdHG2fK1X3m7VoIK6/E2QiRHQDMjthjFdg 1HDhwGWDkklLUXI5okyKPtdeWPHixZXx1joX8U9Zfm3AqmUlPen+bl6HypkPDENKqwUn9Z78Cwp skP7eDM0aCZ3zWk2G5u4rY6GlO7vtvTJLQTAADtS2ein/bi2V3KJixCQ96ss87nXXE72jR4QGyS /Gu0AuWDVay78xUapUcBsladtb7IzUNGmn4Y1PnjTwThtNx6ZtRiLf/+IeJFK9HUyYPGLJP9yTi z0dKoLmKwQOCsR+jxXlUMd8NBSZDrxR/Svh1b35sSKK+DUvE X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786470475440669367 X-GMAIL-MSGID: 1786470475440669367 |
Series |
mailbox: Convert to platform remove callback returning void
|
|
Commit Message
Uwe Kleine-König
Dec. 27, 2023, 9:02 p.m. UTC
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/mailbox/mailbox-test.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c index 22d6018ceec3..3386b4e72551 100644 --- a/drivers/mailbox/mailbox-test.c +++ b/drivers/mailbox/mailbox-test.c @@ -418,7 +418,7 @@ static int mbox_test_probe(struct platform_device *pdev) return 0; } -static int mbox_test_remove(struct platform_device *pdev) +static void mbox_test_remove(struct platform_device *pdev) { struct mbox_test_device *tdev = platform_get_drvdata(pdev); @@ -428,8 +428,6 @@ static int mbox_test_remove(struct platform_device *pdev) mbox_free_channel(tdev->tx_channel); if (tdev->rx_channel) mbox_free_channel(tdev->rx_channel); - - return 0; } static const struct of_device_id mbox_test_match[] = { @@ -444,7 +442,7 @@ static struct platform_driver mbox_test_driver = { .of_match_table = mbox_test_match, }, .probe = mbox_test_probe, - .remove = mbox_test_remove, + .remove_new = mbox_test_remove, }; module_platform_driver(mbox_test_driver);