diff mbox series

[v2] Staging: pi433: Updated bitrate range from datasheet

Message ID 91454ef9b4a12f01e13d69b675d81aff@iitb.ac.in
State New
Headers
Series [v2] Staging: pi433: Updated bitrate range from datasheet |

Commit Message

Aman Sharma March 4, 2024, 5:53 a.m. UTC 
  Updated bitrate range for FSK and OOK modulation from the RFM69 
Datasheet.
The values are mentioned in Section 2.3.2 of the datasheet.

Signed-off-by: Aman Sharma<amansharma6122002@gmail.com>
---
  drivers/staging/pi433/Documentation/pi433.txt | 6 ++++--
  drivers/staging/pi433/TODO                    | 1 -
  2 files changed, 4 insertions(+), 3 deletions(-)

-* Some missing data (marked with ###) needs to be added in the 
documentation

Comments

Greg KH March 4, 2024, 6:20 a.m. UTC | #1 
On Mon, Mar 04, 2024 at 11:23:40AM +0530, Aman Sharma wrote:
> Updated bitrate range for FSK and OOK modulation from the RFM69 Datasheet.
> The values are mentioned in Section 2.3.2 of the datasheet.
> 
> Signed-off-by: Aman Sharma<amansharma6122002@gmail.com>
> ---
>  drivers/staging/pi433/Documentation/pi433.txt | 6 ++++--
>  drivers/staging/pi433/TODO                    | 1 -
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/pi433/Documentation/pi433.txt
> b/drivers/staging/pi433/Documentation/pi433.txt
> index 4a0d34b4ad37..9ce7282ef6f8 100644
> --- a/drivers/staging/pi433/Documentation/pi433.txt
> +++ b/drivers/staging/pi433/Documentation/pi433.txt
> @@ -78,7 +78,8 @@ rf params:
>  		Allowed values: 433050000...434790000
>  	bit_rate
>  		bit rate used for transmission.
> -		Allowed values: #####
> +		Allowed values (For FSK): 1200...320000
> +		Allowed values (For OOK): 1200...32768
>  	dev_frequency
>  		frequency deviation in case of FSK.
>  		Allowed values: 600...500000
> @@ -169,7 +170,8 @@ rf params:
>  		Allowed values: 433050000...434790000
>  	bit_rate
>  		bit rate used for transmission.
> -		Allowed values: #####
> +		Allowed values (For FSK): 1200...320000
> +		Allowed values (For OOK): 1200...32768
>  	dev_frequency
>  		frequency deviation in case of FSK.
>  		Allowed values: 600...500000
> diff --git a/drivers/staging/pi433/TODO b/drivers/staging/pi433/TODO
> index 63a40bfcc67e..61ed3a1578bc 100644
> --- a/drivers/staging/pi433/TODO
> +++ b/drivers/staging/pi433/TODO
> @@ -2,4 +2,3 @@
>  * still TODOs, annotated in the code
>  * currently the code introduces new IOCTLs. I'm afraid this is a bad idea.
>    -> Replace this with another interface, hints are welcome!
> -* Some missing data (marked with ###) needs to be added in the
> documentation
> -- 
> 2.34.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot
Dan Carpenter March 4, 2024, 8:25 a.m. UTC | #2 
On Mon, Mar 04, 2024 at 11:23:40AM +0530, Aman Sharma wrote:
> Updated bitrate range for FSK and OOK modulation from the RFM69 Datasheet.
> The values are mentioned in Section 2.3.2 of the datasheet.

Have you tested these as well?  Sending untested patches is not
necessarily against the rules, but it seems like maybe you have this
hardware and can test it.  Could you please talk about what testing you
did?

> 
> Signed-off-by: Aman Sharma<amansharma6122002@gmail.com>
                            ^
Missing space.

regards,
dan carpenter
Aman Sharma March 4, 2024, 8:34 a.m. UTC | #3 
Tbh this is my first patch and I don't have the hardware to test this. I 
thought updating the values from the datasheet directly might be a good 
idea as it would be the correct range. Please correct me if there is 
something that I missed / need to know.

On 2024-03-04 13:55, Dan Carpenter wrote:
> On Mon, Mar 04, 2024 at 11:23:40AM +0530, Aman Sharma wrote:
>> Updated bitrate range for FSK and OOK modulation from the RFM69 
>> Datasheet.
>> The values are mentioned in Section 2.3.2 of the datasheet.
> 
> Have you tested these as well?  Sending untested patches is not
> necessarily against the rules, but it seems like maybe you have this
> hardware and can test it.  Could you please talk about what testing you
> did?
> 
>> 
>> Signed-off-by: Aman Sharma<amansharma6122002@gmail.com>
>                             ^
> Missing space.
> 

I'll fix this if I am allowed to submit a new patch.

> regards,
> dan carpenter
Dan Carpenter March 4, 2024, 10:18 a.m. UTC | #4 
On Mon, Mar 04, 2024 at 02:04:08PM +0530, Aman Sharma wrote:
> Tbh this is my first patch and I don't have the hardware to test this. I
> thought updating the values from the datasheet directly might be a good idea
> as it would be the correct range. Please correct me if there is something
> that I missed / need to know.
> 

No, patch is fine.  There is no downside to updating the .txt
documentation in this way.  I was just wondering.

> On 2024-03-04 13:55, Dan Carpenter wrote:
> > On Mon, Mar 04, 2024 at 11:23:40AM +0530, Aman Sharma wrote:
> > > Updated bitrate range for FSK and OOK modulation from the RFM69
> > > Datasheet.
> > > The values are mentioned in Section 2.3.2 of the datasheet.
> > 
> > Have you tested these as well?  Sending untested patches is not
> > necessarily against the rules, but it seems like maybe you have this
> > hardware and can test it.  Could you please talk about what testing you
> > did?
> > 
> > > 
> > > Signed-off-by: Aman Sharma<amansharma6122002@gmail.com>
> >                             ^
> > Missing space.
> > 
> 
> I'll fix this if I am allowed to submit a new patch.

regards,
dan carpenter
diff mbox series

Patch

diff --git a/drivers/staging/pi433/Documentation/pi433.txt 
b/drivers/staging/pi433/Documentation/pi433.txt
index 4a0d34b4ad37..9ce7282ef6f8 100644
--- a/drivers/staging/pi433/Documentation/pi433.txt
+++ b/drivers/staging/pi433/Documentation/pi433.txt
@@ -78,7 +78,8 @@  rf params:
  		Allowed values: 433050000...434790000
  	bit_rate
  		bit rate used for transmission.
-		Allowed values: #####
+		Allowed values (For FSK): 1200...320000
+		Allowed values (For OOK): 1200...32768
  	dev_frequency
  		frequency deviation in case of FSK.
  		Allowed values: 600...500000
@@ -169,7 +170,8 @@  rf params:
  		Allowed values: 433050000...434790000
  	bit_rate
  		bit rate used for transmission.
-		Allowed values: #####
+		Allowed values (For FSK): 1200...320000
+		Allowed values (For OOK): 1200...32768
  	dev_frequency
  		frequency deviation in case of FSK.
  		Allowed values: 600...500000
diff --git a/drivers/staging/pi433/TODO b/drivers/staging/pi433/TODO
index 63a40bfcc67e..61ed3a1578bc 100644
--- a/drivers/staging/pi433/TODO
+++ b/drivers/staging/pi433/TODO
@@ -2,4 +2,3 @@ 
  * still TODOs, annotated in the code
  * currently the code introduces new IOCTLs. I'm afraid this is a bad 
idea.
    -> Replace this with another interface, hints are welcome!